Skip to content

test(core): allow cold Windows shell startup - #98

Merged
trmosala merged 1 commit into
CM-Split-v2from
windows-shell-startup
Oct 21, 2026
Merged

trmosala merged 1 commit into
CM-Split-v2from
windows-shell-startup

Conversation

@trmosala

Copy link
Copy Markdown
Owner

Issue for this PR

Follow-up to the final verification of #84 and PR #96.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The Windows shell-concurrency fixture failed while waiting five seconds for the first child process's startup file. That gate includes Location plugin activation and cold PowerShell startup. Allow 15 seconds for that Windows startup gate and 30 seconds for the enclosing Windows fixture, which can start two children. Other platforms retain their existing deadlines.

Keep all file gates, active-model checks, independent shell completion checks, inbox ordering and cleanup behavior. This changes test allowances only.

How did you verify your code works?

The final Windows unit job reports one failure in Session.shell > runs shells concurrently with an active model and waits for each shell's own completion. Its stack identifies the five-second startup gate in launch, not the overall CI budget. Cleanup subsequently reports EBUSY because the child had not reached its release gate.

Canonical lint/type checks passed all 37 packages. No tests were rerun: the user requested one final test pass after all 36 implementation tickets were closed. This follow-up keeps automatic CI deferred with [skip ci]. The adjusted Windows deadline remains unverified by a fresh test run.

The parent integration's complete Linux unit/package/browser/component jobs and signed packaged Mac qualification passed. This patch changes no production source, and does not claim a fresh artifact or Windows unit pass.

Screenshots / recordings

Not applicable to a test startup allowance.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • Not all checklist items are checked. Please confirm you have tested locally and have not included unrelated changes.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@trmosala
trmosala merged commit ac02f11 into CM-Split-v2 Oct 21, 2026
3 of 4 checks passed
@trmosala
trmosala deleted the windows-shell-startup branch October 21, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant