Repository navigation
test(core): allow cold Windows shell startup - #98
Merged
Merged
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Follow-up to the final verification of #84 and PR #96.
Type of change
What does this PR do?
The Windows shell-concurrency fixture failed while waiting five seconds for the first child process's startup file. That gate includes Location plugin activation and cold PowerShell startup. Allow 15 seconds for that Windows startup gate and 30 seconds for the enclosing Windows fixture, which can start two children. Other platforms retain their existing deadlines.
Keep all file gates, active-model checks, independent shell completion checks, inbox ordering and cleanup behavior. This changes test allowances only.
How did you verify your code works?
The final Windows unit job reports one failure in
Session.shell > runs shells concurrently with an active model and waits for each shell's own completion. Its stack identifies the five-second startup gate inlaunch, not the overall CI budget. Cleanup subsequently reports EBUSY because the child had not reached its release gate.Canonical lint/type checks passed all 37 packages. No tests were rerun: the user requested one final test pass after all 36 implementation tickets were closed. This follow-up keeps automatic CI deferred with
[skip ci]. The adjusted Windows deadline remains unverified by a fresh test run.The parent integration's complete Linux unit/package/browser/component jobs and signed packaged Mac qualification passed. This patch changes no production source, and does not claim a fresh artifact or Windows unit pass.
Screenshots / recordings
Not applicable to a test startup allowance.
Checklist