Skip to content

test(app): stabilize loading motion phase checks - #95

Closed
trmosala wants to merge 8 commits into
CM-Split-v2from
loading-motion-flag
Closed

trmosala wants to merge 8 commits into
CM-Split-v2from
loading-motion-flag

Conversation

@trmosala

Copy link
Copy Markdown
Owner

Windows can freeze SVG image animation independently of page reduced-motion emulation. Pin Chromium's image preference to normal motion and give the compared fixture rows their own compositing layers, avoiding raster differences while preserving every existing phase, late-mount, theme, session and reduced-motion assertion.

The #90 change is two files on reviewed CI base 4e0e1af from #87. This PR therefore includes that unmerged dependency when compared with CM-Split-v2.

Validation: the full app browser suite passes 176 tests with 1,829 assertions. The candidate passes 10 real test runs and 12 additional phase-logged runs. All three deliberate separate-image-timeline controls fail the first phase assertion, so the layer change still detects desynchronization. Coordinator reviewed the exact two-file diff at 2e23eda.

Direct hosted Linux/Windows repeats and the final combined CI matrix remain pending. Refs #90; keep the issue open until integration is verified.

tiisetso added 8 commits October 20, 2026 09:15
Replace unavailable Blacksmith labels with ubuntu-24.04 and windows-2025
for PR tests and duplicate checks. Preserve every job, matrix entry and
command while allowing this fork's queued checks to start.
Pin Chromium's reduced-motion preference so SVG images animate on Windows runners, and give each compared fixture row its own layer so identical rows raster from the same tile origin. Assertions, tolerances and timings are unchanged.

Refs #90
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@trmosala

Copy link
Copy Markdown
Owner Author

Superseded by PR #96, squashed into CM-Split-v2 as 290d7d6353c0c7a4a356af780b5687f2dcfe5cfc. This PR's current head was checked against the reviewed head and is an ancestor of integration source 68ab9205709350385471eb2d383b3cff3c18e678; the squash commit's tree matches that source exactly. Later corrections and the actual private dependency pin are included there.

Closing this earlier PR as superseded, not claiming it was independently merged. Its branch remains intact. Final combined verification is deferred until the scoped implementation issues are closed, as requested by the user.

@trmosala trmosala closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant