Skip to content

fix(desktop): pin WPP session and pool cleanup - #88

Closed
trmosala wants to merge 2 commits into
CM-Split-v2from
wpp-detach-pin
Closed

trmosala wants to merge 2 commits into
CM-Split-v2from
wpp-detach-pin

Conversation

@trmosala

@trmosala trmosala commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Updates the optional WPP dependency and lockfile to 572e4494be63c6bf8cfb5ca18f2738f3dc8ec5b7, incorporating reviewed private PRs #25 and #26.

  • Detached CDP sessions are removed from both tracking structures, so replaced iframes do not accumulate stale IDs or receive late installers.
  • Retiring a worker pool cancels pending acquisitions, including queued and in-progress startup work. Caller cancellation retains its existing behavior; jobs pending in a retired pool fail promptly instead of opening an unreaped worker window.

Validation on the updated pin: locked private installation succeeds, production WPP plugins build, all 55 host contract tests pass with 545 expectations, and the WPP desktop production build passes. The prior generic build physically removed the private package and passed; its host source and private-absent inputs are unchanged by this dependency-only follow-up. Latest head c0242677f3 passes the full root lint/type-check gate through the normal push hook: all 37 tasks pass, 36 from cache.

Private package verification: 495 tests pass, type-checking and declaration generation pass, and both PRs received independent coordinator reviews. The CDP fix also passed an isolated real Electron 44.4.5 fixture replacing 12 cross-site iframes; the old dependency retained all 12 and failed the identical assertion. Worker-pool cancellation tests use the real coordinator and bridge with the Electron spawn boundary stubbed. Live WPP sign-in replacement was not exercised.

No installed app is changed or released. These fixes do not establish the cause of the earlier CM shutdown.

Refs trmosala/CM-WPP-Bits#6 and trmosala/CM-WPP-Bits#21. Hosted checks await CI repair #87 and the verified browser regression investigations #89 and #90. Keep the paired private issues open until host integration.

@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@trmosala trmosala changed the title fix(desktop): pin WPP detached session cleanup fix(desktop): pin WPP session and pool cleanup Oct 20, 2026
@trmosala

Copy link
Copy Markdown
Owner Author

Superseded by PR #96, squashed into CM-Split-v2 as 290d7d6353c0c7a4a356af780b5687f2dcfe5cfc. This PR's current head was checked against the reviewed head and is an ancestor of integration source 68ab9205709350385471eb2d383b3cff3c18e678; the squash commit's tree matches that source exactly. Later corrections and the actual private dependency pin are included there.

Closing this earlier PR as superseded, not claiming it was independently merged. Its branch remains intact. Final combined verification is deferred until the scoped implementation issues are closed, as requested by the user.

@trmosala trmosala closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant