Repository navigation
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
Superseded by PR #96, squashed into Closing this earlier PR as superseded, not claiming it was independently merged. Its branch remains intact. Final combined verification is deferred until the scoped implementation issues are closed, as requested by the user. |
Updates the optional WPP dependency and lockfile to
572e4494be63c6bf8cfb5ca18f2738f3dc8ec5b7, incorporating reviewed private PRs #25 and #26.Validation on the updated pin: locked private installation succeeds, production WPP plugins build, all 55 host contract tests pass with 545 expectations, and the WPP desktop production build passes. The prior generic build physically removed the private package and passed; its host source and private-absent inputs are unchanged by this dependency-only follow-up. Latest head
c0242677f3passes the full root lint/type-check gate through the normal push hook: all 37 tasks pass, 36 from cache.Private package verification: 495 tests pass, type-checking and declaration generation pass, and both PRs received independent coordinator reviews. The CDP fix also passed an isolated real Electron 44.4.5 fixture replacing 12 cross-site iframes; the old dependency retained all 12 and failed the identical assertion. Worker-pool cancellation tests use the real coordinator and bridge with the Electron spawn boundary stubbed. Live WPP sign-in replacement was not exercised.
No installed app is changed or released. These fixes do not establish the cause of the earlier CM shutdown.
Refs trmosala/CM-WPP-Bits#6 and trmosala/CM-WPP-Bits#21. Hosted checks await CI repair #87 and the verified browser regression investigations #89 and #90. Keep the paired private issues open until host integration.