You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(browser): show inspection refresh failures alongside retained site data #82
After one successful site inspection, a failed refresh leaves the old same-origin siteData truthy. The failure message lives only in the Show fallback, so the UI hides the error and continues displaying stale counts.
Priority: low. Reviewed CookieMonster CM-Split-v2 at dafdcd4171466050c984d524ca0d1a09d31f100e; links use the identical remote V2 source on Ubuntu 26.04.1 x64, Bun 1.4.2.
Steps to reproduce and evidence
Rechecked the V2 BrowserSite implementation: inspect sets inspectionFailed on false/rejection, but the failure status is rendered only when data() is absent. A success -> failed refresh therefore hides the failure. This is rendering/control-flow verification; no new mounted UI test was run.
Acceptance criteria and verification
Show refresh failure even when previous site data exists, and identify retained results as stale.
Keep initial loading/failure and navigation-to-another-origin behavior correct.
Add a mounted production-component test for success -> failed refresh -> successful retry, preserving existing English copy unless explicitly changed.
An uncommitted legacy worktree patch exists from CM's subagent. Port and verify it against this V2 component path rather than treating that attempt as landed.
Merged into CM-Split-v2 as 290d7d6353c0c7a4a356af780b5687f2dcfe5cfc through PR #96. Its tree exactly matches reviewed source 68ab9205709350385471eb2d383b3cff3c18e678.
Implemented in PR #96, reviewed source 68ab9205709350385471eb2d383b3cff3c18e678.
The mounted production inspection component now shows a refresh error over retained same-origin data, marks the data stale, recovers on retry and clears old data on origin changes. The visible error uses the existing translation system.
Final verification is deferred at the user's explicit request to finish and close the implementation issues before one final test pass. This closure records implementation completion, not a claim that the final combined/platform checks have passed. Any failure in that pass will be recorded against the relevant issue.
Activity
trmosala commentedon Oct 21, 2026
Merged into
CM-Split-v2as290d7d6353c0c7a4a356af780b5687f2dcfe5cfcthrough PR #96. Its tree exactly matches reviewed source68ab9205709350385471eb2d383b3cff3c18e678.Implemented in PR #96, reviewed source
68ab9205709350385471eb2d383b3cff3c18e678.The mounted production inspection component now shows a refresh error over retained same-origin data, marks the data stale, recovers on retry and clears old data on origin changes. The visible error uses the existing translation system.
Final verification is deferred at the user's explicit request to finish and close the implementation issues before one final test pass. This closure records implementation completion, not a claim that the final combined/platform checks have passed. Any failure in that pass will be recorded against the relevant issue.