Repository navigation
Conversation
Replace unavailable Blacksmith labels with ubuntu-24.04 and windows-2025 for PR tests and duplicate checks. Preserve every job, matrix entry and command while allowing this fork's queued checks to start.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
Final source review and platform update for CM reviewed and approved the exact async Node cleanup commit The unchanged full Node build and compiled service lifecycle gates now pass on both Linux and Windows. This verifies the actual build/smoke path; it does not instrument or force a Windows sharing violation. The unit jobs remain red: Linux has the first nested legacy PowerShell test exceeding its five-second limit; Windows has the skill-toggle-across-locations test exceeding its five-second limit. The earlier Windows MCP reuse timeout did not recur in this run. Browser suites are still running. No test deadlines or assertions have been changed to pass these gates, and this PR remains unmerged. |
|
Superseded by PR #96, squashed into Closing this earlier PR as superseded, not claiming it was independently merged. Its branch remains intact. Final combined verification is deferred until the scoped implementation issues are closed, as requested by the user. |
V2 pull requests queued indefinitely because this fork has no runners matching the Blacksmith labels. Use GitHub-hosted Ubuntu 24.04 and Windows 2025 for the existing matrix, plus Ubuntu for duplicate checking. No jobs are removed.
Fresh hosted images also need the locked Electron binary, the desktop suite's existing shared preload, Chromium and ripgrep. Electron installation now uses Node module resolution for both isolated and hoisted dependency layouts. Shared setup pins Node 24.15, matching the existing browser extraction requirement. Workspace unit tests run serially after the earlier run exposed process-start failures; resource pressure remains an inference, not a proven diagnosis.
Preserve audited CookieJar vendor bytes on Windows through Git attributes. The POSIX-only successful macOS installer fixtures explicitly skip Windows; they still run on Linux/macOS, and platform-independent rejection checks remain enabled on Windows. This does not validate a packaged macOS app. Generic build expectations now include the intentional optional-WPP bundling exclusion.
The Windows download collision regression found an actual runtime defect: exclusive copy reports EPERM for an existing directory. Try the next name only for that Windows directory case. Other permission failures still propagate, and exclusive copy still protects existing data. The existing regression covers files, directories, symlinks and concurrent collisions.
Browser fixture repairs keep production assertions meaningful:
4478c204e54c, retaining menu, selection and keyboard checks.Validation: canonical root lint has zero errors and all 37 type-check tasks pass. The full serial hosted Linux unit suite passes. The desktop suite passed 545 tests on hosted Linux. The provider fix passes all 11 unchanged web-search component tests and all six question-dock tests. The modal fix passes all nine What's New production-browser tests, plus a deterministic modal-first control that fails with the original readiness locator. These local browser runs use one worker and no retries.
Additional end-to-end-only type-checking reports four errors in three unchanged fixtures. An independent baseline run produces byte-for-byte identical diagnostics; this change adds none. That auxiliary check is not claimed green.
Two subsequent Windows failures also needed setup fixes. Storybook now resolves Solid Query through normal package lookup and deduplicates it, while explicitly keeping it unbundled as the previous alias did. The old alias required
packages/app/node_modules, which does not exist under the hoisted Windows layout and returned 404 for the composer preview module.The Node SEA smoke commands completed successfully, but Windows reported EBUSY while removing their temporary executable. Cleanup now uses the already-verified host Node binary's asynchronous filesystem removal with bounded retries. Its top-level await preserves failures through the existing subprocess exit check. A controlled transient-EMFILE probe returns immediately under Bun despite retry options, while Node's asynchronous removal retries successfully. The exact cleanup expression also passes owned-directory removal and non-zero rejection checks.
These follow-ups do not make the entire matrix green yet. The final config's startup control passes, but stronger local component checks still expose fixture-navigation reloads: 26/28 focused hoisted tests pass, and one of two isolated context tests fails during navigation. Earlier full-layout runs also exposed composer-focus flakes seen on the baseline. No assertions, timeouts or retry defaults were relaxed. The complete asynchronous-cleanup Node build is running; an earlier synchronous variant passed locally under Bun's lower-memory mode, which does not verify the final asynchronous Windows lock path.
Independent CM review approved bootstrap head
98b57d5349and fixture headbfb11aa3a5. Final package-resolution and cleanup commits33f140626cand4e0e1af8dfhave passed the combined root check; their independent review and hosted confirmation are pending. Hosted integration still needs #89 history paging, #90 loading fixture and reviewed SDK fix #92. Windows Storybook module 404s also remain under investigation. Do not merge before the combined required checks pass.The duplicate metadata job uses pull_request_target, so this PR itself still uses the old base workflow and queues for Blacksmith. Its runner-label repair takes effect after base integration. No fabricated statuses or test bypasses. The installed app has not been updated and no release is included.