Repository navigation
Conversation
Replace unavailable Blacksmith labels with ubuntu-24.04 and windows-2025 for PR tests and duplicate checks. Preserve every job, matrix entry and command while allowing this fork's queued checks to start.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
Independent installed CM read-only source review approved exact commit Non-blocking limits: symlink discovery/file-only behavior is supported by the existing helper and source inspection, without a dedicated discovery fixture. The workerd stub exports only the registration list, so any future direct Plugin importer must respect that boundary. Hosted checks remain required before merging. |
|
Superseded by PR #96, squashed into Closing this earlier PR as superseded, not claiming it was independently merged. Its branch remains intact. Final combined verification is deferred until the scoped implementation issues are closed, as requested by the user. |
The common plugin graph pulled the native AE bundle loader into workerd. The packed SDK check rejected Bun.Glob, and replacing the glob alone then exposed a worker startup failure from the loader's variable dynamic import.
Add a workerd/default package-import boundary using the existing platform pattern. Workerd registers no native AE plugin; Bun and Node retain the desktop plugin. Shared skill discovery reuses the existing portable Glob helper with absolute file-only results and symlink traversal.
Closes #91. Targets the explicitly requested V2 branch CM-Split-v2 and includes the CI bootstrap commits from #87.
Validation: four focused platform/skill tests pass with 13 expectations. The unchanged full packed SDK verifier passes Bun and Node consumers, the workerd bundle guards, Wrangler dry-run, and a real Miniflare health boot. Separate serial type-check and canonical root
bun run checkverification both pass all 37 tasks; lint has zero errors. Independent installed CM source review approved exact commit28eaf96c19, with no blockers. The coordinator ran the reported checks.The installed desktop was not rebuilt or updated. Hosted Linux run
39399663921now passes the complete unit job, including the full packed SDK gate. Windows still fails the separate loading fixture #90 before SDK verification, so combined integration remains blocked. Hosted Linux and Windows checks on the final combined head remain required before merging.