Skip to content

fix(core): keep native AE loading out of workerd - #92

Closed
trmosala wants to merge 5 commits into
CM-Split-v2from
portable-ae-skills
Closed

trmosala wants to merge 5 commits into
CM-Split-v2from
portable-ae-skills

Conversation

@trmosala

@trmosala trmosala commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

The common plugin graph pulled the native AE bundle loader into workerd. The packed SDK check rejected Bun.Glob, and replacing the glob alone then exposed a worker startup failure from the loader's variable dynamic import.

Add a workerd/default package-import boundary using the existing platform pattern. Workerd registers no native AE plugin; Bun and Node retain the desktop plugin. Shared skill discovery reuses the existing portable Glob helper with absolute file-only results and symlink traversal.

Closes #91. Targets the explicitly requested V2 branch CM-Split-v2 and includes the CI bootstrap commits from #87.

Validation: four focused platform/skill tests pass with 13 expectations. The unchanged full packed SDK verifier passes Bun and Node consumers, the workerd bundle guards, Wrangler dry-run, and a real Miniflare health boot. Separate serial type-check and canonical root bun run check verification both pass all 37 tasks; lint has zero errors. Independent installed CM source review approved exact commit 28eaf96c19, with no blockers. The coordinator ran the reported checks.

The installed desktop was not rebuilt or updated. Hosted Linux run 39399663921 now passes the complete unit job, including the full packed SDK gate. Windows still fails the separate loading fixture #90 before SDK verification, so combined integration remains blocked. Hosted Linux and Windows checks on the final combined head remain required before merging.

tiisetso added 5 commits October 20, 2026 09:15
Replace unavailable Blacksmith labels with ubuntu-24.04 and windows-2025
for PR tests and duplicate checks. Preserve every job, matrix entry and
command while allowing this fork's queued checks to start.
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@trmosala

Copy link
Copy Markdown
Owner Author

Independent installed CM read-only source review approved exact commit 28eaf96c19f8291fb4dd51fffb1437e345e7e362, with no blockers. CM verified the conditional-import graph, unchanged native registration, portable glob semantics and dependency declarations. CM did not rerun tests; the coordinator ran the focused tests, full packed SDK runtime verification, canonical check and normal push hook.

Non-blocking limits: symlink discovery/file-only behavior is supported by the existing helper and source inspection, without a dedicated discovery fixture. The workerd stub exports only the registration list, so any future direct Plugin importer must respect that boundary. Hosted checks remain required before merging.

@trmosala

Copy link
Copy Markdown
Owner Author

Superseded by PR #96, squashed into CM-Split-v2 as 290d7d6353c0c7a4a356af780b5687f2dcfe5cfc. This PR's current head was checked against the reviewed head and is an ancestor of integration source 68ab9205709350385471eb2d383b3cff3c18e678; the squash commit's tree matches that source exactly. Later corrections and the actual private dependency pin are included there.

Closing this earlier PR as superseded, not claiming it was independently merged. Its branch remains intact. Final combined verification is deferred until the scoped implementation issues are closed, as requested by the user.

@trmosala trmosala closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant