Skip to content

✨ Add Apple MLX local inference and first-class ClankeR onboarding - #15842

Merged
hivecommons-hive[bot] merged 6 commits into
v5from
feat/clanker-mlx
Oct 30, 2026
Merged

hivecommons-hive[bot] merged 6 commits into
v5from
feat/clanker-mlx

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Summary

Fixes #15839.

Adds optional, first-class Apple MLX local inference for ClankeR, using the existing Pi coding agent, not a pretend MLX coding CLI or a hosted Hive backend.

  • Dedicated Apple MLX /contribute selector, branded tile, anchored requirements/help and OS/mode/runtime-aware copyable command generator. UI engine mlx maps to actual executor pi and model mlx/<exact-model-id-or-path>.
  • just contribute-mlx-serve <already-downloaded-model> explicitly starts foreground, offline MLX-LM on Mac loopback; just contribute-mlx-setup <model> --verify-tools explicitly opts into two bounded streamed tool-call/result checks; just contribute-mlx launches the actual Pi contributor workflow. Explicit MLX selections survive saved hosted-provider profiles without changing generic Pi precedence.
  • Native Apple Silicon/macOS 14+/Python 3.10+ checks; missing runtime/model/config/server and unsupported Intel/Rosetta/non-Mac inference hosts fail explicitly. No auto-download, package install, public listener, hosted-provider fallback or memory-policy changes.
  • Pi owns file edits, shell/test tools, streamed tool execution and task lifecycle. ClankeR retains assignment, trust/model admission, cancellation, progress and PR-result reporting. A Pi extension delegates to its maintained streaming adapter with loopback-only, redirect-rejecting inference fetch; private hive-mlx API fails closed if the extension is missing.
  • MLX-LM stays on the Mac host. Pi/tools run inside the contributor container, using the existing Pi host-network mechanism. Requires Docker Desktop 4.34+ host networking explicitly enabled by the contributor; Podman machine and Kubernetes cannot use this loopback Mac route. Native Pi remains unconfined and retains its separate dangerous opt-in.
  • Public homepage Local AI inference / Apple MLX integration group links to real hub /contribute#apple-mlx setup/usage instructions, not Apple sign-in or endorsement. Integration catalog, backend/inference/environment guides, helper index, RAM/model/troubleshooting docs and changelog are aligned.

Canonical workflow

# In a separate terminal, after explicitly installing dependencies in a native venv
# and downloading a tool-capable model yourself within your shared-RAM budget:
HIVE_MLX_PYTHON="$PWD/.venv-mlx/bin/python" just contribute-mlx-serve /Users/YOU/models/tool-coder
# In the launch terminal, also export HIVE_MLX_PYTHON to that virtualenv:
just contribute-mlx-setup /Users/YOU/models/tool-coder --verify-tools
export AGENT_MODEL=mlx//Users/YOU/models/tool-coder
export HIVE_HUB=https://YOUR-CHOSEN-HIVE
just contribute-check pi
just contribute-setup pi
just contribute-mlx

Full installation instructions are in src/docs/contributor-relay.md#apple-mlx-local-inference and generated by the selected hive's /contribute page. Not every MLX model supports structured tools; passing the probe is not a coding-quality benchmark. Host weights/KV cache consume shared RAM outside the relay container's memory cap.

Version assumptions and sources

Protocol/source checked against MLX-LM v0.32.2 and published Pi 1.4.0 APIs; contributor image pins Pi 1.4.0 and this route requires at least that guarded transport API. Other MLX-LM versions must pass the same explicit tool round trip.

Validation and limits

  • Added mock HTTP/SSE/runtime/config tests, loopback/redirect and guarded-Pi delegation checks, task argv/result/cancellation coverage, mocked offline server argv, recipe/profile-precedence shell seam, actual UI command-generator execution, rendered onboarding and homepage grouping regressions. CI invokes the Node suites; existing Go CI covers both modules.
  • Code-reviewed the initial integration and expanded onboarding. Fixed redirected inference transport and explicit-model precedence findings.
  • Local work was restricted to source inspection, gofmt and Git diff checks per AGENTS.md; no local Go/Node repository suites, builds or citation guards were run.
  • CI is queued; no green verdict is claimed. Any actual citation drift will be fixed only after the guard reports it, per repository policy.
  • Live Apple GPU inference and Docker Desktop connectivity remain unverified. No packages, weights or model workloads were installed/downloaded/started on the owner's laptop; no live settings, queues or deployments changed.

No merge, approval or deployment requested by this PR task.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson
clubanderson requested a review from hanthor as a code owner October 30, 2026 17:35
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15853 ✨ Complete native GitHub queue CI and policy integration same files .github/workflows/v2-ci.yml
#15859 ✨ feature: add abandoned counts to contributor leaderboards same files src/pkg/dashboard/contribute_landing.go
#15865 ✨ feature: carry abandoned counts through the hub leaderboard same files src/pkg/hub/server.go

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 30, 2026
@clubanderson

Copy link
Copy Markdown
Member Author

Expanded first-class MLX acceptance delivered

Commit 057f74e adds a dedicated Apple MLX engine choice/tile on the chosen hive's /contribute page. It honestly maps to the actual Pi coding runner, not a fictional MLX CLI. Copyable setup commands cover an isolated Python environment, explicit model verification, Pi registration and the actual launcher.

Canonical interface from the source checkout:

# Native Apple Silicon Mac, already-downloaded tool-capable model, separate terminal:
HIVE_MLX_PYTHON="$PWD/.venv-mlx/bin/python" just contribute-mlx-serve /Users/YOU/models/tool-coder
# Explicit opt-in to two bounded streamed tool-call/result verification turns:
just contribute-mlx-setup /Users/YOU/models/tool-coder --verify-tools
export AGENT_MODEL=mlx//Users/YOU/models/tool-coder
export HIVE_HUB=https://YOUR-CHOSEN-HIVE
just contribute-check pi
just contribute-setup pi
just contribute-mlx

The serve recipe is foreground, loopback-only and forces Hugging Face offline. No packages/weights are installed/downloaded or models started automatically. Docker Desktop 4.34+ host networking must be enabled explicitly; MLX-LM stays on the Mac and Pi/tools stay inside the relay container. Podman machine and Kubernetes are refused for this route. Explicit MLX model selection survives saved hosted-provider profiles without changing generic Pi precedence (review finding fixed with a focused shell-seam regression).

The public homepage now has a distinct Local AI inference / Apple MLX integration group, linking to the real hub /contribute#apple-mlx instructions. The hub's contribution directory also explains the exact just workflow; the selected hive provides the configurable engine picker. Integration catalog, backend/inference guides, helper index, RAM/platform/troubleshooting docs and changelog are aligned. Apple is not represented as sign-in or endorsement.

Regression additions exercise actual page command-generation logic, unsupported OS/mode/runtime/model inputs, shell quoting, real recipe delegation/config precedence, mocked offline server argv, rendered onboarding and homepage grouping. Repository rules prohibit local test/build suites; CI remains the sole verdict. Live Apple GPU inference and Docker Desktop host connectivity remain unverified. Nothing was deployed, merged, downloaded or launched on this laptop.

@clubanderson clubanderson changed the title ✨ Add optional Apple MLX inference to ClankeR through Pi ✨ Add Apple MLX local inference and first-class ClankeR onboarding Oct 30, 2026
Signed-off-by: Andy Anderson <andy@clubanderson.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:Sign-off survives the squash

@hivecommons-hive

Copy link
Copy Markdown
Contributor
c9a108c

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @clubanderson, head c9a108c3430e) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 3 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/v2-ci.yml
    • Justfile
    • src/Dockerfile.contributor

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • coverage

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (correctness) — read at head c9a108c; applied the diff to merge-base 79e0ba6 and ran node --test bin/mlx-backend.test.js (14 pass), node bin/contributor-relay.test.js (736 pass), node --test src/pkg/dashboard/contribute_mlx.test.js (3 pass). Cross-checked the probe against MLX-LM v0.32.2 server.py (indexed streaming tool_calls, finish_reason: "tool_calls", {mlx_lm}-{mlx}-… fingerprint) and the extension against pi-ai 1.4.0 compat (openAICompletionsApi, PI_AI_VERSION exported). No blocking findings.

Low — three tests are accidentally nested inside another test (bin/mlx-backend.test.js:239-291). 'explicit serve recipe …', 'MLX just launcher …' and 'MLX launcher preserves explicit model …' are declared between http.createServer(...) and await new Promise(resolve => server.listen(...)) inside 'Pi inference transport rejects redirects after successful setup'. node:test registers them as subtests of the redirect test; they pass today only because the parent happens to await long enough (node:test cancels unfinished subtests when the parent finishes). Move the three test(...) blocks to top level (after the closing }); of the redirect test) so they are independent and can't be cancelled by the parent's timing.

Not verified here (author also states it): live Pi 1.4.0 behaviour with a models.json provider whose api is the custom hive-mlx id before mlx-pi-extension.js registers the override.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style review (head c9a108c) — one maintainability finding, non-blocking.

Three unrelated tests are nested inside the body of another test — bin/mlx-backend.test.js:228-293. The test 'Pi inference transport rejects redirects after successful setup' creates its HTTP server at L229, then L234-287 define three top-level-looking test(...) calls (explicit serve recipe…, MLX just launcher…, MLX launcher preserves explicit model…) before the parent resumes at L288 with server.listen and the actual redirect assertion. Node's runner does run them (as subtests of the redirect test — verified with node --test, 14 pass), but the report groups serve/Justfile coverage under a transport test, the parent's setup is split across 60 lines, and anyone trimming the redirect test will delete the Justfile seam with it. Every other test in the file is flat; this looks like a misplaced paste.

Fix: move L234-287 out of the parent, e.g. to just before L228 (no code inside the three blocks needs to change — they only use their own t):

 test('Pi inference transport rejects redirects after successful setup', async t => {
   const server = http.createServer((req, res) => {
     res.writeHead(307, { Location: 'https://api.openai.com/v1/chat/completions' });
     res.end();
   });
-
-  test('explicit serve recipe uses native Python, loopback and offline weights without changing RAM settings', t => {
-    ...
-  });
-
-  test('MLX just launcher remains a Pi wrapper with explicit model/runtime refusal', () => {
-    ...
-  });
-
-  test('MLX launcher preserves explicit model across both saved-profile loads without changing generic Pi defaults', t => {
-    ...
-  });
   await new Promise(resolve => server.listen(0, '127.0.0.1', resolve));
   t.after(() => new Promise(resolve => server.close(resolve)));
   const endpoint = `http://127.0.0.1:${server.address().port}/v1`;
   const guarded = extension.localFetch(endpoint);
   await assert.rejects(guarded(`${endpoint}/chat/completions`, { method: 'POST', body: 'private task' }));
 });
+
+test('explicit serve recipe uses native Python, loopback and offline weights without changing RAM settings', t => { /* unchanged body */ });
+test('MLX just launcher remains a Pi wrapper with explicit model/runtime refusal', () => { /* unchanged body */ });
+test('MLX launcher preserves explicit model across both saved-profile loads without changing generic Pi defaults', t => { /* unchanged body */ });

Otherwise the new code follows repo idioms: marker-block extraction in src/pkg/dashboard/contribute_mlx.test.js:9-12 matches fleet_cost_rotor.test.js:19; SETUP_BACKEND flavor mapping (contribute_landing.go:1791) reuses the litellm pattern; the .test.js is picked up by the existing node --test src/pkg/dashboard/*.test.js CI step.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (intent-alignment, head c9a108c) — the diff satisfies #15839: Apple Silicon/macOS 14+/native Python ≥3.10 gating (bin/mlx-backend.js:37-54), opt-in streaming tool-call verification that gates readiness via a digest-checked receipt (bin/mlx-backend.js:148-173, :220-231), loopback-only endpoint with no hosted fallback (:23-33, bin/mlx-pi-extension.js:6-15), reuse of Pi custom models and the existing ~/.pi staging (bin/pi-backend.js:160-180 keeps providers.mlx; receipt copied with the dir), and Mac-host vs container errors (Justfile contribute-hive pi) case, bin/contributor-agent.sh:621-623). Both new Node suites are wired into CI (.github/workflows/v2-ci.yml:886 glob, :908).

One advisory, non-blocking:

  • Public homepage expansion is outside #15839's scope — src/pkg/hub/static/index.html:813-819 adds a new "Local AI inference" integration group (and restructures the band to 2 columns, :319) plus src/docs/integrations.md. The issue asks for contributor-relay inference; marketing-site placement is a product/branding call that could land separately if maintainers prefer. Not a defect; fine to keep if intended.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson

Copy link
Copy Markdown
Member Author

CI follow-through: concrete failure fixed, awaiting new-head verdict

Head c9a108c3430e1ac6ed233a08c6fcaf662734050c failed test (rest 3/4) because our new MLX help block increased dashboard styling debt:

  • Failed shard log: TestStyleRatchet reported contributor landing 87 style= attributes vs baseline 86, and 198 raw font-size declarations vs 197 (all three attempts failed identically).
  • Coverage log: explicitly refused success because rest=failure; this was a downstream shard dependency, not an independently measured coverage deficit.

The new fix replaces that inline declaration with a tokenized .mlx-note CSS class and adds a focused rendered-page regression. No ratchet/coverage/test thresholds, trust/sentinel policy, labels, or concurrent workflow files were changed. This is our regression, not a claimed baseline problem. Citation guard passed; no citation fixer was run.

The public Apple MLX integration card and /contribute just instructions remain wired. I am monitoring the new head's actual required checks; a push is not a green verdict. Live GPU inference and Docker Desktop connectivity remain explicitly unverified; no local model, container workload, build, or Go suite was launched.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci (scanner): failing on c9a108c: test (rest 3/4) (so coverage/test) — TestStyleRatchet in pkg/dashboard/webstatic/style_ratchet_test.go:88: contributor landing has 87 style= attrs (baseline 86) and 198 raw font-size decls (baseline 197); also operator static/index.html is 1425, below baseline 1427. Suggested fix: remove one inline style and one raw font-size from the contributor landing (use tokens), and lower styleRatchetBaselines["operator static/index.html"].inlineStyles to 1425. The hive does not push to this branch; once green the sweep merges it.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson

Copy link
Copy Markdown
Member Author

Actual repaired-head CI verdict

Exact head: 976f640a166043fdaaa9cc0c322ac378d6da41df.

All 12 required checks now report SUCCESS, including the underlying regression shard, aggregate tests, measured coverage, build-and-test, lint, security checks, changelog/citation guard and DCO:

The failure on the previous head was our added inline styling, fixed with tokenized CSS rather than weakened baselines. No blanket retries, base refresh, trust/sentinel changes, labels, or concurrent workflow edits were used.

One non-required ARM image build remains in progress: build (linux/arm64). I am not describing that unfinished check as green.

The public Apple MLX integration card and /contribute just workflow remain present. Mock/process/HTTP/browser-command tests and CI builds are not live hardware proof: Apple GPU inference and Docker Desktop host connectivity remain unverified. No model or Docker workload was run on the owner's Mac; no merge or deployment was performed.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 050-review-pending: check-pending

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 050-review-pending: review-gate:no-review-bundle

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (docs-currency) — one low, non-blocking note.

Two workflow summaries skip the required just contribute-setup pi step. bin/README.md:91 ("Use just contribute-mlx-serve, just contribute-mlx-setup <model> --verify-tools, then just contribute-mlx") and docs/inference-backends.md:15-17 list the three MLX recipes as the whole workflow, but contribute-mlx delegates to contribute-hive, which exits with "Not set up yet. Run: just contribute-setup " when contributor.env is absent (Justfile:975-977). The canonical sequence in src/docs/contributor-relay.md, docs/backend-setup.md:15, the hub landing (src/pkg/hub/server.go:4838) and the generated UI commands (src/pkg/dashboard/contribute_landing.go:1818) all include it; only these two summaries drifted.

| `mlx-backend.js` | Optional local inference | Apple Silicon runtime/config checks, explicit tool-call verification and offline loopback server launch for Pi's `mlx` provider. Use `just contribute-mlx-serve`, `just contribute-mlx-setup <model> --verify-tools`, `just contribute-setup pi`, then `just contribute-mlx`; see [MLX setup](../src/docs/contributor-relay.md#apple-mlx-local-inference). No automatic installation or model downloads. |

Verified against head 9a598f3: Pi pin 1.4.0 (src/Dockerfile.contributor:487), 4‑GiB container cap (Justfile:33), HIVE_MLX_* variables documented in src/docs/env-vars.md:501-504, and the /v1/models resolved-path / Hub-ID listing and <mlx-lm>-<mlx>- fingerprint claims match MLX‑LM v0.32.2 server.py (handle_models_request, get_system_fingerprint). CI runs both new Node suites (v2-ci.yml:886,908).

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style review (head 9a598f3) — approve; advisory items only, none blocking #15839.

  1. src/pkg/dashboard/contribute_mlx_test.go:29 — the inline-style assertion sits inside the for _, want := range loop, so a regression prints the same t.Error 14 times. Hoist it out:
 	} {
 		if !strings.Contains(body, want) {
 			t.Errorf("Apple MLX onboarding missing %q", want)
 		}
-		if strings.Contains(body, `<div id="pi-mlx-note" style=`) {
-			t.Error("MLX help must use tokenized CSS rather than add inline styling debt")
-		}
 	}
+	if strings.Contains(body, `<div id="pi-mlx-note" style=`) {
+		t.Error("MLX help must use tokenized CSS rather than add inline styling debt")
+	}
 }
  1. bin/mlx-backend.js:179-185 — agentDir/readJSON duplicate piAgentDir/readJSON in bin/pi-backend.js:76-80 (with a subtle drift: env.HOME vs env.HOME || ''). Export the Pi helpers and import them so PI_CODING_AGENT_DIR resolution has one owner:
-const { parsePiModelSelection } = require('./pi-backend.js');
+const { parsePiModelSelection, piAgentDir: agentDir, readJSON } = require('./pi-backend.js');

(and add piAgentDir, readJSON to module.exports in pi-backend.js:197.)

  1. Pinned version literals are copy-pasted — pi-coding-agent@1.4.0 appears at contribute_landing.go:1621 and :1803, mlx-lm==0.32.2 at :1805, and the macOS 14 / Python 3.10 / Node 22.19 / Pi 1.4.0 / Docker Desktop 4.34 prerequisite sentence is restated at contribute_landing.go:1689, :1800, src/pkg/hub/server.go:4828, static/index.html, and three docs. src/Dockerfile.contributor:487 already owns PI_CODING_AGENT_VERSION=1.4.0. At minimum hoist MLX_PI_VERSION/MLX_LM_VERSION constants above mlxCommands (contribute_landing.go:1796) and build the <option data-host-install> from them, so the next pin bump cannot leave the picker and generator disagreeing.

  2. bin/contributor-relay.js:3228, :3927, :9913 — checkMlxRuntime (a synchronous execFileSync child with a 20 s timeout, mlx-backend.js:282) is invoked at three sites. The startup gate at :9913 already fails closed; the two inner calls re-run the subprocess on every buildLaunchCommand/buildHeadlessArgv. If re-checking per task is intentional, a single ensureMlxReady() helper with a one-line comment stating that intent would make the triple call read as design rather than duplication.

  3. src/pkg/hub/contribute_landing_test.go:43 — strings.SplitN(body, "...Sign-in</p>", 2)[1] panics with an index error if the label is renamed, unlike the start < 0 → t.Fatal guard used four lines earlier for the inference group. Use the same guard.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 5355cbd into v5 Oct 30, 2026
79 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/clanker-mlx branch October 30, 2026 21:46
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#158429a598f3` sha256:67e84e39c97267790bf8ac586bfb38ba8e2378c5d4e0a3243c489b4127ef3c65 — download from the dashboard or `hivectl review evidence #15842`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Add optional Apple MLX inference to the ClankeR contributor relay

1 participant