Skip to content

✨ feature: carry abandoned counts through the hub leaderboard - #15865

Closed
mendezr wants to merge 1 commit into
hivecommons:v5from
mendezr:fix/15799-abandoned-heartbeat
Closed

mendezr wants to merge 1 commit into
hivecommons:v5from
mendezr:fix/15799-abandoned-heartbeat

Conversation

@mendezr

@mendezr mendezr commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #15799

  • Carry abandoned in full spoke heartbeats and lightweight task-status pushes using a shared dashboard-to-spoke row conversion.
  • Sum abandoned counts per GitHub username across public spokes, explicitly emit zero for legacy spokes, and retain abandoned-only contributors. Existing counts and ranking are unchanged.
  • Update the hub API reference and OpenAPI schema.

Dependency / integration

Builds on #15796 (open PR #15859), with core accounting in #15802. This PR includes only the identical prerequisite dashboard.LeaderboardEntry.Abandoned field so it builds independently on v5. Retain one field when integrating #15859; that PR owns populating it from contributor profiles. Until those prerequisites land, spokes report zero for existing profiles. No adoption accounting or leaderboard UI changes are included here.

Validation

  • Added regression tests for dashboard-to-spoke conversion and heartbeat/task-status serialization (nonzero and explicit zero).
  • Added hub merge and endpoint JSON tests covering multiple spokes, a legacy spoke omitting the field, abandoned-only contributors, and existing visibility exclusions.
  • gofmt -l on changed Go files: clean.
  • Tests not run locally per AGENTS.md; CI is the test verdict.

— hive: backend=pi model=openai-codex/gpt-6.1-sol


🐝 Hive Agent: contributor | SHA: 315d07a1a

Share heartbeat and task-status row conversion, merge abandoned counts across public spokes, and document the additive wire field. Include the prerequisite dashboard row field shared with hivecommons#15859; profile population remains in that PR.

Hive-Run: hivecommons#15799
Hive-Plan: 15799-heartbeat-and-hub-leaderboard
Hive-Spec: issue-15799#acceptance
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15885 ✨ Add integration-aware orchestration above preparation and native queues same files src/cmd/hive/main.go
#15859 ✨ feature: add abandoned counts to contributor leaderboards same files src/pkg/dashboard/contribute_leaderboard.go

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 050-review-pending: contributor-lane:no-verdict

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree at 315d07a. This looks correct to me.

  • leaderboardForSpoke (cmd/hive/leaderboard_heartbeat.go:10) is a straight extraction of the two identical loops previously at main.go:982 and :5622, plus the one new field; both callers now share it, so the full heartbeat and the task-status push cannot drift apart on wire shape again.
  • Hub merge sums Abandoned per username (pkg/hub/server.go:4455) and the empty-row filter at :4469 now also keeps abandoned-only contributors. Ordering code is untouched.
  • go build ./cmd/hive ./pkg/hub/... clean at this head; all checks green, only tide pending.

Integration: dashboard.LeaderboardEntry.Abandoned here is the same one-line field #15859 adds, so whichever lands second resolves to one declaration. Landing order for the stack should be #15802 → #15859 → this one; none of the four are duplicates of each other (diffed all of them).

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15748:5/6:0/0:main.go,contribute_leaderboard.go,contributors.js,tracker-filter-render.js,+2

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merge-sweep: CI is green but the merge relay refuses this fork PR because the branch is behind v5 (contributor-lane policy: behind, author tier trusted). @mendezr — please update the branch (merge v5 in or rebase) and push; the sweep will merge it on the next green run. Nothing else is blocking.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @315d07a, 58/58 checks green, DCO yes, soak 10m0s elapsed. Blocked only by role/untrusted (no trusted-author role).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@mendezr this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch is behind the base and Hive cannot update it; enable "allow edits by maintainers" or rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Superseded by hive: re-authored as #15894 with the same commits and sign-off because the author's clanker is offline. This PR is closed; if #15894 fails, hive reopens it.

@hivecommons-hive hivecommons-hive Bot added the hive/superseded Closed by Hive: a different merged PR already landed this change label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] Carry abandoned counts in the spoke heartbeat leaderboard and the hub's merged /api/hub/leaderboard

1 participant