Repository navigation
Conversation
Share heartbeat and task-status row conversion, merge abandoned counts across public spokes, and document the additive wire field. Include the prerequisite dashboard row field shared with hivecommons#15859; profile population remains in that PR. Hive-Run: hivecommons#15799 Hive-Plan: 15799-heartbeat-and-hub-leaderboard Hive-Spec: issue-15799#acceptance Signed-off-by: mendezr <mendezr@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
stage 080-awaiting-merge-admission → 050-review-pending: contributor-lane:no-verdict |
There was a problem hiding this comment.
Read the tree at 315d07a. This looks correct to me.
leaderboardForSpoke(cmd/hive/leaderboard_heartbeat.go:10) is a straight extraction of the two identical loops previously atmain.go:982and:5622, plus the one new field; both callers now share it, so the full heartbeat and the task-status push cannot drift apart on wire shape again.- Hub merge sums
Abandonedper username (pkg/hub/server.go:4455) and the empty-row filter at:4469now also keeps abandoned-only contributors. Ordering code is untouched. go build ./cmd/hive ./pkg/hub/...clean at this head; all checks green, onlytidepending.
Integration: dashboard.LeaderboardEntry.Abandoned here is the same one-line field #15859 adds, so whichever lands second resolves to one declaration. Landing order for the stack should be #15802 → #15859 → this one; none of the four are duplicates of each other (diffed all of them).
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15748:5/6:0/0:main.go,contribute_leaderboard.go,contributors.js,tracker-filter-render.js,+2 |
|
merge-sweep: CI is green but the merge relay refuses this fork PR because the branch is behind 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Ready for a human merge: verdict approved @315d07a, 58/58 checks green, DCO yes, soak 10m0s elapsed. Blocked only by The hive never approves on your behalf: |
|
@mendezr this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
Summary
Fixes #15799
abandonedin full spoke heartbeats and lightweight task-status pushes using a shared dashboard-to-spoke row conversion.Dependency / integration
Builds on #15796 (open PR #15859), with core accounting in #15802. This PR includes only the identical prerequisite
dashboard.LeaderboardEntry.Abandonedfield so it builds independently on v5. Retain one field when integrating #15859; that PR owns populating it from contributor profiles. Until those prerequisites land, spokes report zero for existing profiles. No adoption accounting or leaderboard UI changes are included here.Validation
gofmt -lon changed Go files: clean.— hive: backend=pi model=openai-codex/gpt-6.1-sol
🐝 Hive Agent:
contributor| SHA:315d07a1a