Repository navigation
🐛 Every hive-filed issue title starts with its [agent] tag - #15778
Conversation
One function, issueshape.AgentIssueTitle, is now the choke point every hive issue-creation path runs its title through: CreateIssue (review backlog, dedupe, selfreport, dashboard, convergence via the forge seam), the hotspot filer (tagged [ci-maintainer] to match its agent/ci-maintainer label), the advisory and recommendations living documents and the upstream-watch filer (raw Issues.Create calls that bypassed the helper), and the egress proxy for an agent's gh issue create. The tag always comes first, ahead of any emoji; a title another hive filer already tagged is kept; a non-slug bracket ([ACMM L0]) is subject, not filer. Advisory and recommendations lookups compare with the tag ignored so a hive upgrade never opens a second standing issue. A guard test fails any non-test Go file that calls Issues.Create without running its title through AgentIssueTitle, and a table test checks each producer's title. The Activity Monitor draws the leading tag as a chip ahead of the title instead of repeating it. Existing issue titles are left as they are. Closes #15777 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
…ss; ACMM gap title leads with [dashboard] Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Read AgentIssueTitle and every caller it replaces; the logic is sound and no TitleFor reference is left behind. One verified gap worth knowing about, not a blocker.
Low — src/crux/issueshape/issueshape.go:112,135-137: a lowercase subject bracket still suppresses the agent tag. IsFilerTag is a shape test (^[a-z0-9][a-z0-9_.-]*$), and the case lead == "" branch returns the title unchanged whenever the leading bracket passes it. So [ci] flaky test on arm64 or [docs] broken link filed by the scanner through the proxy comes out untagged, while [Tests] … and [ACMM L0] … now correctly get [scanner] in front. The old regex had the same hole for every bracket, so this PR narrows it rather than widening it — but the title's claim ("every hive-filed issue title starts with its [agent] tag") is still not strictly true at the crux boundary, where no agent roster is available to distinguish [ci] from [scanner]. If that matters, the proxy side knows lane and could accept only tag == lane or a tag it has seen as a lane; otherwise a one-line note on IsFilerTag saying this is shape-only would stop the next reader assuming it is a roster check.
What I checked holds:
AgentPrefixreturns "" when an emoji precedes the bracket (🐛 [reviewer] x), soStripAgentPrefixleaves such titles whole; that is fine becauseAgentIssueTitlenormalises to[reviewer] 🐛 xon the way out, and the test atissueshape_test.go:155pins it.- Dedupe keys are unchanged for pre-existing issues:
SameTitle("[ACMM L0] …", "[dashboard] [ACMM L0] …")is covered (issueshape_test.go:161), andisAdvisoryTitle(src/pkg/github/advisory.go:33) means the governor-tagged advisory matches an untagged one filed before this change, so no repo gets a second advisory. TestEveryIssueCreatePathTagsTheTitle(src/pkg/issueshape/choke_point_test.go:25) is the right ratchet for the "every path" claim — a rawIssues.Createwithout the tag fails in CI, not in production.
CI on this head was still running when I read it.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
…ode into the split files tracker-row.js conflicted: v5 (#15801 push progress, #15778 title tag chip) edited code this PR moved out. The pushedBack detour guard stays in tracker-row.js; the Push tooltip line and push chip go to tracker-row-strip.js; push: lp.push fields, the pushed lineage suffix and stageTrackerSplitTitleTag / stageTrackerTitleHtml go to tracker-row-layout.js. index.html regenerated (unchanged). Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Closes #15777
What
Owner rule: "agents that need to open issues need to use [agent name] in the description. I see reviewer is not following this format." #15673 introduced the
[<agent>]title tag for some producers; this makes it hold for every hive issue-creation path, with one function and a guard test so no producer can drift again.issueshape.AgentIssueTitle(agent, title)replacesTitleFor. Idempotent; normalises a leading tag for the same agent ([Reviewer]x→[reviewer] x); keeps a tag another hive filer already added ([selfreport] …relayed by the governor); treats a non-slug bracket ([ACMM L0],[Tests]) as subject and still tags it; always puts the tag first, ahead of any leading emoji (🐛 [reviewer] x→[reviewer] 🐛 x).agent/<lane>/origin/<source>label through the existing label-ensure path with the 🐛 github: keep label descriptions within GitHub's 100-char cap #15685 clamp):CreateIssue— review backlog[reviewer], dedupe[dedupe], self-report[selfreport](+origin/selfreport), dashboard/ACMM[dashboard], convergence[convergence]via the forge seam, any agent request through the watcher[ci-maintainer], matching itsagent/ci-maintainerlabel (was[governor])[governor] 🐝 Hive Advisory Reportand recommendations[governor] 🐝 Hive recommendations — …— both were rawIssues.Createcalls that bypassed the helper; their lookups now compare with the tag ignored (isAdvisoryTitle/SameTitle) so an upgrade never opens a second standing issue[governor]gh issue createpkg/issueshape/choke_point_test.gowalkssrc/and fails any non-test Go file callingIssues.Create(withoutissueshape.AgentIssueTitle(; a table test asserts each producer's title matches^\[[a-z0-9-]+\]and re-tagging is a no-op. Helper table tests cover idempotence, duplicate-tag stripping, emoji ordering and the non-filer bracket.ham-title-tagchip ahead of the title; the title text no longer repeats it; the full title stays in the tooltip. Non-slug brackets stay in the title. Covered inTestStageTrackerRows.changelog.d/fixed-agent-issue-title-prefix.md.Not done on purpose
SameTitle) ignores the tag, so open untagged items still match their tagged successors; no bulk API retitle.agent/reviewerissues filed today after 🐛 issues the hive files carry the filing agent in the title #15673 merged (05:54Z) came from a hive still running the pre-🐛 issues the hive files carry the filing agent in the title #15673 build; the review-backlog path was already tagging in code. This PR closes the remaining code gaps (advisory, recommendations, upstream-watch raw creates; hotspot tag ≠ label; emoji-before-tag; no guard).Tests
go test ./pkg/github/ ./pkg/dashboard/ ./pkg/issueshape/ ./pkg/hotspot/ ./pkg/upstreamwatch/ ./pkg/gfi/ ./pkg/fleetreport/ ./pkg/convergence/... ./pkg/forge/... ./crux/... ./cmd/hive/+go vet+make dashboard-gen-check. No newtime.Sleep.