Skip to content

✨ Activity Monitor settings: configurable toast durations and pre-merge soak - #15824

Merged
clubanderson merged 3 commits into
v5from
feat/tracker-settings-toast-soak
Oct 30, 2026
Merged

clubanderson merged 3 commits into
v5from
feat/tracker-settings-toast-soak

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

Adds a Toasts & timing section to the Activity Monitor (stage tracker) ⚙ settings modal:

  • Info toast (s) / Error toast (s) — dashboard.stage_tracker.toast_info_s / toast_error_s (defaults 15 / 30, range 3–120). Saved per hive via PUT /api/config/dashboard (stage_tracker block, 0 = reset) through the existing dashboard config overlay, served to every viewer in the /api/stage-tracker payload settings block (tracker cache invalidated on save). localStorage is used only as a fallback when the write is refused (e.g. viewer role). Applies live to result/waiting toasts and the merge banner (banner = 2× info, so default stays 30 s). Error toasts now auto-close after the error duration instead of sticking forever.
  • Pre-merge soak (minutes) — auto_merge.contributor_lane.soak_minutes via the existing PUT /api/config/auto-merge. Hint: the lane reads the knob on each pass, so a running soak follows the new window.

STAGE_TRACKER_MERGING_HOLD_MS is left untouched for the in-flight merged_hold_s PR.

Tests

  • Go: TestStageTrackerToastKnobs, TestDashboardSettingsAPIStageTrackerToasts (overlay write, validation, reset, payload block)
  • Node: TestStageTrackerTimingSettingsNode (modal fields → showToast durations, PUT bodies, fallback)
  • Updated pinned tests (row actions, toast countdown bar, cues, repo grouping); index.html regenerated; openapi.json + docs (operator-reference, hive-merge) updated; changelog.d fragment added.

Closes #15813

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15834 ✨ stage tracker: PR sub-row names the other issues it also closes same files src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#15787 🐛 Run the reconcile pass when wakes outpace the eval interval; age unblocked rows from the lift same files src/pkg/dashboard/stage_tracker_build.go
#15748 🐛 [reviewer] park PRs at 085 Needs decision when the fixer exhausted its attempts same files src/docs/hive-merge.md
src/pkg/dashboard/stage_tracker_build.go
#15819 🌱 refactor: split src/pkg/github/automerge/automerge_sweep.go into 4 files same files changelog.d/added-15813-tracker-toast-soak-settings.md
dashboard/openapi.json
src/docs/hive-merge.md
src/docs/operator-reference.md
src/pkg/config/config.go
src/pkg/config/stage_tracker_toast_test.go
src/pkg/dashboard/api_dashboard_config.go
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/stage_tracker_build.go
src/pkg/dashboard/stage_tracker_cues_test.go
src/pkg/dashboard/stage_tracker_row_actions_test.go
src/pkg/dashboard/stage_tracker_settings.go
src/pkg/dashboard/stage_tracker_settings_test.go
src/pkg/dashboard/stage_tracker_timing_settings_test.go
src/pkg/dashboard/stage_tracker_waiting.test.js
src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static-src/js/tracker-actions.js
src/pkg/dashboard/static-src/js/tracker-merged.js
src/pkg/dashboard/static-src/js/tracker-sound.js
src/pkg/dashboard/static-src/js/tracker-waiting.js
src/pkg/dashboard/static/index.html
src/pkg/dashboard/toast_countdown_bar_test.go
#15731 📖 docs: split the operator reference same files src/docs/operator-reference.md
#15804 ✨ Show the upgrade animation for every roll (announce + SIGTERM fallback) same files dashboard/openapi.json
src/pkg/dashboard/static/index.html
#15817 🐛 activity monitor: 'merging now' lingers, silent merges, closed rows vanish CONFLICT src/docs/operator-reference.md
src/pkg/config/config.go
#15836 🐛 Control base-refresh churn without blocking ready successors same files src/docs/hive-merge.md
#15830 ✨ dashboard: pop out the Hive activity monitor into its own window and a full-screen toggle same files src/pkg/dashboard/static/index.html
#15831 🐛 Merge train seats only PRs green and reviewed on their current head; regressed members are ejected same files src/docs/hive-merge.md
src/pkg/dashboard/stage_tracker_build.go
src/pkg/dashboard/static/index.html
#15757 ✨ Auto-merge hive-authored superseding PRs without operator decision same files src/docs/hive-merge.md
src/docs/operator-reference.md
src/pkg/config/config.go
#15774 ✨ dashboard: onboarding and GitHub App errors point to the Getting Started guide same files src/docs/operator-reference.md
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • build-and-test

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 071-needs-author: required-check-failing:build-and-test

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • coverage

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 071-needs-author: required-check-failing:coverage

…ge soak

Adds a "Toasts & timing" section to the stage tracker settings modal:
info/error toast durations (dashboard.stage_tracker.toast_info_s /
toast_error_s, 3–120 s, persisted per hive via PUT /api/config/dashboard
and served in the /api/stage-tracker payload, localStorage fallback only
when the write is refused) and the contributor lane pre-merge soak
(auto_merge.contributor_lane.soak_minutes via PUT /api/config/auto-merge).
The merge banner follows 2× the info toast duration.

Closes #15813

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the feat/tracker-settings-toast-soak branch from a31c4cd to bac2b8c Compare October 30, 2026 17:16
@clubanderson
clubanderson merged commit f22ed8f into v5 Oct 30, 2026
77 of 78 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/tracker-settings-toast-soak branch October 30, 2026 17:36
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Activity Monitor settings: configurable toast durations and pre-merge soak

1 participant