Repository navigation
✨ Activity Monitor settings: configurable toast durations and pre-merge soak - #15824
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission → 071-needs-author: required-check-failing:build-and-test |
4dce379 to
a31c4cd
Compare
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission → 071-needs-author: required-check-failing:coverage |
…ge soak Adds a "Toasts & timing" section to the stage tracker settings modal: info/error toast durations (dashboard.stage_tracker.toast_info_s / toast_error_s, 3–120 s, persisted per hive via PUT /api/config/dashboard and served in the /api/stage-tracker payload, localStorage fallback only when the write is refused) and the contributor lane pre-merge soak (auto_merge.contributor_lane.soak_minutes via PUT /api/config/auto-merge). The merge banner follows 2× the info toast duration. Closes #15813 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
a31c4cd to
bac2b8c
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Summary
Adds a Toasts & timing section to the Activity Monitor (stage tracker) ⚙ settings modal:
dashboard.stage_tracker.toast_info_s/toast_error_s(defaults 15 / 30, range 3–120). Saved per hive viaPUT /api/config/dashboard(stage_trackerblock, 0 = reset) through the existing dashboard config overlay, served to every viewer in the/api/stage-trackerpayloadsettingsblock (tracker cache invalidated on save). localStorage is used only as a fallback when the write is refused (e.g. viewer role). Applies live to result/waiting toasts and the merge banner (banner = 2× info, so default stays 30 s). Error toasts now auto-close after the error duration instead of sticking forever.auto_merge.contributor_lane.soak_minutesvia the existingPUT /api/config/auto-merge. Hint: the lane reads the knob on each pass, so a running soak follows the new window.STAGE_TRACKER_MERGING_HOLD_MSis left untouched for the in-flightmerged_hold_sPR.Tests
TestStageTrackerToastKnobs,TestDashboardSettingsAPIStageTrackerToasts(overlay write, validation, reset, payload block)TestStageTrackerTimingSettingsNode(modal fields → showToast durations, PUT bodies, fallback)Closes #15813