Skip to content

✨ Stage tracker: show push progress on CI / Review rows - #15801

Merged
clubanderson merged 1 commit into
v5from
feat/waiting-on-push-progress
Oct 30, 2026
Merged

clubanderson merged 1 commit into
v5from
feat/waiting-on-push-progress

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Closes #15784

What

Push progress on every PR row in the activity monitor's CI / Review column. Chevron = stage only; the gray pill carries who/why/lineage and now the push.

  • Store (pkg/stagelabels): waiting_push_since, last_push_at, last_push_sha on the stage record. Store.NotePush books a head from the pull_request synchronize / push webhook re-read (notePushedSnapshots in applyWebhookItemSnapshots); NoteActivity books the head change the next enumerate sees as fallback. Entering 071/072 resets the wait; leaving the CI / Review column clears the push fields.
  • Dashboard (pkg/dashboard): push: {state, login, since, sha, url, next, stale} on items and linked_prs. While waiting the presence pill ends with the wait's age — waiting on 👤 @user to push · 38m, muted warning tone past dashboard.stage_tracker.waiting_push_stale_h (default 4). Once a push lands and CI / the re-review for that head still run: the chevron returns to the column's own word (CI / Review · …, the 👤 clears — the stage actor is the hive again), presence/rework/adoption pills give way to @user pushed abc1234 · 2m (commit link), adopted rows read adopted from @x's #N · pushed 2m ago, plain CI / Review rows get pushed abc1234 · 2m, and the hive line says push seen 2m ago → CI/re-review queued (note_changed_at = push time, so it surfaces as a new Hive line). Hover gets a Push: line.
  • Knob: dashboard.stage_tracker.waiting_push_stale_h (config accessor + settings parity), documented in operator-reference.md and webhooks.md.

Tests

  • Go: TestStoreNotePushWebhook, TestStoreNotePushEnumerateFallback (store), TestStageTrackerPushFor, TestStageTrackerPushPayload (webhook path end-to-end, presence/rework/adoption cleared, actor flips to hive), TestStageTrackerWaitingPushStaleKnob, node harnesses TestStageTrackerPushJS (pill / lineage / tip text) and TestStageTrackerPushChevronJS (chevron word before/after the push).
  • go test ./pkg/dashboard/ ./pkg/stagelabels/ ./pkg/config/ ./pkg/dashboard/webstatic/ and node --test pkg/dashboard/*.test.js pass; index.html regenerated.

Stage records keep waiting_push_since / last_push_at / last_push_sha,
booked from the pull_request synchronize / push webhook re-read with the
enumerate head change as fallback. The chevron stays the stage (a pushed
071/072 row returns to the column's own word, the person glyph clears);
the gray pill carries the push — the wait's age while waiting (muted
warning tone past dashboard.stage_tracker.waiting_push_stale_h, default
4), "@user pushed abc1234 · 2m" linking to the commit once it lands, the
lineage chip's "· pushed 2m ago" on adopted rows — and the hive line
reads "push seen 2m ago → CI/re-review queued".

Closes #15784

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15757 ✨ Auto-merge hive-authored superseding PRs without operator decision same files src/docs/operator-reference.md
src/pkg/config/config.go
#15748 🐛 [reviewer] park PRs at 085 Needs decision when the fixer exhausted its attempts same files src/pkg/dashboard/stage_tracker_build.go
#15800 ✨ feat: stage tracker shows push progress on CI / Review rows CONFLICT src/pkg/dashboard/stage_tracker_push.go
src/pkg/dashboard/stage_tracker_push_test.go
src/pkg/dashboard/webhook_tracker_refresh.go
src/pkg/stagelabels/store.go
#15783 🐛 stage tracker: Let hive decide shows it is working, covered issues drop the PR's chip, 👤 says why same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html
#15793 🐛 stage tracker: 'Let hive decide' shows it is working and answers faster same files src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/stage_tracker_build.go
src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html
#15731 📖 docs: split the operator reference CONFLICT src/docs/operator-reference.md
#15787 🐛 Run the reconcile pass when wakes outpace the eval interval; age unblocked rows from the lift same files src/pkg/dashboard/stage_tracker_build.go
src/pkg/stagelabels/store.go
#15771 🌱 refactor: split tracker row source same files src/pkg/dashboard/static-src/js/tracker-row.js
#15774 ✨ dashboard: onboarding and GitHub App errors point to the Getting Started guide same files src/docs/operator-reference.md
src/pkg/dashboard/static/index.html

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

hivecommons-hive Bot added a commit that referenced this pull request Oct 30, 2026
Carry #15801's stage-tracker push-progress text and the
dashboard.stage_tracker.waiting_push_stale_h config line into
operator-reference/sweeps-and-operations.md and
operator-reference/runtime-and-quota.md; operator-reference.md stays the stub.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Oct 30, 2026
…ode into the split files

tracker-row.js conflicted: v5 (#15801 push progress, #15778 title tag chip)
edited code this PR moved out. The pushedBack detour guard stays in
tracker-row.js; the Push tooltip line and push chip go to tracker-row-strip.js;
push: lp.push fields, the pushed lineage suffix and stageTrackerSplitTitleTag /
stageTrackerTitleHtml go to tracker-row-layout.js. index.html regenerated
(unchanged).

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Oct 30, 2026
* ✨ stage tracker: push detail on adopted and CI/Review rows

The adopted suffix and plain-row pill landed with #15801; the
pill still showed after the head moved past the pushed commit. Drop it then.

Closes #15797

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* 🐛 stage tracker: a pushed row keeps its pill while the list shows the head pushed over

The on-head check from the previous commit dropped the push whenever the
listed head differed from the pushed sha; the webhook re-read books the push
ahead of the enumerate, so the list still carries the pre-push head then.
Treat that head as on-head too; only a third head means the push moved on.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Stage tracker: show push progress on CI / Review rows

1 participant