Repository navigation
✨ Stage tracker: show push progress on CI / Review rows - #15801
Merged
Merged
Conversation
Stage records keep waiting_push_since / last_push_at / last_push_sha, booked from the pull_request synchronize / push webhook re-read with the enumerate head change as fallback. The chevron stays the stage (a pushed 071/072 row returns to the column's own word, the person glyph clears); the gray pill carries the push — the wait's age while waiting (muted warning tone past dashboard.stage_tracker.waiting_push_stale_h, default 4), "@user pushed abc1234 · 2m" linking to the commit once it lands, the lineage chip's "· pushed 2m ago" on adopted rows — and the hive line reads "push seen 2m ago → CI/re-review queued". Closes #15784 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
This was referenced Oct 30, 2026
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
hivecommons-hive Bot
added a commit
that referenced
this pull request
Oct 30, 2026
Carry #15801's stage-tracker push-progress text and the dashboard.stage_tracker.waiting_push_stale_h config line into operator-reference/sweeps-and-operations.md and operator-reference/runtime-and-quota.md; operator-reference.md stays the stub. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot
added a commit
that referenced
this pull request
Oct 30, 2026
…ode into the split files tracker-row.js conflicted: v5 (#15801 push progress, #15778 title tag chip) edited code this PR moved out. The pushedBack detour guard stays in tracker-row.js; the Push tooltip line and push chip go to tracker-row-strip.js; push: lp.push fields, the pushed lineage suffix and stageTrackerSplitTitleTag / stageTrackerTitleHtml go to tracker-row-layout.js. index.html regenerated (unchanged). Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
This was referenced Oct 30, 2026
hivecommons-hive Bot
added a commit
that referenced
this pull request
Oct 30, 2026
* ✨ stage tracker: push detail on adopted and CI/Review rows The adopted suffix and plain-row pill landed with #15801; the pill still showed after the head moved past the pushed commit. Drop it then. Closes #15797 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * 🐛 stage tracker: a pushed row keeps its pill while the list shows the head pushed over The on-head check from the previous commit dropped the push whenever the listed head differed from the pushed sha; the webhook re-read books the push ahead of the enumerate, so the list still carries the pre-push head then. Treat that head as on-head too; only a third head means the push moved on. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15784
What
Push progress on every PR row in the activity monitor's CI / Review column. Chevron = stage only; the gray pill carries who/why/lineage and now the push.
pkg/stagelabels):waiting_push_since,last_push_at,last_push_shaon the stage record.Store.NotePushbooks a head from thepull_requestsynchronize /pushwebhook re-read (notePushedSnapshotsinapplyWebhookItemSnapshots);NoteActivitybooks the head change the next enumerate sees as fallback. Entering 071/072 resets the wait; leaving the CI / Review column clears the push fields.pkg/dashboard):push: {state, login, since, sha, url, next, stale}on items andlinked_prs. While waiting the presence pill ends with the wait's age —waiting on 👤 @user to push · 38m, muted warning tone pastdashboard.stage_tracker.waiting_push_stale_h(default4). Once a push lands and CI / the re-review for that head still run: the chevron returns to the column's own word (CI / Review · …, the 👤 clears — the stage actor is the hive again), presence/rework/adoption pills give way to@user pushed abc1234 · 2m(commit link), adopted rows readadopted from @x's #N · pushed 2m ago, plain CI / Review rows getpushed abc1234 · 2m, and the hive line sayspush seen 2m ago → CI/re-review queued(note_changed_at= push time, so it surfaces as a new Hive line). Hover gets aPush:line.dashboard.stage_tracker.waiting_push_stale_h(config accessor + settings parity), documented inoperator-reference.mdandwebhooks.md.Tests
TestStoreNotePushWebhook,TestStoreNotePushEnumerateFallback(store),TestStageTrackerPushFor,TestStageTrackerPushPayload(webhook path end-to-end, presence/rework/adoption cleared, actor flips to hive),TestStageTrackerWaitingPushStaleKnob, node harnessesTestStageTrackerPushJS(pill / lineage / tip text) andTestStageTrackerPushChevronJS(chevron word before/after the push).go test ./pkg/dashboard/ ./pkg/stagelabels/ ./pkg/config/ ./pkg/dashboard/webstatic/andnode --test pkg/dashboard/*.test.jspass;index.htmlregenerated.