Repository navigation
🐛 adoption: superseded PRs close promptly and read as one muted tracker line - #15591
Conversation
The write-back gate refused the close-first of #15526 (odttlnt's clanker PR, re-authored as #15574) with needs-opt-in-label: contributor_adopt requires a repo opt-in label on items the hive did not author. An agent's PR the hive has re-authored is one logical PR of the hive's own, so the gate now allows the adoption kind on an agent-authored item whose copy is on record (superseded-agent-pr). governor.labels.stage.adoption. close_superseded: on_adopt (default) | on_merge chooses when; a person's original keeps needing the label. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
A PR superseded by a hive adoption is no longer drawn as its own sub-row while its superseder is listed: the server marks it superseded_by (cleared when the copy dies, omitted for in-place adoptions) and the copy's adopted_from.state / lineage.from_state; the SPA folds it into the copy's 'adopted from' chip whose hover says closed, or open and closing when the copy merges. Docs, changelog, Go + Node tests and a fold ratchet. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
… on one muted line
Replaces the fold from the previous commit per owner feedback: the muted,
chevron-less sub-row under the issue stays; only the trailing note changes
to the short one-liner ("superseded · closed · hive adopted → #N" once the
original is closed), never wrapping — the title ellipsizes first — with
"re-authored with the same commits and sign-off" moved to the hover. A
closed original is listed in this muted form only while its superseder is
open and listed, and leaves when the superseder merges or closes.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission → 071-needs-author: required-check-failing:coverage |
… golden Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:build-and-test |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
stage 080-awaiting-merge-admission → 050-review-pending: check-pending |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15586
#15511 listed hive's adoption #15574 (Merge queued · 2nd) and, under it, the still-open original #15526 whose greyed note "· Adopted → #15574 · superseded (hive re-authored with sign-off)" wrapped to two lines; the close-first close of #15526 had been refused by the write-back gate with
needs-opt-in-label.Close policy. New
governor.labels.stage.adoption.close_superseded: on_adopt|on_merge(defaulton_adopt). A clanker- or hive-authored original (e.g. @odttlnt's clanker #15526, @Karibhou's clanker #15561) closes in the adopting pass by policy — the gate admits the close assuperseded-agent-prwithout thecontributor_adoptopt-in label once the copy carries its commits and sign-off, with the standard supersede comment. A human-authored original still needs the opt-in label to close on adopt; otherwise it closes when the copy merges (documented).Tracker (per owner's revised wording — the issue originally asked to hide the row). The muted, chevron-less sub-row under the issue stays. Its note is now the one-liner "superseded · hive adopted → #N" ("superseded · closed · hive adopted → #N" once closed); it never wraps — the PR title ellipsizes first — and "re-authored with the same commits and sign-off" moved to the hover. The tracker marks the original
superseded_by: N(cleared when the copy dies, omitted for in-place adoptions) and the copy'sadopted_from.state/lineage.from_state. A closed original is listed in this muted form only while its superseder is open and listed, and leaves the tracker when the superseder merges or closes.Before:
After:
Go + Node tests (
TestStageTrackerSuperseded*, decided-state Node suite, ratchet: the note CSS isnowrap, a closed original leaves with its copy), docs (hive-merge.md,dashboard-sections.md,operator-reference.md,labels-and-control-signals.md), changelog fragment.