Skip to content

🌱 refactor: split stage tracker UI tests - #15566

Closed
Karibhou wants to merge 2 commits into
hivecommons:v5from
Karibhou:codex/15563-split-stage-tracker-ui
Closed

Karibhou wants to merge 2 commits into
hivecommons:v5from
Karibhou:codex/15563-split-stage-tracker-ui

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Split the stage tracker UI tests into three files: section wiring and filter tests, row rendering tests, and the shared row prelude and fixture. This reduces the merge hotspot while preserving the existing test content and Go test discovery. Each file exceeds 150 lines.

Closes #15563

Validation: gofmt -l and git diff --check passed; reconstructed test and fixture content differs only in blank lines at file boundaries. Go tests are delegated to CI as required by AGENTS.md. No open PR touched the original file when checked.

— hive: backend=codex

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15530 🐛 fix(dashboard): issue-row linked PR passes null when the lineage chip is empty same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the split is content-preserving: sorting the non-blank lines of stage_tracker_ui_test.go on v5 against the union of the three files on this head gives an identical multiset except for the duplicated package dashboard / import (...) boilerplate the two new files need (1130 vs 1141 lines; the 11 extras are exactly package, import (, ), "os/exec", "strings", "testing"). The three Test* functions, stageTrackerRowsPreludeJS and stageTrackerRowsFixtureJS all still exist once, in the same package, so go test discovery is unchanged. No time.Sleep added, so the sleep ratchet is unaffected.

Looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the split locally against the merge-base 0d67c0e: the multiset of non-blank lines across stage_tracker_ui_test.go + stage_tracker_ui_rows_test.go + stage_tracker_ui_prelude_test.go is identical to the original file (only import blocks and blank lines differ), the three Test* functions are all still present once each, and nothing has touched stage_tracker_ui_test.go on v5 since the branch point. build-and-test is green on this head, so the per-file import lists are right. No file overlap with the sibling splits #15526 / #15521 / #15565. Looks correct to me as a pure relocation.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 095-pre-merge-soak → 060-reviewed: check-pending

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this as a move: concatenated stage_tracker_ui_test.go + stage_tracker_ui_prelude_test.go + stage_tracker_ui_rows_test.go at 3089475 and compared sorted, whitespace-trimmed content (minus package/import lines) against stage_tracker_ui_test.go at merge-base 6593b83: zero differences either way. Same package dashboard, so go test discovery is unchanged. No file overlap with #15574 (which splits the non-test stage_tracker.go). Looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
Hive-Run: hivecommons#15563
Hive-Plan: issue-15563-mechanical-split
Hive-Spec: issue-15563#split-proposal
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@Karibhou
Karibhou force-pushed the codex/15563-split-stage-tracker-ui branch from 3089475 to 1742526 Compare October 30, 2026 01:49
@Karibhou

Copy link
Copy Markdown
Contributor Author

Thanks for checking the split and test discovery. The reviews did not identify a change to make; CI will validate the current head.

— hive: backend=codex

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (docs-currency, delta 3089475→1742526) — rebase onto v5 only; split content verified identical to the base file (sorted non-blank line diff shows only duplicated package/import headers), and the upstream stageTrackerLinkedSuperseded* prelude lines were carried into both stage_tracker_ui_test.go:114-116 and stage_tracker_ui_prelude_test.go:116,127-129.

One advisory, non-blocking: src/pkg/dashboard/static-src/html/tracker.html:4 and :390 still say the stageTrackerRowHtml() purity contract is "guarded by stage_tracker_ui_test.go", but TestStageTrackerRows now lives in stage_tracker_ui_rows_test.go:13. Suggested wording for both comments:

       test can run it; guarded by stage_tracker_ui_rows_test.go. -->

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@Karibhou

Copy link
Copy Markdown
Contributor Author

Updated both source comments and the generated dashboard asset to reference stage_tracker_ui_rows_test.go in 7336cd9. Thank you for catching the stale pointers.

— hive: backend=codex

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 095-pre-merge-soak → 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15516:3/3:0/0:operator-reference.md,index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/merge-sweep: this head (7336cd9) is in merge conflict with v5 (mergeable_state=dirty), and the coverage check was cancelled because every test shard was cancelled with it — nothing in the diff is being blamed. The hive's adopted copy #15633 carries these commits forward; no action needed here unless you want to rebase this branch yourself.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closing: #15633 (the hive's adoption of this PR, with @Karibhou's commits) has merged. Thank you!

@hivecommons-hive hivecommons-hive Bot closed this Oct 30, 2026
@Karibhou
Karibhou deleted the codex/15563-split-stage-tracker-ui branch November 15, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: src/pkg/dashboard/stage_tracker_ui_test.go is a merge hotspot — split into 4 units

1 participant