Repository navigation
✨ dashboard: add ?kiosk=1 unattended display mode for the Activity Monitor - #15601
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…nitor Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Read the kiosk wiring against the built index.html at head e64ce4b. Looks correct to me.
- Specificity claim holds: the theme rule is
body #oc-topbar.oc-topbar{…display:grid!important}(src/pkg/dashboard/theme/theme.go:45, specificity 1-1-1); the kiosk rulehtml.kiosk body #oc-topbar.oc-topbaris 1-2-2, so with both!importantthe kioskdisplay:nonewins. #activity-monitor-section(index.html:7569) is a top-level[data-dashboard-section]with nodata-dashboard-sectionancestor, so the:not(#activity-monitor-section)rule cannot hide it via a parent. All other hidden ids/classes exist (#dash-notices:6882,.oc-sidebar-resize:7050,#oc-sidebar:7051,#oc-topbar:7157,#nps-survey-cardcreated at:61637).- The default
bodypadding reservescalc(var(--sidebar-w) + var(--sp-7))on the left (index.html:126);html.kiosk body { padding: var(--sp-5) !important }overrides it, so the monitor is not pushed right by a hidden sidebar. static-srcandstatic/index.htmlcarry identical hunks, andcss/kiosk.cssis inmanifest.txt.- The
initWelcomeDialog/initNPSSurveyearly returns are the first statement in each function, as the test pins.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Closing as superseded: #15595 (merged to v5 at aa1b5af) already ships |
|
stage 080-awaiting-merge-admission → 070-fixing: conflicting |
Streaming the Activity Monitor from a headless browser needs a chrome-free, dialog-free view.
?kiosk=1flags the page early in boot; a kiosk stylesheet (specific enough to beat the !important topbar rule in /api/theme.css) hides everything except the Activity Monitor, and the Welcome and NPS prompts skip auto-opening. Without the parameter nothing changes.Closes #15596
Part of #15594 (tracker stays open; remaining children #15597-#15600)
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson