Skip to content

✨ dashboard: add ?kiosk=1 unattended display mode for the Activity Monitor - #15601

Closed
hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-15596
Closed

hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-15596

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Streaming the Activity Monitor from a headless browser needs a chrome-free, dialog-free view. ?kiosk=1 flags the page early in boot; a kiosk stylesheet (specific enough to beat the !important topbar rule in /api/theme.css) hides everything except the Activity Monitor, and the Welcome and NPS prompts skip auto-opening. Without the parameter nothing changes.

Closes #15596

Part of #15594 (tracker stays open; remaining children #15597-#15600)

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson

…nitor

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15591 🐛 adoption: superseded PRs close promptly and read as one muted tracker line same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15530 🐛 fix(dashboard): issue-row linked PR passes null when the lineage chip is empty same files src/pkg/dashboard/static/index.html
#15584 🐛 Close the hive's own empty-diff PRs as superseded instead of asking a person same files src/pkg/dashboard/static/index.html
#15521 🌱 refactor: split tracker row source same files src/pkg/dashboard/static-src/manifest.txt
#15565 🌱 refactor: split tracker words source same files src/pkg/dashboard/static-src/manifest.txt
#15526 🌱 dashboard: split stage_tracker.go into 4 files same files src/docs/dashboard-sections.md
#15574 🌱 dashboard: split stage_tracker.go into 4 files same files src/docs/dashboard-sections.md

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the kiosk wiring against the built index.html at head e64ce4b. Looks correct to me.

  • Specificity claim holds: the theme rule is body #oc-topbar.oc-topbar{…display:grid!important} (src/pkg/dashboard/theme/theme.go:45, specificity 1-1-1); the kiosk rule html.kiosk body #oc-topbar.oc-topbar is 1-2-2, so with both !important the kiosk display:none wins.
  • #activity-monitor-section (index.html:7569) is a top-level [data-dashboard-section] with no data-dashboard-section ancestor, so the :not(#activity-monitor-section) rule cannot hide it via a parent. All other hidden ids/classes exist (#dash-notices:6882, .oc-sidebar-resize:7050, #oc-sidebar:7051, #oc-topbar:7157, #nps-survey-card created at :61637).
  • The default body padding reserves calc(var(--sidebar-w) + var(--sp-7)) on the left (index.html:126); html.kiosk body { padding: var(--sp-5) !important } overrides it, so the monitor is not pushed right by a hidden sidebar.
  • static-src and static/index.html carry identical hunks, and css/kiosk.css is in manifest.txt.
  • The initWelcomeDialog/initNPSSurvey early returns are the first statement in each function, as the test pins.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Closing as superseded: #15595 (merged to v5 at aa1b5af) already ships ?kiosk=1 kiosk mode — static-src/css/kiosk.css, kiosk_mode_test.go (TestKioskModeWiring), and the boot.js / welcome.js / nps.js wiring. That is why tide reports this PR as conflicting: both branches add the same files. Rebasing would land a second, divergent implementation of the same feature, so this PR is withdrawn instead. #15596 is complete via #15595.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 080-awaiting-merge-admission → 070-fixing: conflicting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] dashboard: add ?kiosk=1 unattended display mode for the Activity Monitor

0 participants