Repository navigation
π tracker: queue ordinals say 'of N' and name their train - #15590
Merged
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Two trains on one page read as two unexplained "Merge queued Β· 1st" /
"Β· 2nd" pairs: the ordinal is per train, but the chevron never said so
and every train's rail wore the same colour.
- Queue words carry the length: "Merge queued Β· 1st of 2"; the
provisional suffix reads "queued 1st of 2 once ready".
- Past one train on the page the word ends with the train's tag
("Β· train main.go": overlap basename, else the head #N) and the
hover leads "Train of 2 PRs overlapping main.go; merges after
#15567."; one train β no tag. stageTrackerTrainIndex counts the
page's trains once per render (ctx.trains / ctx.trainIndex).
- Each train's header and member rows share a rail accent
(.ham-train-k0..k3, cycling in page order).
- Node test for 1 vs 2 trains; copy inventory + docs; changelog.
Fixes #15589
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
clubanderson
force-pushed
the
fix/train-ordinal-of-n
branch
from
October 30, 2026 00:43
80d1e9c to
49991e6
Compare
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
This was referenced Oct 30, 2026
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15589
Problem
Two trains on one page: "2 PRs Β· 1st: #15567 Β· overlapping: main.go" and "2 PRs Β· 1st: #15537 Β· overlapping: stage_tracker.go" β four chevrons reading Merge queued Β· 1st / 2nd / 1st / 2nd. The ordinal is per train, but nothing on the chevron says so, and every train's rail wears the same colour.
Change
stageTrackerTrainWord, gate chip)Merge queued Β· 1stMerge queued Β· 1st of 2queued 1st once readyqueued 1st of 2 once readyΒ· train main.go(overlap basename, else head#N); hover leads Train of 2 PRs overlapping main.go; merges after #15567..ham-train-k0β¦k3accent (blue / purple / cyan / amber, cycling in page order)Plumbing:
stageTrackerTrainIndex(items)β{count, index}computed once per render intracker-filter.js, passed asctx.trains/ctx.trainIndexthroughstageTrackerSegmentsβstageTrackerTrainWordandstageTrackerMergeGateInfo(For)/WordHtml/CueHtml;stageTrackerTrainRows/RowClass/HeaderHtmltake the accent slot.Tests
TestStageTrackerTrainTagOnTwoTrains: index count for 0/1/2 trains (wrappers read through), "of N" always, tag only past one train, two trains never share a word for the same place, head fallback tag, chip/hover/cue carry the train sentence, provisional + tag, accent classes on header and rows.dashboard-sections.md+ API reference wording; changelog fragment.Screenshots
Before:
After: