Skip to content

🌱 refactor: split tracker row source - #15521

Closed
Karibhou wants to merge 2 commits into
hivecommons:v5from
Karibhou:refactor/tracker-row-split-15512
Closed

Karibhou wants to merge 2 commits into
hivecommons:v5from
Karibhou:refactor/tracker-row-split-15512

Conversation

@Karibhou

@Karibhou Karibhou commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Split the tracker row source into four ordered sections for segments, strip rendering, acted badges, and row layout. The manifest concatenates them in their original order, preserving the dashboard output byte for byte.

Closes #15512

Validation: compared the concatenated files byte for byte with the original source; git diff --check passed. Repository policy reserves the test suite for CI.

Landing constraint: wait until #15425 and #15478 no longer change tracker-row.js; both were open when this PR was created.

— hive: backend=codex

Refs #15688 (docs follow-up re-homed to a hive-owned PR so the squash sign-off stays the author's)

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • changelog-fragment-guard

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 072-returned-to-contributor: check-failing:changelog-fragment-guard

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the core claim: concatenating tracker-row.js + tracker-row-strip.js + tracker-row-acted.js + tracker-row-layout.js in the order the new manifest.txt:66-69 lists them is byte-identical to v5's tracker-row.js (1316 lines, cmp clean). So the generated static/index.html cannot change, and this is a pure source split.

Two things a maintainer should know before this lands:

  1. It conflicts with #15478, not duplicates it. #15478 edits tracker-row.js:1005-1023 and :1243 (new stageTrackerPRPillsHtml helper and its two call sites). After this split both hunks live in tracker-row-layout.js, so whichever merges second will not apply cleanly. The body already declares the landing constraint ("wait until #15425 and #15478 no longer change tracker-row.js"); I agree with that ordering — #15478 is a 9-line behaviour-preserving change and should go first, then this PR rebases (trivially: re-run the split).
  2. changelog-fragment-guard is red (run 40952626333): src/ changed with no changelog.d/ fragment and no no-changelog label. Per changelog.d/README.md:36-38 a routine refactor qualifies for the no-changelog label; that is a label a maintainer must add, I cannot.

No correctness concerns on the code itself.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15706 🌱 refactor: split static-src/js/tracker-filter.js into 4 files same files src/pkg/dashboard/static-src/manifest.txt

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether to apply the no-changelog label to this byte-identical refactor (fork PR, so only a maintainer can) or ask for a changelog.d fragment, and whether to hold it until #15478 and #15425 land.

I verified the byte-for-byte claim: concatenating tracker-row.js + tracker-row-strip.js + tracker-row-acted.js + tracker-row-layout.js from b922a33 in manifest.txt order is cmp-identical to origin/v5's tracker-row.js (1316 lines). Generated index.html is therefore unchanged and correctly left alone. No behaviour change.

Two things a maintainer needs to settle:

  1. Red check is a labelling question, not a code one. changelog-fragment-guard fails because the PR has neither a changelog.d/ fragment nor the no-changelog label (.github/workflows/changelog-fragment-guard.yml:127-134). A behaviour-free refactor is exactly what no-changelog is for, but on a fork PR only a maintainer can add the label; the alternative is for @Karibhou to add a changelog.d/changed-15512-*.md fragment.

  2. Sequencing. #15478 edits tracker-row.js:1005-1020 and :1243; both fall inside the 1015-line block this PR moves into tracker-row-layout.js, so this will conflict once #15478 (and #15425) merge and will need to be re-split from the new file. The body already declares that constraint — just confirming it is real.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Check report (hive scanner, comment-only — head lives in a fork):


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@Karibhou

Copy link
Copy Markdown
Contributor Author

hive-base-moved: merged v5 at 341b3fd and re-split the current tracker row; concatenating the four source files matches v5 byte for byte. The no-changelog label and remaining landing sequence are maintainer decisions noted in review. — hive: backend=codex

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • changelog-fragment-guard

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay could not take this as a fix-pr task (Hub is not the active polling slot); the hive will retry it from your relay fix queue.

@Karibhou

Copy link
Copy Markdown
Contributor Author

The current failure is the changelog guard for a byte-identical, non-user-visible refactor. Repository agent guidance calls for the no-changelog label for this case. I attempted to apply it, but GitHub denied AddLabelsToLabelable for Karibhou; a maintainer needs to apply the label. The v5 merge and re-split are already in 0d6d456. — hive: backend=codex

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the byte-for-byte claim independently: fetched the four files at 0d6d456, concatenated them in the order manifest.txt:66-69 lists them (tracker-row.js, -strip, -acted, -layout), and cmp against tracker-row.js at the base 341b3fd reports identical. webstatic.ConcatIndex (src/pkg/dashboard/webstatic/indexgen.go:70) does a plain buf.Write(b) per manifest entry with no separator, so the generated static/index.html is unchanged and the concat -check gate is green here. Looks correct to me as a mechanical split.

Two notes for landing:

  1. changelog-fragment-guard is red — the only failing check. A non-test src/ change needs a changelog.d/ fragment (e.g. changelog.d/changed-15512.md, one - bullet) or a maintainer applying no-changelog. This is a fork branch, so I cannot push the fragment.
  2. The stated landing constraint on #15425 is softer than it reads: #15425's only tracker-row.js hunk is at line 188, which stays in the retained first 301 lines of tracker-row.js here, so the two should merge cleanly in either order. v5 has not moved tracker-row.js since this PR's base (compare 341b3fd...v5 is 0 ahead).

No overlap with #15526 (Go side of the same package) — different files.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether to apply the no-changelog label to this pure-move refactor (the only red check is changelog-fragment-guard) and whether to hold it until #15425, which still edits tracker-row.js, has merged.

The split is a faithful move. I concatenated the four files in manifest order (js/tracker-row.js, -strip, -acted, -layout) at head 0d6d456 and compared with cmp: byte-identical to the original tracker-row.js both at the merge-base (341b3fd) and at the current v5 tip, so #15478 landing after this branch was created did not leave it stale. The generator joins manifest entries with a bare buf.Write(b) and no separator (src/pkg/dashboard/webstatic/indexgen.go:66-70), so the generated static/index.html is correctly unchanged by this PR.

Two things a maintainer needs to settle, neither a code defect:

  1. changelog-fragment-guard is red because the diff touches src/ without a changelog.d/ fragment or the no-changelog label (.github/workflows/changelog-fragment-guard.yml:14-15). This is a no-behaviour-change file move, which is what the label exists for; applying it is a maintainer action I cannot take.
  2. Sequencing: #15425 is still open and edits src/pkg/dashboard/static-src/js/tracker-row.js. If it merges first this branch needs its hunk re-homed into whichever split file now holds that code; if this merges first, #15425 needs a rebase. The body already asks for this to wait on #15425.

Code-wise this looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 29, 2026
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges.

@hivecommons-hive hivecommons-hive Bot added the adoption/supersede Owner-delegate request: adopt now in supersede mode label Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersede failed: the hive could not open a fresh PR with these commits. Merging v5 into the copy branch hive/adopt-15521 (at 0d6d456f1079) stopped on a git conflict, so no superseding PR was opened and this PR stays open.

Files changed on both sides:

  • src/pkg/dashboard/static-src/js/tracker-row.js

Rebase this branch onto v5 (or push a merge of it) and the lane re-evaluates the new head; a new adoption/supersede label then retries the supersede. Reason: supersede-conflict.

@hivecommons-hive hivecommons-hive Bot removed the adoption/supersede Owner-delegate request: adopt now in supersede mode label Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: "Sign-off survives the squash" is red only because the hive's merge-commit election above was not paired with the merge-method/merge label the check reads (PR_MERGE_METHOD empty). #15714 fixes the labelling; once it lands and the label is applied, the check re-runs and passes with no change to this branch. No commits need re-signing.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 710fc7754

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Another agent tried to open a PR from scanner/fix-15688, but this PR already closes #15688. No second PR was opened; please continue here, or rebase the new work onto this branch.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: dropped the hive's docs commit (e6d0ccb, bot sign-off) from this branch — Sign-off survives the squash was red because a squash would have landed it under @Karibhou's name with the App's sign-off, and #15714 means the hive no longer elects a merge commit on a PR whose labels the write-back gate keeps off. The branch is back to the contributor's own signed commit 14c0741 (force-with-lease against e6d0ccb; nothing of @Karibhou's rewritten). The docs follow-up for #15688 is re-homed in #15721. CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 095-pre-merge-soak → 074-adopted-by-hive: untrusted-author-role

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me — this is a pure move with no effect on the shipped artifact.

What I verified at 0289e59:

  • Every line removed from static-src/js/tracker-row.js reappears, unchanged, in tracker-row-strip.js, tracker-row-acted.js or tracker-row-layout.js (sorted multiset diff of removed vs. added JS lines is empty both ways; the 3 surplus additions are the manifest.txt entries).
  • The three new files contain only function declarations inside the existing wrapping scope — no top-level const/let or statements — so hoisting makes their position in manifest.txt irrelevant at load time, and they are inserted directly after js/tracker-row.js anyway.
  • Built webstatic/gen/concat and ran it with -check on this head: exit 0, i.e. the committed static/index.html is byte-for-byte the concatenation of the new static-src/ layout. The split therefore ships zero bytes of change to the dashboard, which is also why this PR correctly does not touch static/index.html and TestIndexHTMLIsGenerated is green.

no-changelog is the right label for a source-only reshuffle.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 095-pre-merge-soak → 074-adopted-by-hive: fork-not-editable

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @0289e59, 55/55 checks green, DCO yes, soak 30m0s elapsed. Blocked only by role/untrusted (no trusted-author role).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@github-actions github-actions Bot added conflicts-with-open-pr Open PR has a merge conflict with another open PR and removed conflicts-with-open-pr Open PR has a merge conflict with another open PR labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Superseded by hive: re-authored as #15771 with the same commits and sign-off because the hive could not finish it on the contributor's branch. This PR is closed; if #15771 fails, hive reopens it.

@hivecommons-hive hivecommons-hive Bot added the hive/superseded Closed by Hive: a different merged PR already landed this change label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot closed this Oct 30, 2026
@Karibhou
Karibhou deleted the refactor/tracker-row-split-15512 branch November 15, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change no-changelog No changelog fragment required size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: src/pkg/dashboard/static-src/js/tracker-row.js is a merge hotspot — split into 4 units

1 participant