Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
stage 080-awaiting-merge-admission → 072-returned-to-contributor: check-failing:changelog-fragment-guard |
There was a problem hiding this comment.
Verified the core claim: concatenating tracker-row.js + tracker-row-strip.js + tracker-row-acted.js + tracker-row-layout.js in the order the new manifest.txt:66-69 lists them is byte-identical to v5's tracker-row.js (1316 lines, cmp clean). So the generated static/index.html cannot change, and this is a pure source split.
Two things a maintainer should know before this lands:
- It conflicts with #15478, not duplicates it. #15478 edits
tracker-row.js:1005-1023and:1243(newstageTrackerPRPillsHtmlhelper and its two call sites). After this split both hunks live intracker-row-layout.js, so whichever merges second will not apply cleanly. The body already declares the landing constraint ("wait until #15425 and #15478 no longer changetracker-row.js"); I agree with that ordering — #15478 is a 9-line behaviour-preserving change and should go first, then this PR rebases (trivially: re-run the split). changelog-fragment-guardis red (run 40952626333):src/changed with nochangelog.d/fragment and nono-changeloglabel. Perchangelog.d/README.md:36-38a routine refactor qualifies for theno-changeloglabel; that is a label a maintainer must add, I cannot.
No correctness concerns on the code itself.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether to apply the no-changelog label to this byte-identical refactor (fork PR, so only a maintainer can) or ask for a changelog.d fragment, and whether to hold it until #15478 and #15425 land.
I verified the byte-for-byte claim: concatenating tracker-row.js + tracker-row-strip.js + tracker-row-acted.js + tracker-row-layout.js from b922a33 in manifest.txt order is cmp-identical to origin/v5's tracker-row.js (1316 lines). Generated index.html is therefore unchanged and correctly left alone. No behaviour change.
Two things a maintainer needs to settle:
-
Red check is a labelling question, not a code one.
changelog-fragment-guardfails because the PR has neither achangelog.d/fragment nor theno-changeloglabel (.github/workflows/changelog-fragment-guard.yml:127-134). A behaviour-free refactor is exactly whatno-changelogis for, but on a fork PR only a maintainer can add the label; the alternative is for @Karibhou to add achangelog.d/changed-15512-*.mdfragment. -
Sequencing. #15478 edits
tracker-row.js:1005-1020and:1243; both fall inside the 1015-line block this PR moves intotracker-row-layout.js, so this will conflict once #15478 (and #15425) merge and will need to be re-split from the new file. The body already declares that constraint — just confirming it is real.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Check report (hive scanner, comment-only — head lives in a fork):
🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
hive-base-moved: merged v5 at 341b3fd and re-split the current tracker row; concatenating the four source files matches v5 byte for byte. The no-changelog label and remaining landing sequence are maintainer decisions noted in review. — hive: backend=codex |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay could not take this as a |
|
The current failure is the changelog guard for a byte-identical, non-user-visible refactor. Repository agent guidance calls for the |
There was a problem hiding this comment.
Verified the byte-for-byte claim independently: fetched the four files at 0d6d456, concatenated them in the order manifest.txt:66-69 lists them (tracker-row.js, -strip, -acted, -layout), and cmp against tracker-row.js at the base 341b3fd reports identical. webstatic.ConcatIndex (src/pkg/dashboard/webstatic/indexgen.go:70) does a plain buf.Write(b) per manifest entry with no separator, so the generated static/index.html is unchanged and the concat -check gate is green here. Looks correct to me as a mechanical split.
Two notes for landing:
changelog-fragment-guardis red — the only failing check. A non-testsrc/change needs achangelog.d/fragment (e.g.changelog.d/changed-15512.md, one-bullet) or a maintainer applyingno-changelog. This is a fork branch, so I cannot push the fragment.- The stated landing constraint on #15425 is softer than it reads: #15425's only
tracker-row.jshunk is at line 188, which stays in the retained first 301 lines oftracker-row.jshere, so the two should merge cleanly in either order.v5has not movedtracker-row.jssince this PR's base (compare 341b3fd...v5is 0 ahead).
No overlap with #15526 (Go side of the same package) — different files.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether to apply the no-changelog label to this pure-move refactor (the only red check is changelog-fragment-guard) and whether to hold it until #15425, which still edits tracker-row.js, has merged.
The split is a faithful move. I concatenated the four files in manifest order (js/tracker-row.js, -strip, -acted, -layout) at head 0d6d456 and compared with cmp: byte-identical to the original tracker-row.js both at the merge-base (341b3fd) and at the current v5 tip, so #15478 landing after this branch was created did not leave it stale. The generator joins manifest entries with a bare buf.Write(b) and no separator (src/pkg/dashboard/webstatic/indexgen.go:66-70), so the generated static/index.html is correctly unchanged by this PR.
Two things a maintainer needs to settle, neither a code defect:
changelog-fragment-guardis red because the diff touchessrc/without achangelog.d/fragment or theno-changeloglabel (.github/workflows/changelog-fragment-guard.yml:14-15). This is a no-behaviour-change file move, which is what the label exists for; applying it is a maintainer action I cannot take.- Sequencing: #15425 is still open and edits
src/pkg/dashboard/static-src/js/tracker-row.js. If it merges first this branch needs its hunk re-homed into whichever split file now holds that code; if this merges first, #15425 needs a rebase. The body already asks for this to wait on #15425.
Code-wise this looks correct to me.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges. |
|
Supersede failed: the hive could not open a fresh PR with these commits. Merging Files changed on both sides:
Rebase this branch onto |
|
hive/awaiting-ci: "Sign-off survives the squash" is red only because the hive's merge-commit election above was not paired with the 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
e6d0ccb to
14c0741
Compare
|
Another agent tried to open a PR from |
|
hive/awaiting-ci: dropped the hive's docs commit (e6d0ccb, bot sign-off) from this branch — 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
stage 095-pre-merge-soak → 074-adopted-by-hive: untrusted-author-role |
There was a problem hiding this comment.
Looks correct to me — this is a pure move with no effect on the shipped artifact.
What I verified at 0289e59:
- Every line removed from
static-src/js/tracker-row.jsreappears, unchanged, intracker-row-strip.js,tracker-row-acted.jsortracker-row-layout.js(sorted multiset diff of removed vs. added JS lines is empty both ways; the 3 surplus additions are themanifest.txtentries). - The three new files contain only
functiondeclarations inside the existing wrapping scope — no top-levelconst/letor statements — so hoisting makes their position inmanifest.txtirrelevant at load time, and they are inserted directly afterjs/tracker-row.jsanyway. - Built
webstatic/gen/concatand ran it with-checkon this head: exit 0, i.e. the committedstatic/index.htmlis byte-for-byte the concatenation of the newstatic-src/layout. The split therefore ships zero bytes of change to the dashboard, which is also why this PR correctly does not touchstatic/index.htmlandTestIndexHTMLIsGeneratedis green.
no-changelog is the right label for a source-only reshuffle.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 095-pre-merge-soak → 074-adopted-by-hive: fork-not-editable |
|
Ready for a human merge: verdict approved @0289e59, 55/55 checks green, DCO yes, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
Split the tracker row source into four ordered sections for segments, strip rendering, acted badges, and row layout. The manifest concatenates them in their original order, preserving the dashboard output byte for byte.
Closes #15512
Validation: compared the concatenated files byte for byte with the original source;
git diff --checkpassed. Repository policy reserves the test suite for CI.Landing constraint: wait until #15425 and #15478 no longer change
tracker-row.js; both were open when this PR was created.— hive: backend=codex
Refs #15688 (docs follow-up re-homed to a hive-owned PR so the squash sign-off stays the author's)