Repository navigation
π± dashboard: split stage_tracker.go into 4 files - #15574
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mechanical split of the 3298-line merge hotspot into four files in the same package: stage_tracker.go (types, stage table, authoring/tier helpers), stage_tracker_caption.go (modifiers, reason/caption text), stage_tracker_build.go (buildStageTracker, ordering, cache, handler) and stage_tracker_links.go (linked issue/PR resolution). No behaviour change; declarations moved verbatim and imports re-derived with goimports. Rebased onto v5: the ledger-claim inputs (#15425) and the adoption-pair linked-PR progress helpers (#15550) that landed on stage_tracker.go since the branch point now live in stage_tracker_build.go and stage_tracker_links.go respectively. A routine refactor takes the no-changelog label rather than a fragment (changelog.d/README.md). Hive-Run: #15511 Hive-Plan: modularize-stage-tracker Signed-off-by: SACHIN NAIK <sachin.naik@ibm.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
05ac72b to
f23175b
Compare
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: rebased onto v5 (re-homed the #15425 ledger-claim inputs and #15550 adoption-pair helpers into the split files; partition verified line-for-line against v5). Requested the no-changelog label per the review on #15526. CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
stage 080-awaiting-merge-admission β 070-fixing: conflicting |
Port #15577's soak-caption hunks into the split stage_tracker_caption.go / stage_tracker_build.go. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
β¦tion.go Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: merged v5 (ported #15577's soak-caption hunks into stage_tracker_caption.go/stage_tracker_build.go) and fixed the ADR-0025 stageStoreOrShared citation. CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
β¦nto stage_tracker_caption.go Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: merged origin/v5 (ported the #15616 caption constant into stage_tracker_caption.go) β CI pending, sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
β¦ing into stage_tracker_build.go Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Reviewed (intent-alignment, delta re-review; read at current head e2f4fe86, which supersedes 7d28eccb) β no blocking findings.
The delta since b805bd9e is v5 forward-merges only; the net diff against v5 is still a mechanical move: every line removed from stage_tracker.go (β2425) reappears verbatim in stage_tracker_build.go / _caption.go / _links.go (the only unmatched lines are import blocks and two comment path updates), the package builds, and the result is exactly 4 files (1028/911/1003/554 lines) as #15511 requires.
Previous docs-currency finding: fixed in spirit β src/docs/adr/0025-central-stage-engine.md:47 now cites stage_tracker_caption.go, but the range 951-956 is stale after the merge ports; stageStoreOrShared is at src/pkg/dashboard/stage_tracker_caption.go:964-966. No CI guard checks ADR citations, so this is advisory only.
β hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Reviewed (style, delta re-review) β read at current head e2f4fe86 (the dispatched 7d28eccb has since gained one clean v5 merge touching no split file). The #15616 and #15639 ports into stage_tracker_caption.go:769 and stage_tracker_build.go:452 match the upstream hunks, and go build ./pkg/dashboard/ passes.
- ADR citation drifted again (low, advisory).
src/docs/adr/0025-central-stage-engine.md:47citesstageStoreOrSharedatstage_tracker_caption.go:951-956, but after the v5 merges the function is atstage_tracker_caption.go:964-971(comment at 964, body 966-971). This PR rewrote that citation on purpose, so it is worth re-pinning before merge; no CI check covers ADR citations.
β hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Reviewed (correctness, delta b805bd9β7d28eccb; also read current head e2f4fe86, which only merges v5 and touches none of the split files).
The two port merges are faithful: every non-comment line of v5 stage_tracker.go at merge-base c2a3287 appears exactly once across stage_tracker.go / _build.go / _caption.go / _links.go, the top-level declaration sets are identical, and the four upstream edits landed where they belong β LeftTrain (stage_tracker.go:443), WaitingOnHuman / WaitingOnYou / WaitKind (stage_tracker.go:72,328-329), resp.WaitingOnHuman = stageTrackerWaitingOnHuman(resp.Items) (stage_tracker_build.go:452), and stageTrackerAwaitingAdmissionCaption (stage_tracker_caption.go:769). No correctness findings.
Carry-over (docs, non-blocking): src/docs/adr/0025-central-stage-engine.md:47 cites stage_tracker_caption.go:951-956, but stageStoreOrShared sits at stage_tracker_caption.go:964-971 at head (already at 966 at b805bd9). Still present.
β hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
docs-currency (delta re-review, b805bd9 β 7d28ecc; also checked current head e2f4fe8)
ADR 0025 citation re-drifted β src/docs/adr/0025-central-stage-engine.md:47 cites stageStoreOrShared at src/pkg/dashboard/stage_tracker_caption.go:951-956, but at head that range is stageTrackerSupersededBy (stage_tracker_caption.go:948-960). stageStoreOrShared now sits at stage_tracker_caption.go:964-971 β the e25851a3 merge porting the #15616 caption constant into stage_tracker_caption.go shifted it 13 lines after 92c89c34 fixed the citation. check-docs-citations.py does not catch this (the range exists and the backticked anchor is on line 46, not the citing line 47), so it will not go red in CI. Fix: point the citation at stage_tracker_caption.go:964-971 (or drop the line range and keep the symbol only, since every v5 merge re-shifts this file).
Everything else in the delta is v5 merge traffic already reviewed on landing; dashboard-sections.md:955 stageTrackerModifiers in stage_tracker_caption.go verifies (stage_tracker_caption.go:271).
β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Supersedes #15526 (adopted after CI went red and the contributor was unavailable; original commits by @odttlnt preserved).
Closes #15511
This branch is #15526's head
05ac72b0e8e9as pushed by @odttlnt (forkodttlnt/hive), unchanged. Last lane reason on the original:check-failing:changelog-fragment-guard.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.