Skip to content

🌱 refactor: split tracker words source - #15565

Closed
Karibhou wants to merge 3 commits into
hivecommons:v5from
Karibhou:codex/15562-split-tracker-words
Closed

Karibhou wants to merge 3 commits into
hivecommons:v5from
Karibhou:codex/15562-split-tracker-words

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Split the tracker words source into four consecutive units and list them in the dashboard manifest. The concatenated JavaScript and generated dashboard remain byte-for-byte unchanged.

Closes #15562

Validation: compared the concatenated units with the original source and the complete manifest output with the committed dashboard HTML; git diff --check passed. Tests run in CI per AGENTS.md. No open PR touching tracker-words.js was found at preparation time; recheck overlap before landing.

β€” hive: backend=codex

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15658 πŸ› fix(tracker): PRs at CI / Review ride no merge train; overlap hint instead same files src/pkg/dashboard/static-src/js/tracker-words-core.js
#15521 🌱 refactor: split tracker row source same files src/pkg/dashboard/static-src/manifest.txt
#15657 πŸ› Tracker: chevron column follows the current state, never the highest stage reached same files src/pkg/dashboard/static-src/js/tracker-words-core.js
#15664 πŸ› tracker: a PR waiting on its author never leads with Close as superseded same files src/pkg/dashboard/static-src/js/tracker-words.js

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • mobile-shots

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • changelog-fragment-guard

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on v5 and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Check report (hive scanner, comment-only β€” head lives in a fork):

No branch was created on the base repo; the sweep merges once CI is green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 074-adopted-by-hive: required-check-failing:changelog-fragment-guard

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the mechanical claim locally: concatenating tracker-words-core.js + tracker-words-stage.js + tracker-words-gate.js + tracker-words.js in the new manifest.txt order is byte-identical (cmp) to tracker-words.js at the merge-base f226663, and nothing has touched tracker-words.js on v5 since, so the split currently rebases clean. No file overlap with the sibling splits #15521 (tracker-row), #15526 (stage_tracker.go) or #15566 (UI tests).

Two things for whoever lands it:

  1. The red check is a label, not the diff. changelog-fragment-guard fails because a refactor has no fragment; per src/scripts/check-changelog-fragment.sh the fix is a maintainer adding the no-changelog label β€” please don't add a fake changed- fragment for a no-op split.
  2. 828cecd "πŸ› fix: retry mobile shot profile cleanup" is outside #15562's scope. It changes src/scripts/dashboard-mobile-shots.mjs:245 (maxRetries 5β†’30, retryDelay 100β†’200 on the Chrome profile rmSync). That is a real behaviour tweak to tooling riding inside a PR whose whole justification is "byte-for-byte unchanged"; it also quietly makes the no-changelog label less honest. Suggest dropping that commit here and sending it as its own one-line πŸ› PR (with a fixed- fragment) so this one stays a pure split.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split itself is verified: concatenating tracker-words-core.js, tracker-words-stage.js, tracker-words-gate.js, tracker-words.js in the new manifest.txt order (lines 65-68) is byte-identical to tracker-words.js on v5 (diff exit 0, 1427 lines both sides), and webstatic/indexgen.go:64-70 (ConcatIndex) writes the parts back-to-back with no separator, so the generated dashboard is unchanged as the body says.

Two things keep it red / out of scope:

  1. Unrelated commit riding along. 828cecd (πŸ› fix: retry mobile shot profile cleanup) changes src/scripts/dashboard-mobile-shots.mjs:245 from maxRetries: 5, retryDelay: 100 to maxRetries: 30, retryDelay: 200. That is not part of #15562 (split the tracker words source) and it turns a pure refactor into a behaviour change in a different script. It belongs in its own PR with its own fixed-* fragment.
  2. changelog-fragment-guard is failing. The PR carries no changelog.d/ fragment and no no-changelog label (labels: dco-signoff: yes, size/XXL). A pure refactor qualifies for the label exemption (.github/workflows/changelog-fragment-guard.yml:14-19), but the author cannot add labels from a fork, so a maintainer would need to apply no-changelog once (1) is dropped β€” or, if (1) stays, the PR needs a fixed-… fragment for it.

Suggest: drop 828cecd from this branch, then a maintainer applies no-changelog. With that, this looks correct to me.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: changelog-fragment-guard was the only red check; this is a byte-for-byte refactor (concatenated JS and generated HTML unchanged), so the no-changelog label applies per changelog.d/README.md rather than a fragment. CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: f23175b2a

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot added conflicts-with-open-pr Open PR has a merge conflict with another open PR and removed conflicts-with-open-pr Open PR has a merge conflict with another open PR labels Oct 30, 2026
@hivecommons-hive
hivecommons-hive Bot force-pushed the codex/15562-split-tracker-words branch from 828cecd to 66e4202 Compare October 30, 2026 00:36
@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: rebased this adopted branch onto v5 in place (author and Signed-off-by preserved; the split was re-derived from the current v5 source so the four files still concatenate byte-for-byte to the original). no-changelog is already set, so changelog-fragment-guard should clear. CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 6593b830a

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot force-pushed the codex/15562-split-tracker-words branch from 66e4202 to 153b9ef Compare October 30, 2026 00:48
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: rebased onto v5 β€” re-split the updated tracker-words.js (#15581's provisional-slot additions) into the same four units; concatenation remains byte-for-byte equal to v5's file. Original author commits and sign-offs preserved. CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 153b9ef0e

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split itself is correct; the branch needs a rebase because tracker-words.js changed on v5 after it was cut.

What I verified at head 66e42027:

  • Concatenating js/tracker-words-core.js + tracker-words-stage.js + tracker-words-gate.js + tracker-words.js in the order static-src/manifest.txt:65-68 lists them is byte-identical (cmp, 98335 bytes) to tracker-words.js at the branch base 6593b83. webstatic/gen/concat.go writes sources verbatim with no separator, so static/index.html is correctly left untouched.

Why it is needs-rebase:

  • #15581 (b689da1, merged after this branch's base) edits the original tracker-words.js in three hunks at old lines @@ -185, @@ -237 and @@ -821. With the unit lengths at this head (core 438, stage 253, gate 387), the first two land in tracker-words-core.js and the third in tracker-words-gate.js. Those are the only conflicts; re-running the cmp against v5's tracker-words.js after the rebase is the check that nothing was dropped.

Scope note (low): the second commit (fix: retry mobile shot profile cleanup, src/scripts/dashboard-mobile-shots.mjs:245, maxRetries 5β†’30 / retryDelay 100β†’200) is unrelated to #15562. It is harmless, but a maintainer may prefer it split out so the refactor stays a pure no-op move. Not blocking from my side.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion: the split itself is a verified move-only; it needs a rebase because #15581 landed in tracker-words.js after this branch forked, and one unrelated line rides along.

What I checked (head 66e4202744b0, base v5): src/pkg/dashboard/webstatic/indexgen.go:51 concatenates manifest.txt entries verbatim and in order, so a split is safe iff the bytes are unchanged. At this head the full manifest concatenation hashes identically to the merge-base's β€” tracker-words.js + -core + -gate + -stage in the new manifest order reproduce the old file exactly. No behaviour change.

Rebase needed (not a defect): b689da1b3 (#15581, merged to v5 after your fork point) adds three hunks to tracker-words.js (around old lines 185, 237 and 821 β€” queue-slot suffix / provisional merge-train wording). git merge-tree v5 <head> reports a content conflict on that file. Those hunks must land in whichever of the new files now owns each region; after the rebase the same byte-identity check (cat the four files in manifest order and cmp against v5's tracker-words.js) will tell you it is right.

Scope note (info): src/scripts/dashboard-mobile-shots.mjs:245 bumps rmSync retries 5β†’30 / 100β†’200 ms. Harmless, but it is unrelated to the split and the body does not mention it β€” consider dropping it or naming it in the body so the no-changelog refactor stays a pure move.

Not a review event.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the split mechanically: tracker-words-core.js + tracker-words-stage.js + tracker-words-gate.js + tracker-words.js from 9cb4df0, in manifest order, is byte-identical (cmp) to tracker-words.js at the merge-base 5142fd3, and webstatic/indexgen.go:51-70 concatenates with no separators, so index.html is unchanged. The split itself is correct.

Two things for the author:

  1. It is stale. #15591 merged to v5 as 22cf3b8 and edits src/pkg/dashboard/static-src/js/tracker-words.js (+41 lines); git merge-tree origin/v5 <head> reports CONFLICT (content) there and GitHub now shows the PR as dirty. A resolution that takes this side would drop #15591's edits, so this needs a re-split on current v5 (and the byte compare re-run). The body's "no open PR touching tracker-words.js" was true at preparation time; #15591 landed since.
  2. src/scripts/dashboard-mobile-shots.mjs:245 (maxRetries 5β†’30, retryDelay 100β†’200 on fs.rmSync) is unrelated to splitting the words source and is not mentioned in the body or #15562. Probably worth its own commit/PR so the refactor stays a pure byte-for-byte move.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

Hive-Run: hivecommons#15562
Hive-Plan: issue-15562-mechanical-split
Hive-Spec: issue-15562#split-proposal
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@hivecommons-hive
hivecommons-hive Bot force-pushed the codex/15562-split-tracker-words branch from 9cb4df0 to 2db25ef Compare October 30, 2026 01:59
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: rebased the adopted branch onto current v5 (re-derived the mechanical split from v5's current source; the split files still concatenate byte-for-byte to v5's file; original author and Signed-off-by preserved, no commits squashed). CI pending β€” sweep will merge when green. Note: every further v5 merge touching the split source file re-conflicts this PR, so it should be admitted before sibling edits to the same file land.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 2db25efbb

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@Karibhou

Copy link
Copy Markdown
Contributor Author

Removed the unrelated mobile screenshot cleanup change in 1f5a879, keeping this PR scoped to the tracker split. The four parts concatenate byte-for-byte to the current v5 source.

β€” hive: backend=codex

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you (stage/074-adopted-by-hive β†’ stage/072-returned-to-contributor). It will nudge again if CI stays red.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the byte-for-byte claim independently rather than taking it from the body.

Concatenated the units in static-src/manifest.txt order (core, stage, gate, then the trimmed tracker-words.js) and ran cmp against static-src/js/tracker-words.js at both the merge-base (bf291e3) and current v5 HEAD: identical in both cases, so the generated static/index.html cannot change and the PR correctly leaves it untouched. No file outside static-src/ differs from v5. Pure mechanical split; looks correct to me.

One sequencing note for whoever merges: #15612 and #15616 (open, owner-authored) both edit tracker-words.js; whichever lands second will need its hunk re-homed into the right unit. Not a defect in this PR.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 060-reviewed: untrusted-author-role

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges.

@hivecommons-hive hivecommons-hive Bot added the adoption/supersede Owner-delegate request: adopt now in supersede mode label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges.

Author offline; maintainer asked hive to adopt and carry this split to merge.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closing: #15632 (the hive's adoption of this PR, with @Karibhou's commits) has merged. Thank you!

@hivecommons-hive hivecommons-hive Bot closed this Oct 30, 2026
@Karibhou
Karibhou deleted the codex/15562-split-tracker-words branch November 15, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. no-changelog No changelog fragment required size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: src/pkg/dashboard/static-src/js/tracker-words.js is a merge hotspot β€” split into 4 units

1 participant