Repository navigation
π fix(dashboard): issue-row linked PR passes null when the lineage chip is empty - #15643
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
β¦ip is empty stageTrackerLineageChipHtml returns '' when the lineage has no text, and stageTrackerPRPillsHtml only skips the separator for null, so the issue row emitted a trailing space. Coalesce the empty chip to null, as the sub-row caller already does. Fixes #15523 Hive-Run: #15523 Hive-Plan: issue-15523 lineage chip null coalesce Hive-Spec: issue-15523#lineage-chip-null Signed-off-by: SACHIN NAIK <sachin.naik@ibm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether to close #15643 (and its source #15530) as superseded by merged #15529, which already landed this exact fix on v5.
Conclusion: this is a no-op against v5. The one-line change here already landed in #15529 (merged, 0d67c0eb8), and the conflict that parks this PR is that same line having moved on since.
Evidence (read from v5 @ 5380ab4):
- This PR (head
c49dc25f, identical to #15530) changessrc/pkg/dashboard/static-src/js/tracker-row.js:1246from⦠? stageTrackerLineageChipHtml(lp, nowMs) : nullto(⦠? stageTrackerLineageChipHtml(lp, nowMs) : '') || null. - #15529 made the semantically identical change on the same line (
β¦ ? (stageTrackerLineageChipHtml(lp, nowMs) || null) : null) for the same symptom (#15493 β empty chip emitting a stray separator before the base pill). Both coalesce the''thatstageTrackerLineageChipHtmlreturns (tracker-row.js:1012) tonullsostageTrackerPRPillsHtml(tracker-row.js:1054-1055,lineage == null ? '') omits the separator. v5today reads(β¦ ? stageTrackerLineageChipHtml(lp, nowMs) : '') || (β¦ stageTrackerAdoptedFromChipHtml(lp, nowMs) : '') || nullattracker-row.js:1293β a strict superset of this diff. Rebasing this branch would produce an empty change (or re-introduce a regression if the adopted-from fallback were dropped).
There is nothing for the fix lane to resolve here; the rebase-resolve episode on this branch will burn attempts for no change. Recommend closing #15643 and #15530 as superseded by #15529 and noting that on #15523. I have not closed anything.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Intent alignment (read head c49dc25f): the contract, #15523, is already satisfied on v5 and the issue is closed.
- #15529 (merged 2026-10-29T23:22Z) landed the identical
|| nullcoercion at the issue-row call site βsrc/pkg/dashboard/static-src/js/tracker-row.js:1293onv5now reads(lp.lineage && β¦ ? stageTrackerLineageChipHtml(lp, nowMs) : '') || (typeof stageTrackerAdoptedFromChipHtml === 'function' ? stageTrackerAdoptedFromChipHtml(lp, nowMs) : '') || null, with a regression test insrc/pkg/dashboard/stage_tracker_ui_test.go:738-757and fragmentchangelog.d/fixed-15529-empty-lineage.md. #15523's closing comment records this. - This PR's diff (
tracker-row.js:1246,static/index.html:16814) is therefore a no-op against base, and it isCONFLICTING. A naive conflict resolution that keeps this branch's line would drop thestageTrackerAdoptedFromChipHtmlfallback that #15529 added;changelog.d/fixed-15523-lineage-chip-empty.mdwould also duplicate the already-landed fragment.
Requested change: close as superseded by #15529 (no code to carry forward), as was done for #15636.
β hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Review-fix attempt 1/6 β no commit pushed (superseded) Verified against
There is no safe code change to make here. Recommendation per review findings: close as superseded by #15529. Leaving the close decision to a human/owner. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Supersedes #15530 (adopted after CI went red and the contributor was unavailable; original commits by @odttlnt preserved).
Fixes #15523
This branch is #15530's head
c49dc25f6aaeas pushed by @odttlnt (forkodttlnt/hive), unchanged. Last lane reason on the original:label:needs-rebase.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.Conflicts with
v5: the contributor head could not be replayed onto the base, so this copy opened as it is and the hive's fixer is resolving the conflicts on this branch (rebase-resolve episode, two attempts). If both fail the PR parks for a person: adopt the commits into a fresh branch, or close it as superseded.