Skip to content

πŸ› fix(dashboard): issue-row linked PR passes null when the lineage chip is empty - #15643

Closed
hivecommons-hive[bot] wants to merge 1 commit into
v5from
hive/adopt-15530
Closed

hivecommons-hive[bot] wants to merge 1 commit into
v5from
hive/adopt-15530

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #15530 (adopted after CI went red and the contributor was unavailable; original commits by @odttlnt preserved).

Fixes #15523

This branch is #15530's head c49dc25f6aae as pushed by @odttlnt (fork odttlnt/hive), unchanged. Last lane reason on the original: label:needs-rebase.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

Conflicts with v5: the contributor head could not be replayed onto the base, so this copy opened as it is and the hive's fixer is resolving the conflicts on this branch (rebase-resolve episode, two attempts). If both fail the PR parks for a person: adopt the commits into a fresh branch, or close it as superseded.

…ip is empty

stageTrackerLineageChipHtml returns '' when the lineage has no text, and
stageTrackerPRPillsHtml only skips the separator for null, so the issue
row emitted a trailing space. Coalesce the empty chip to null, as the
sub-row caller already does.

Fixes #15523

Hive-Run: #15523
Hive-Plan: issue-15523 lineage chip null coalesce
Hive-Spec: issue-15523#lineage-chip-null
Signed-off-by: SACHIN NAIK <sachin.naik@ibm.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15633 🌱 refactor: split stage tracker UI tests same files src/pkg/dashboard/static/index.html
#15530 πŸ› fix(dashboard): issue-row linked PR passes null when the lineage chip is empty same files changelog.d/fixed-15523-lineage-chip-empty.md
src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html
#15566 🌱 refactor: split stage tracker UI tests same files src/pkg/dashboard/static/index.html
#15637 πŸ“– community: list the Twitch live stream everywhere community links live same files src/pkg/dashboard/static/index.html
#15521 🌱 refactor: split tracker row source same files src/pkg/dashboard/static-src/js/tracker-row.js

@hivecommons-hive hivecommons-hive Bot added the role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) label Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether to close #15643 (and its source #15530) as superseded by merged #15529, which already landed this exact fix on v5.

Conclusion: this is a no-op against v5. The one-line change here already landed in #15529 (merged, 0d67c0eb8), and the conflict that parks this PR is that same line having moved on since.

Evidence (read from v5 @ 5380ab4):

  • This PR (head c49dc25f, identical to #15530) changes src/pkg/dashboard/static-src/js/tracker-row.js:1246 from … ? stageTrackerLineageChipHtml(lp, nowMs) : null to (… ? stageTrackerLineageChipHtml(lp, nowMs) : '') || null.
  • #15529 made the semantically identical change on the same line (… ? (stageTrackerLineageChipHtml(lp, nowMs) || null) : null) for the same symptom (#15493 β€” empty chip emitting a stray separator before the base pill). Both coalesce the '' that stageTrackerLineageChipHtml returns (tracker-row.js:1012) to null so stageTrackerPRPillsHtml (tracker-row.js:1054-1055, lineage == null ? '') omits the separator.
  • v5 today reads (… ? stageTrackerLineageChipHtml(lp, nowMs) : '') || (… stageTrackerAdoptedFromChipHtml(lp, nowMs) : '') || null at tracker-row.js:1293 β€” a strict superset of this diff. Rebasing this branch would produce an empty change (or re-introduce a regression if the adopted-from fallback were dropped).

There is nothing for the fix lane to resolve here; the rebase-resolve episode on this branch will burn attempts for no change. Recommend closing #15643 and #15530 as superseded by #15529 and noting that on #15523. I have not closed anything.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent alignment (read head c49dc25f): the contract, #15523, is already satisfied on v5 and the issue is closed.

  • #15529 (merged 2026-10-29T23:22Z) landed the identical || null coercion at the issue-row call site β€” src/pkg/dashboard/static-src/js/tracker-row.js:1293 on v5 now reads (lp.lineage && … ? stageTrackerLineageChipHtml(lp, nowMs) : '') || (typeof stageTrackerAdoptedFromChipHtml === 'function' ? stageTrackerAdoptedFromChipHtml(lp, nowMs) : '') || null, with a regression test in src/pkg/dashboard/stage_tracker_ui_test.go:738-757 and fragment changelog.d/fixed-15529-empty-lineage.md. #15523's closing comment records this.
  • This PR's diff (tracker-row.js:1246, static/index.html:16814) is therefore a no-op against base, and it is CONFLICTING. A naive conflict resolution that keeps this branch's line would drop the stageTrackerAdoptedFromChipHtml fallback that #15529 added; changelog.d/fixed-15523-lineage-chip-empty.md would also duplicate the already-landed fragment.

Requested change: close as superseded by #15529 (no code to carry forward), as was done for #15636.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Review-fix attempt 1/6 β€” no commit pushed (superseded)

Verified against v5 HEAD:

There is no safe code change to make here. Recommendation per review findings: close as superseded by #15529. Leaving the close decision to a human/owner.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Closing: the change this PR carries (empty lineage chip β†’ null for the issue-row linked PR) already landed on v5 via #15591 (22cf3b8), and #15523 is closed. Rebasing onto v5 leaves an empty diff.

@hivecommons-hive hivecommons-hive Bot closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (security): Issue-row caller still passes '' instead of null when lineage chip is empty (carried over)

1 participant