Repository navigation
π adoption: offline clanker PRs don't stall at 'PR in progress' - #15593
Merged
Merged
Conversation
A contributor PR whose stage labels the write-back gate kept off GitHub (fork PR, no opt-in label) was read by the tracker as an unclassified "PR in progress Β· @x's clanker" even while the stage engine held it at 085: stageTrackerStaleDecisionRecord took the missing park label as a lifted park and dropped the record. The reconciler now notes labels_suppressed on the record and the tracker trusts such a record. An unclassified clanker PR carries its author's presence; when the clanker is offline the chevron reads "Β· @x's clanker Β· β offline 3h" and the caption names the next automatic step (a green PR is reviewed and merged without its author; adoption only once returned and unpushed for adoption.after_offline). Human PRs unchanged, never adopted. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
This was referenced Oct 30, 2026
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This was referenced Oct 30, 2026
This was referenced Oct 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15592
Root cause
Fork PRs without the
hive-reviewopt-in label have theirstage/*labels kept off GitHub by the write-back gate (by design, "tracked internally"). The tracker'sstageTrackerStaleDecisionRecordread a label-less 085 record as a lifted park and dropped it, so a dozen PRs the engine held at 085 Needs human decision rendered as the unclassified fallback "PR in progress Β· @odttlnt's clanker" for hours β with no presence/offline indication, since those surfaces key off the stage.Change
stagelabels.Record.LabelsSuppressed(labels_suppressed): the reconciler notes the writer'sOutcome.Suppressedafter each landed write (an errored write leaves it as it was).stageTrackerStaleDecisionRecordkeeps a suppressed-label record.stageTrackerWaitingOnincludes an unclassified (stage None) clanker PR, so the row carriespresence(next: wait, noadopt_atβ the adoption clock runs only at 072).stageTrackerHolderPresenceHtmlappendsΒ· β offline 3h/Β· β not registered(muted,--text-faint) after the holder token in the chevron; title = the presence tooltip. Online adds nothing; human rows unchanged.adoption.after_offline).State machine (unchanged, now visible)
clanker offline β green PR: review/merge admission run without the author (050/060/080) β 085 is a human's decision, author not needed β only a returned PR (072: red/conflicting/review asks) is nudged, then adopted after
after_offlinepast the last heartbeat (retry afteroffline_grace) β human PRs never adopted.Tests
TestReconcileRecordsSuppressedLabels,TestStageTrackerStaleDecisionRecord(new case),TestStageTrackerSuppressedDecisionRecordKeepsStage,TestStageTrackerUnclassifiedClankerPROfflineCaption,TestStageTrackerHolderPresenceJS(node). Docs: dashboard-sections.md, dashboard-copy-inventory.md; changelog fragment.