Skip to content

πŸ› adoption: offline clanker PRs don't stall at 'PR in progress' - #15593

Merged
clubanderson merged 1 commit into
v5from
fix/offline-clanker-pr-in-progress
Oct 30, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/offline-clanker-pr-in-progress

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15592

Root cause

Fork PRs without the hive-review opt-in label have their stage/* labels kept off GitHub by the write-back gate (by design, "tracked internally"). The tracker's stageTrackerStaleDecisionRecord read a label-less 085 record as a lifted park and dropped it, so a dozen PRs the engine held at 085 Needs human decision rendered as the unclassified fallback "PR in progress Β· @odttlnt's clanker" for hours β€” with no presence/offline indication, since those surfaces key off the stage.

Change

  • stagelabels.Record.LabelsSuppressed (labels_suppressed): the reconciler notes the writer's Outcome.Suppressed after each landed write (an errored write leaves it as it was). stageTrackerStaleDecisionRecord keeps a suppressed-label record.
  • stageTrackerWaitingOn includes an unclassified (stage None) clanker PR, so the row carries presence (next: wait, no adopt_at β€” the adoption clock runs only at 072).
  • SPA: stageTrackerHolderPresenceHtml appends Β· β–  offline 3h / Β· β—‹ not registered (muted, --text-faint) after the holder token in the chevron; title = the presence tooltip. Online adds nothing; human rows unchanged.
  • Caption on an unclassified offline-clanker PR: "@x's clanker is offline 3h; a green PR is reviewed and merged without its author β€” hive adopts it only once it is returned (red CI, conflicts or review asks) and nothing is pushed for 15m" (adoption.after_offline).

State machine (unchanged, now visible)

clanker offline β†’ green PR: review/merge admission run without the author (050/060/080) β†’ 085 is a human's decision, author not needed β†’ only a returned PR (072: red/conflicting/review asks) is nudged, then adopted after after_offline past the last heartbeat (retry after offline_grace) β†’ human PRs never adopted.

Tests

TestReconcileRecordsSuppressedLabels, TestStageTrackerStaleDecisionRecord (new case), TestStageTrackerSuppressedDecisionRecordKeepsStage, TestStageTrackerUnclassifiedClankerPROfflineCaption, TestStageTrackerHolderPresenceJS (node). Docs: dashboard-sections.md, dashboard-copy-inventory.md; changelog fragment.

A contributor PR whose stage labels the write-back gate kept off GitHub
(fork PR, no opt-in label) was read by the tracker as an unclassified
"PR in progress Β· @x's clanker" even while the stage engine held it at
085: stageTrackerStaleDecisionRecord took the missing park label as a
lifted park and dropped the record. The reconciler now notes
labels_suppressed on the record and the tracker trusts such a record.

An unclassified clanker PR carries its author's presence; when the
clanker is offline the chevron reads "Β· @x's clanker Β· β–  offline 3h" and
the caption names the next automatic step (a green PR is reviewed and
merged without its author; adoption only once returned and unpushed for
adoption.after_offline). Human PRs unchanged, never adopted.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15521 🌱 refactor: split tracker row source same files src/pkg/dashboard/static-src/js/tracker-row.js
#15591 πŸ› adoption: superseded PRs close promptly and read as one muted tracker line same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static-src/js/tracker-words.js
src/pkg/dashboard/static/index.html
#15574 🌱 dashboard: split stage_tracker.go into 4 files CONFLICT src/pkg/dashboard/stage_tracker.go
#15565 🌱 refactor: split tracker words source same files src/pkg/dashboard/static-src/js/tracker-words.js
#15537 πŸ› fix: scope tracker link memo to the excluded PR same files src/pkg/dashboard/stage_tracker.go
#15526 🌱 dashboard: split stage_tracker.go into 4 files same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
#15530 πŸ› fix(dashboard): issue-row linked PR passes null when the lineage chip is empty same files src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html
#15595 ✨ deploy: headless Twitch streamer for the Activity Monitor same files src/pkg/dashboard/static/index.html
#15584 πŸ› Close the hive's own empty-diff PRs as superseded instead of asking a person same files src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
src/pkg/stagelabels/store.go

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› adoption: offline clanker PRs don't stall at 'PR in progress'

1 participant