Repository navigation
π docs: document Matrix streaming and add inactive overlay - #15985
Conversation
e758a79
|
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
There was a problem hiding this comment.
Decision needed: @hanthor should decide whether the inactive hive-hosted-matrix streamer overlay (zero replicas, twitch-stream-matrix secret reference, public Twitch destination) may land in-tree now, ahead of channel provisioning and dashboard.matrix enablement.
Routing to a maintainer rather than judging this alone: it carries sentinel-alert, adds a deploy manifest that references a new credential, and its purpose is a public broadcast of code lines. The manifest itself checks out; the decision is whether this groundwork should exist in-tree yet.
What I verified against the base manifests at e758a79:
- Every JSON-patch path resolves to the intended field.
/spec/template/spec/containers/0/envFrom/1/secretRef/nameis thetwitch-streamref insrc/deploy/stream/k8s/deployment.yaml:37-38(index 0 is the ConfigMap, index 2 thedashboard-tokensecret, which is left as-is and must be provisioned in the new namespace β the doc's step 2 says exactly that)./spec/egress/1/to/0/namespaceSelector/...is the dashboard-namespace rule atnetworkpolicy.yaml:24-27, same path the existinghive-hostedoverlay patches. - Deployment
selector.matchLabels(deployment.yaml:14-16) and NetworkPolicypodSelector(networkpolicy.yaml:11-13) are both patched tohive-stream-matrix, and thelabelstransformer withincludeTemplates: truerelabels the pod template to match β so selectors stay consistent and the mainhive-streampods are not selected by the new policy. replicas: 0,STREAM_AUDIO=silent,view=matrix&sound=off,namespace: hive-stream-matrix,namePrefix: matrix-β all as the PR body describes. No Secret objects or key values anywhere in the diff.- The
hive-hostedoverlay is untouched, so the body's "byte-identical render" claim is consistent with the diff (I could not runkubectl kustomizehere, so I did not independently confirm the render).
Sentinel facts for the maintainer: author @thatguywob is not in OWNERS; the flagged paths are src/deploy/stream/README.md and the new overlay. The change adds capability that is inert until an owner creates the namespace, the twitch-stream-matrix secret, and scales up β those steps are documented as owner-only in src/docs/streaming-the-activity-monitor.md.
Unrelated to this diff: the red checks are test (dashboard 2/4), test (dashboard shuffle 2/3) and coverage, and the same jobs are red on #15984 β this PR changes no Go or JS, so that looks like a base-branch failure rather than something here.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@thatguywob the hive has adopted this PR ( |
|
CI triage β The red test is No repair will be pushed here. Once #15996 closes the shards need a re-run on this head, after which π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Add a silent, zero-replica Matrix streamer with a separate namespace, workload selectors and Twitch secret reference. Document public-content safeguards and owner-only activation. Hive-Run: hivecommons#15937 Hive-Plan: issue-15937-matrix-stream-documentation Hive-Spec: hivecommons#15937#acceptance-criteria Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
e758a79 to
ed40dd9
Compare
|
hive/awaiting-ci: rebased onto v5 (picks up #15997, which fixed the π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Correctness (delta re-review at ed40dd9) β the delta since e758a79 is a rebase onto v5; the PR's own four files are byte-identical between heads. Re-rendered overlays/hive-hosted-matrix with kubectl kustomize: replicas: 0, namespace hive-stream-matrix, matrix-hive-stream objects, selector/pod labels hive-stream-matrix, secretRef: twitch-stream-matrix, dashboard podSelector still hive, no Secret objects. No in-scope correctness issues.
One advisory, not blocking: src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:34 sets DASHBOARD_PATH=/?kiosk=1&view=matrix&sound=off as #15937 prescribes, but at this head nothing in static-src/js handles view=matrix, and src/docs/operator-reference/README.md:285 says the Matrix source is "buffered only; nothing reads it yet β¦ pending #15935". Scaling up before that lands would broadcast the plain kiosk Activity Monitor to hivecommonsmatrix. Suggest making the dependency explicit in the checklist (src/docs/streaming-the-activity-monitor.md:216):
1. Enable `dashboard.matrix` with an explicit, reviewed public repo allowlist
and verify the Matrix display and its author restriction and scrub/drop rules
before any broadcast. An empty allowlist captures nothing. Until the Matrix
display (#15935) has landed, `view=matrix` is ignored and the streamer would
show the ordinary kiosk Activity Monitor.
β hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Manifests are correct; one ordering dependency the body does not mention. Routing to an approver because this adds a deploy/infra manifest ( What I verified (rendered with
Finding (low, because
Info:
Read the diff and base tree first, then the body; the body's claims (isolated identity, zero replicas, silent, separate secret, main stream unchanged) all match the rendered output. I have not approved, merged, or closed anything. Review findings from Conclusion: the manifest and docs are correct as written; this is routed to an owner only because it adds a deploy manifest with a stream-key Secret reference (sentinel surface), and because of two sequencing questions below. I have not approved or closed anything. What I verified (v5 merge-base + this head
Two things an owner should weigh:
Minor (info): step 2 of the new doc section tells the owner to create namespace |
|
Needs a decision, not a merge:
Head: verdict requires_human @ed40dd9, 61/61 checks green, DCO yes, sentinel alert, soak 1m0s of 10m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
/lgtm Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hivecommons-hive[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Looks correct to me; the overlay renders as described and the existing stream is untouched.
What I verified (base v5 @ c766074, overlay from this head 8fc3e35):
- Rendered
kustomize build src/deploy/stream/overlays/hive-hosted-matrix: Namespacehive-stream-matrix; ConfigMap/Deployment/NetworkPolicy all namedmatrix-hive-streamin that namespace; Deploymentreplicas: 0; pod/selector labelapp.kubernetes.io/name: hive-stream-matrixon Deployment selector+template and NetworkPolicypodSelector;envFromβconfigMapRef: matrix-hive-stream,secretRef: twitch-stream-matrix,secretRef: dashboard-token;DASHBOARD_PATH=/?kiosk=1&view=matrix&sound=off,STREAM_AUDIO=silent. No Secret objects or values in the render. - The JSON-patch indices are right against the base:
k8s/deployment.yamlenvFrom[1]is thetwitch-streamsecretRef, andk8s/networkpolicy.yamlegress[1]is the dashboard rule β the patch leavesegress[1].to[0].podSelectoratapp.kubernetes.io/name: hive, which is whyincludeSelectorswas correctly avoided (the comment in the overlay explains this). STREAM_AUDIO=silentis a supported value:src/deploy/stream/entrypoint.sh:50,85,141,202.k8s/andoverlays/hive-hosted/are not in the diff, so thehive-hostedrender is unchanged by construction.- The doc's config keys match
src/pkg/config/dashboard_matrix.go:14-16(enabled,repos,exclude_paths) and the "empty allowlist captures nothing" statement matches line 22.
One informational note for whoever sequences the #15862 children β at this base the dashboard does not yet understand view=matrix: src/pkg/dashboard/static-src/js/boot.js:38 parses kiosk, popout, display, density, shift, sound, theme only, and falls back to #section-activity-monitor-section. The Matrix display is in still-open #15984 (and the line source in #15977). So the doc's present-tense "It shows pushed added lines onlyβ¦" describes the post-#15984 state; if the owner scaled matrix-hive-stream up before that lands, the hivecommonsmatrix channel would broadcast the ordinary Activity Monitor kiosk. The path is what #15937 prescribes and replicas: 0 makes this latent, so I don't consider it a defect in this PR β just worth knowing when choosing merge order.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
merged by Hive on behalf of @clubanderson, who approved this head (operator-approval:clubanderson) with "Approve and let hive merge": author @thatguywob holds no trusted-author role; CI green at 8fc3e35. |
Closes #15937
Document Matrix streaming to the dedicated
twitch.tv/hivecommonsmatrixchannel and add an inactive overlay using the existing streamer base. It has zero replicas, silent audio, a separate namespace, prefixed workload names, isolated selectors and thetwitch-stream-matrixsecret reference. The existing Activity Monitor stream remains unchanged.The guide covers public repo allowlisting, positively identified hive authors, scrub-touched line dropping and owner-only provisioning and activation. No credentials are included and nothing was applied, deployed or activated.
Validation: rendered both overlays with
kubectl kustomize; inspected the Matrix render for zero replicas, separate identities/selectors, the dedicated secret reference, silent audio, and no Secret objects or values. The dashboard egress selector still targetshive. Compared the existinghive-hostedrender before and after withcmp: byte-identical. No existing streamer manifest test was found; this uses the issue's render-comparison check. Repository test suites are left to CI per AGENTS.md; the stream-image PR gate is triggered by these paths.@hanthor: this implements the documentation and inactive streamer configuration scoped by #15937, part of RFC #15862. Source delivery is separate from deployment/activation, which remain owner-only. After merge, a completion comment should notify @hanthor with the merge link and that distinction.
β hive: backend=codex
π Hive Agent:
contributor| SHA:e758a793e