Skip to content

πŸ› fix(dashboard): share tracker row pill assembly; fix shrink-priority comment - #15478

Merged
hivecommons-hive[bot] merged 7 commits into
v5from
scanner/fix-15447
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 7 commits into
v5from
scanner/fix-15447

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #15447
Closes #15451

Why

The tracker.css comment contradicted the CSS and the intended behaviour (#15441): the lineage chip (flex-shrink 2) gives way before the title (1). Comment fixed; flex-shrink values untouched.

The sub-row and single-covering-PR issue row each hand-built the PR link β†’ lineage β†’ base-pill string in the same order (asserted by a test). It now lives in one helper, stageTrackerPRPillsHtml, with identical output. static/index.html regenerated via the webstatic generator.

Not run locally; CI is the verdict.

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…y comment

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15521 🌱 refactor: split tracker row source CONFLICT src/pkg/dashboard/static-src/js/tracker-row.js
#15425 πŸ› fix: identify tracker claims from the local ledger same files src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html
#15473 πŸ› dashboard: Merged counter is an odometer at rest and the pill bee is 28 px same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
The node fixtures slice individual functions out of index.html; the new
shared pill helper must be included wherever stageTrackerSubRowHtml is.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read tracker-row.js at the merge-base and at ab6d7dd; looks correct to me β€” the refactor is behaviour-preserving.

What I verified

  • Both call sites produce byte-identical output through stageTrackerPRPillsHtml (static-src/js/tracker-row.js:991), including the edge case where stageTrackerLineageChipHtml returns '' for a truthy lp.lineage: the old single-covering-PR branch emitted ' ' + '', and the new helper does the same because '' == null is false. The sub-row passes lineage || null, so its old if (lineage) guard is preserved.
  • The corrected tracker.css:110-112 comment now matches the rules below it: .ham-lineage/.ham-adopted-from are flex: 0 2 auto (line 116), .ham-pr-ref/.ham-pr-line are flex: 0 1 auto (line 118), .ham-badge/.ham-linked-ico are 0 0 auto (line 115).
  • Ran go run ./gen -src ../static-src -out ../static/index.html from pkg/dashboard/webstatic at the PR head: static/index.html is unchanged, so the committed generated file is in sync.
  • All four Go test harnesses that inline stageTrackerSubRowHtml also inline the new helper, so none will hit a ReferenceError.

Changelog fragment name follows fixed-<pr>-<slug>.md. No findings.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 060-reviewed β†’ 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read against v5: the helper is output-identical to the two hand-built strings it replaces.

  • Sub-row site (tracker-row.js:1023): old appended ' ' + lineage only when truthy; new passes lineage || null and the helper emits '' for null β€” same result for ''/undefined.
  • Single-covering-PR site (:1246): the ternary's falsy branch is now null instead of '', so a chip function returning '' still yields the same ' ' as before, and baseRef handling is unchanged.
  • CSS change at tracker.css:113-114 is comment-only; flex-shrink values untouched, matching the body's claim.
  • static/index.html diff contains exactly the same five hunks as the source, consistent with a regenerated bundle.

Sequencing note: #15521 splits tracker-row.js and moves both of these hunks into tracker-row-layout.js. The two PRs are not duplicates (different intent, different content) but they will not both apply cleanly; #15521's body already says it waits for this one, which is the right order β€” this is the smaller, behaviour-preserving change.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read against the v5 tree, looks correct to me β€” the helper is output-identical to both inline sequences it replaces.

  • static-src/js/tracker-row.js:1009-1011 β€” stageTrackerPRPillsHtml(ref, lineage, baseRef) emits ' ' + lineage only when lineage != null. The sub-row call (:1023) passes lineage || null, so a falsy chip still contributes nothing, as if (lineage) ref += ' ' + lineage did. The single-covering-PR call (:1246) passes null when lp.lineage is falsy and the raw chip string otherwise, so an empty-string chip still yields the same trailing space the old ' ' + stageTrackerLineageChipHtml(...) produced. Both branches are byte-for-byte unchanged.
  • static-src/css/tracker.css:118 has .ham-lineage { flex: 0 2 auto } and :120 has .ham-pr-ref { flex: 0 1 auto }, so the corrected comment ("lineage chip gives way first (2), then the title (1)") now describes the CSS; no values were touched.
  • The four Go harnesses (stage_tracker_motion_test.go, _repo_grouping_test.go, _ui_test.go) extract the new function into the JS prelude, so the existing order assertion keeps running against the shared helper.

One note for sequencing, not a defect: #15521 (split tracker-row.js into four files) removes the lines this PR edits, and its body already says it waits for this one. Landing this first is the right order.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit ce13a25 into v5 Oct 29, 2026
78 of 80 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15447 branch October 29, 2026 21:12
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#15478fbf46e4` sha256:312acd95706e0e6ca56d283a3f0b451f0281de293f7888413e766a9e9141e83d β€” download from the dashboard or `hivectl review evidence #15478`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

0 participants