Skip to content

πŸ› tracker: reporter-trust hold reads 'Triage needed' - #15468

Merged
clubanderson merged 6 commits into
v5from
fix/triage-needed-reporter-hold
Oct 29, 2026
Merged

clubanderson merged 6 commits into
v5from
fix/triage-needed-reporter-hold

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Fixes #15466

What

On hive's hive, #15437–#15440 (reporter not in reporter_trust.trusted_associations) sat in the Activity Monitor's Open column as ✦ New Β· since 28m πŸ‘€; the ask β€” a maintainer's triage β€” lived only in the caption. The owner asked for "triage needed" in the Open column.

Before After
Open column reading New Β· since 28m on the two reporter-trust-held issues Open column reading Triage needed Β· since 28m on the same rows, Accept triage inline

Changes

Caption (owner follow-up) β€” the 015 caption appended the lane reason (triage needed: carries needs-triage) after "waiting for triage", saying triage three times next to a chevron already reading Triage needed. Every held row (015 and the 000-new hold) now carries exactly Triage needed β€” accept or close (stageTrackerTriageNeededCaption, used by stageTrackerCaption and stageTrackerNewState); the next-mover / next-pass narration and the gate list stay on the chevron hover; the raw lane reason stays on reason.

Tracker (display)

  • stage_tracker_new.go: applyStageTrackerNew stamps the needs-triage modifier when the 000-new state's triage gate is next (StageTrackerNew.TriagePending()), so a reporter-trust hold carries the same modifier the needs-triage label yields β€” before the label has landed.
  • tracker-row.js: new pure stageTrackerOpenTriageNeeded(item) (issue at stage 0 with the needs-triage modifier, or new.next_mover: maintainer with the triage gate next). The Open chevron word and its hover prefix read Triage needed instead of New; tracker-words.js stageTrackerHeadline agrees. Blue ✦ ham-open-new tint kept; the caption / "Next: …" / gates hover unchanged.
  • The inline Accept triage lead (✨ tracker: show the row's lead action inlineΒ #15457) already fires on this row (TestStageTrackerMaintainerRowsHaveLeadAction uses this exact fixture) β€” confirmed in the after screenshot.

Label (source of truth) β€” no change needed, verified live: markReporterTrustAwaiting (reporter_trust_wait.go, called from fetchIssues) already adds needs-triage with the wait notice, issueUntriaged derives stage/015-triage-needed from the reporter_triage bucket, and clearReporterTrustAwaiting / the 015 settle path remove it once triage/accepted is on. #15437/#15438 now carry both needs-triage and stage/015-triage-needed. The gap was only the window between the gate's decision and those passes, which the display fix covers. (The wait notice is budgeted per poll β€” DefaultReporterTrustWaitMaxNotices β€” so a burst of held issues can widen that window; the row reads Triage needed regardless.)

Docs: dashboard-sections.md (Open-column words + 000-new section), dashboard-copy-inventory.md, operator-reference.md reporter-trust row.

Tests

  • TestStageTracker_ReporterTrustHoldReadsTriageNeeded β€” fixture mirroring the live JSON (NonActionableIssues, bucket reporter_triage, no labels) β†’ modifiers: [needs-triage], new.TriagePending(), caption keeps the next-pass text.
  • TestWebhookOpenedItemInsertedIntoTracker β€” held row carries the modifier; admitted reporter's row does not.
  • TestStageTrackerNewRowRendering (node) β€” chevron Triage needed Β· since 8m, hover prefix, headline; label case reads the same; admitted-reporter row still reads New.

An issue the reporter-trust gate holds for a maintainer sat in the Open
column as 'New Β· since 28m' with the ask only in the caption
(#15437–#15440, labels not yet written). The 000-new
state now stamps the needs-triage modifier when its triage gate is next,
and the Open chevron / headline / chevron hover read 'Triage needed' for
that row and for the needs-triage pill alike, so the word, colour and the
inline Accept triage lead match the label case.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible β€” a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking β€”
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly β€” that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15508 πŸ› fix: scope tracker link memo to the excluded PR same files src/pkg/dashboard/stage_tracker.go
#15405 πŸ› fix: require verified signature for email-only hive commit identity match same files src/docs/operator-reference.md
#15478 πŸ› fix(dashboard): share tracker row pill assembly; fix shrink-priority comment same files src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html
#15473 πŸ› dashboard: Merged counter is an odometer at rest and the pill bee is 28 px same files src/pkg/dashboard/static/index.html
#15506 πŸ› dispatch: never open a second PR for an issue that already has one same files src/docs/operator-reference.md
#15471 πŸ› fix(hotspot): stop proposing source splits for generated files whose source is already split same files src/docs/operator-reference.md
#15497 πŸ“– docs: monitoring a hive with Prometheus and Grafana same files src/docs/operator-reference.md
#15425 πŸ› fix: identify tracker claims from the local ledger same files src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html
#15485 ✨ auto-merge: breaking-titled or needs-owner-merge PRs wait for a human same files src/docs/dashboard-copy-inventory.md
src/docs/dashboard-sections.md
src/docs/operator-reference.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/stage_tracker_new.go
src/pkg/dashboard/static-src/js/tracker-words.js
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 050-review-pending: required-check-pending:build-and-test

The 015 caption appended the lane reason ('triage needed: carries
needs-triage') after 'waiting for triage', saying triage three times
beside a chevron that already reads Triage needed. Every reporter-trust
held row (015 and the 000-new hold) now carries exactly
'Triage needed β€” accept or close'; the next-mover / next-pass narration
stays on the chevron hover. Changelog fragment moved to the repository
root where the guard reads it.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • changelog-fragment-guard

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (intent-alignment, head 29fd8d7) β€” the diff satisfies #15466: applyStageTrackerNew stamps needs-triage when the triage gate is next (src/pkg/dashboard/stage_tracker_new.go:212-217), stageTrackerOpenTriageNeeded turns the chevron word/hover/headline into Triage needed (tracker-row.js:80-85, 252-260; tracker-words.js:465), and the next-pass narration survives on the chevron hover (stage_tracker_new_test.go asserts next hive pass in 7m on the tip). The raw lane reason still lands on it.Reason (stage_tracker.go:2024) after the 015 caption stops repeating it.

One description/diff gap, non-blocking: the PR body's Tests bullet says TestStageTracker_ReporterTrustHoldReadsTriageNeeded checks that the "caption keeps the next-pass text", but the caption is now the fixed Triage needed β€” accept or close (stage_tracker_new.go:150-151) and the test asserts it.New.NextPassInSeconds, not caption text. Suggest rewording the bullet to "next pass stays on new / the hover" so the body matches what landed.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read against the tree at 341bac4. Looks correct to me; nothing blocking.

What I verified:

  • Server and SPA agree on "triage pending". Go decides it once at src/pkg/dashboard/stage_tracker_new.go:107 (issue && !triageAccepted && (reporter-triage bucket || needs-triage modifier)), uses it for the caption at :152, and TriagePending() (:220-231) re-derives it from the emitted gates (triage = next, mover = maintainer). stageTrackerOpenTriageNeeded in tracker-row.js:252-261 reads exactly those two fields plus the needs-triage modifier, so the chevron word and the caption cannot disagree for a given payload.
  • Modifier injection is idempotent and ordered. applyStageTrackerNew (stage_tracker_new.go:212-217) guards with slices.Contains and re-sorts with the same slices.Index(stageTrackerModifierOrder, …) comparator already used at stage_tracker.go:1142, so the payload order matches the documented precedence.
  • Precedence in the chevron is preserved. In tracker-row.js:78-85 and tracker-words.js:462, hold / blocked / advisory / draft still win over the new Triage needed, which only displaces New.
  • go build ./pkg/dashboard/ ./pkg/stageengine/... and the webstatic/gen … -check staleness gate both pass on this head.

One edge I noticed but did not treat as a defect: once triage is accepted but the needs-triage label has not yet been removed, the SPA still says Triage needed (from the modifier) while Go's triagePending is already false. The pill said the same thing before this PR, so it is pre-existing and self-heals on the next label pass.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 060-reviewed β†’ 050-review-pending: required-check-pending:build-and-test

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the branch conflicts with the base and needs a rebase

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reporter-trust hold shows 'New' instead of 'Triage needed' in the Open column

1 participant