Repository navigation
π tracker: reporter-trust hold reads 'Triage needed' - #15468
Conversation
An issue the reporter-trust gate holds for a maintainer sat in the Open column as 'New Β· since 28m' with the ask only in the caption (#15437β#15440, labels not yet written). The 000-new state now stamps the needs-triage modifier when its triage gate is next, and the Open chevron / headline / chevron hover read 'Triage needed' for that row and for the needs-triage pill alike, so the word, colour and the inline Accept triage lead match the label case. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
stage 080-awaiting-merge-admission β 050-review-pending: required-check-pending:build-and-test |
The 015 caption appended the lane reason ('triage needed: carries
needs-triage') after 'waiting for triage', saying triage three times
beside a chevron that already reads Triage needed. Every reporter-trust
held row (015 and the 000-new hold) now carries exactly
'Triage needed β accept or close'; the next-mover / next-pass narration
stays on the chevron hover. Changelog fragment moved to the repository
root where the guard reads it.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
There was a problem hiding this comment.
Reviewed (intent-alignment, head 29fd8d7) β the diff satisfies #15466: applyStageTrackerNew stamps needs-triage when the triage gate is next (src/pkg/dashboard/stage_tracker_new.go:212-217), stageTrackerOpenTriageNeeded turns the chevron word/hover/headline into Triage needed (tracker-row.js:80-85, 252-260; tracker-words.js:465), and the next-pass narration survives on the chevron hover (stage_tracker_new_test.go asserts next hive pass in 7m on the tip). The raw lane reason still lands on it.Reason (stage_tracker.go:2024) after the 015 caption stops repeating it.
One description/diff gap, non-blocking: the PR body's Tests bullet says TestStageTracker_ReporterTrustHoldReadsTriageNeeded checks that the "caption keeps the next-pass text", but the caption is now the fixed Triage needed β accept or close (stage_tracker_new.go:150-151) and the test asserts it.New.NextPassInSeconds, not caption text. Suggest rewording the bullet to "next pass stays on new / the hover" so the body matches what landed.
β hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission β 050-review-pending: required-check-pending:build-and-test |
There was a problem hiding this comment.
Read against the tree at 341bac4. Looks correct to me; nothing blocking.
What I verified:
- Server and SPA agree on "triage pending". Go decides it once at
src/pkg/dashboard/stage_tracker_new.go:107(issue && !triageAccepted && (reporter-triage bucket || needs-triage modifier)), uses it for the caption at:152, andTriagePending()(:220-231) re-derives it from the emitted gates (triage= next, mover = maintainer).stageTrackerOpenTriageNeededintracker-row.js:252-261reads exactly those two fields plus theneeds-triagemodifier, so the chevron word and the caption cannot disagree for a given payload. - Modifier injection is idempotent and ordered.
applyStageTrackerNew(stage_tracker_new.go:212-217) guards withslices.Containsand re-sorts with the sameslices.Index(stageTrackerModifierOrder, β¦)comparator already used atstage_tracker.go:1142, so the payload order matches the documented precedence. - Precedence in the chevron is preserved. In
tracker-row.js:78-85andtracker-words.js:462, hold / blocked / advisory / draft still win over the newTriage needed, which only displacesNew. go build ./pkg/dashboard/ ./pkg/stageengine/...and thewebstatic/gen β¦ -checkstaleness gate both pass on this head.
One edge I noticed but did not treat as a defect: once triage is accepted but the needs-triage label has not yet been removed, the SPA still says Triage needed (from the modifier) while Go's triagePending is already false. The pill said the same thing before this PR, so it is pre-existing and self-heals on the next label pass.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 060-reviewed β 050-review-pending: required-check-pending:build-and-test |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
@clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Fixes #15466
What
On hive's hive, #15437β#15440 (reporter not in
reporter_trust.trusted_associations) sat in the Activity Monitor's Open column as β¦ New Β· since 28m π€; the ask β a maintainer's triage β lived only in the caption. The owner asked for "triage needed" in the Open column.Changes
Caption (owner follow-up) β the 015 caption appended the lane reason (
triage needed: carries needs-triage) after "waiting for triage", saying triage three times next to a chevron already reading Triage needed. Every held row (015 and the 000-new hold) now carries exactly Triage needed β accept or close (stageTrackerTriageNeededCaption, used bystageTrackerCaptionandstageTrackerNewState); the next-mover / next-pass narration and the gate list stay on the chevron hover; the raw lane reason stays onreason.Tracker (display)
stage_tracker_new.go:applyStageTrackerNewstamps theneeds-triagemodifier when the 000-new state's triage gate is next (StageTrackerNew.TriagePending()), so a reporter-trust hold carries the same modifier theneeds-triagelabel yields β before the label has landed.tracker-row.js: new purestageTrackerOpenTriageNeeded(item)(issue at stage 0 with theneeds-triagemodifier, ornew.next_mover: maintainerwith the triage gate next). The Open chevron word and its hover prefix read Triage needed instead of New;tracker-words.jsstageTrackerHeadlineagrees. Blue β¦ham-open-newtint kept; the caption / "Next: β¦" / gates hover unchanged.TestStageTrackerMaintainerRowsHaveLeadActionuses this exact fixture) β confirmed in the after screenshot.Label (source of truth) β no change needed, verified live:
markReporterTrustAwaiting(reporter_trust_wait.go, called fromfetchIssues) already addsneeds-triagewith the wait notice,issueUntriagedderivesstage/015-triage-neededfrom thereporter_triagebucket, andclearReporterTrustAwaiting/ the 015 settle path remove it oncetriage/acceptedis on. #15437/#15438 now carry bothneeds-triageandstage/015-triage-needed. The gap was only the window between the gate's decision and those passes, which the display fix covers. (The wait notice is budgeted per poll βDefaultReporterTrustWaitMaxNoticesβ so a burst of held issues can widen that window; the row reads Triage needed regardless.)Docs:
dashboard-sections.md(Open-column words + 000-new section),dashboard-copy-inventory.md,operator-reference.mdreporter-trust row.Tests
TestStageTracker_ReporterTrustHoldReadsTriageNeededβ fixture mirroring the live JSON (NonActionableIssues, bucketreporter_triage, no labels) βmodifiers: [needs-triage],new.TriagePending(), caption keeps the next-pass text.TestWebhookOpenedItemInsertedIntoTrackerβ held row carries the modifier; admitted reporter's row does not.TestStageTrackerNewRowRendering(node) β chevronTriage needed Β· since 8m, hover prefix, headline; label case reads the same; admitted-reporter row still readsNew.