Repository navigation
Conversation
…s 28 px hivecommons#15409 only sized the flying celebration glyph and animated the roll, so the pill still showed a 12 px hexagon and plain 12 px bold text between merges. Style .ham-merged-n as a mechanical odometer at rest (dark inset drum, per-digit dividers, monospace tabular digits at --fs-xl, roller gradient, light-mode variant), enlarge .ham-merged-ico to 28 px, and grow the sticky bar height so the column header still sticks below it. The day/week line keeps its size. static/index.html is regenerated from static-src. Hive-Run: hivecommons#15469 Hive-Plan: merged counter odometer look at rest Hive-Spec: merged-counter-odometer#at-rest Signed-off-by: SACHIN NAIK <sachin.naik@ibm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@odttlnt this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
stage 080-awaiting-merge-admission → 072-returned-to-contributor: check-failing:coverage |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #15473 is closed in favour of #15470 — both fix #15469 and rewrite the same .ham-merged-n / --ham-sticky-bar-h rules in tracker.css, so they conflict rather than stack.
This appears to duplicate #15470, which fixes the same issue (#15469) and edits the same rules in src/pkg/dashboard/static-src/css/tracker.css (#activity-monitor-section { --ham-sticky-bar-h }, .ham-merged-count .ham-merged-ico, .ham-merged-count .ham-merged-n, .ham-merged-count .ham-merged-n .ham-odo). I read both diffs in full.
They are not interchangeable:
- #15473 is CSS-only paint over the existing plain text (sticky bar 40 px; the 900 ms
.ham-odooverlay is unchanged). - #15470 replaces the overlay with a persistent per-digit drum in
tracker-merged.js(stageTrackerOdometerRest/Draw, sticky bar 42 px) plus node tests for the at-rest state. It is the broader fix and it is the issue reporter's own PR.
Whichever lands second will conflict on those lines, so one should be closed. I have not closed anything.
This head also fails CI on its own diff — test (dashboard 1/4), TestStageTrackerCuesWiring:
src/pkg/dashboard/stage_tracker_cues_test.go:101rejects any literal colour (#0–#f,rgb(,rgba(,hsl() inside the tracker-cues CSS block ofstatic/index.html. The new.ham-merged-nrules use#000,#64748bandrgba(0, 0, 0, …)/rgba(15, 23, 42, …)(tracker.css:447-451in this head). Log:tracker-cues CSS must use tokens only, found "#0" / "#6" / "rgba(".- The
"#1"hit comes from the CSS commenthivecommons/hive#15469ontracker.css:448— the check is a plain substring match, so even after tokenising the colours this comment would still fail it.
Minor: the body says "no thousands separator" — the value is written via stageTrackerOdometerSet(n, shown) → String(text) (tracker-merged.js:533), so there never was one; a CSS change cannot affect it either way.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Check report (hive scanner, comment-only — head lives in a fork):
🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hive-base-moved: — hive: backend=bob model=premium |
|
@odttlnt the hive has adopted this PR ( |
|
Supersede failed: the hive could not open a fresh PR with these commits. Merging Files changed on both sides:
Rebase this branch onto |
Fixes #15469
Problem
#15409 sized the flying celebration glyph and animated the roll, but at rest the Activity Monitor pill still showed a 12 px hexagon (
.ham-merged-ico) and plain 12 px bold text (.ham-merged-n): there was only an odometer motion, never an odometer look.Change (CSS only,
static-src/css/tracker.css;static/index.htmlregenerated by concatenating the manifest, byte-identical tomake dashboard-gen).ham-merged-n: dark inset drum (--surface-3-based) with top/bottom inner shadow, thin per-digit dividers drawn at the cell width (1ch+ letter spacing), monospace tabular digits at--fs-xl(≥ 18 px), a roller gradient overlay (::after), no thousands separator, plus abody.light-modevariant..ham-merged-ico: 28 px;--ham-sticky-bar-h34 → 40 px so the pill and the sticky column header fit..ham-odo) keeps working over the new drum; the roll itself, carry behaviour and reduced-motion handling are unchanged.108 today · 934 this weekkeeps its size.TestStageTrackerMergedOdometerAtRestand a changelog fragment.Not run locally (no Go toolchain on this host; per AGENTS.md CI is the verdict).
— hive: backend=bob model=premium