Skip to content

✨ tracker: accept triage for every selected issue at once - #15477

Merged
clubanderson merged 1 commit into
v5from
feat/bulk-accept-triage
Oct 29, 2026
Merged

clubanderson merged 1 commit into
v5from
feat/bulk-accept-triage

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15475

Summary

Owner report (spoke tracker, 2026-10-29): four issues at Triage needed were multi-selected, but the bulk ⋯ menu only offered Decide… / Let hive decide / Hold / Release hold / Re-evaluate now / Mark needs-human… / Copy links — no way to accept triage for all of them at once.

This PR adds Accept triage as a selection-level action:

  • Selection bar: when every selected row is triage-eligible it is the lead button (ham-lead-act), otherwise a regular chip.
  • Bulk ⋯ / right-click / Shift+F10 menu: Accept triage (N selected) when all rows are eligible, Accept triage (k of N) for mixed selections with the hint "skips the M not waiting on triage". Not offered when no selected row is eligible.
  • Ineligible rows (PRs, rows not at Triage needed) are skipped; eligible rows go through the existing per-item POST /api/repos/{owner}/{repo}/items/{n}/accept-triage endpoint sequentially via stageTrackerRunActions — the same pattern Hold / Re-evaluate already use. No batch endpoint added, no new direct GitHub write paths; label application stays behind the existing gated path.
  • Each row gets the existing busy-chevron → "Accepted · moving to Actionable" transition; one summary in-app toast "Accepted N issues" (with "Accepted k of N issues. Failed: …" on partial failure).
  • Disabled with the row's reason when the viewer lacks triage permission.

Before / after

Before — bulk menu and selection bar for four "Triage needed" issues:

before: bulk menu with no Accept triage

After — Accept triage (4 selected) leads both the selection bar and the bulk menu:

after: Accept triage (4 selected) in the selection bar and bulk menu

Tests

  • TestStageTrackerBulkAcceptTriage (node harness): all-eligible lead/label/count and selbar markup, menu order, mixed "2 of 4" + hint, not offered when none eligible, disabled with reason, runRowAction posts only eligible rows in order, summary toast, nothing-eligible warning toast.
  • Updated expectation in stage_tracker_accept_triage_test.go for the new multi-item summary wording.
  • go generate ./pkg/dashboard/... run; static/index.html committed (TestIndexHTMLIsGenerated).

Docs

  • src/docs/dashboard-sections.md, src/docs/dashboard-copy-inventory.md
  • changelog.d/added-tracker-bulk-accept-triage.md

Selecting several "Triage needed" issues now offers Accept triage in
the selection bar (lead button when all rows are eligible) and in the
bulk ⋯ / context menu as "Accept triage (N selected)" or
"Accept triage (k of N)" for mixed selections. Ineligible rows are
skipped; eligible rows run through the existing per-item accept-triage
endpoint sequentially, with one summary toast "Accepted N issues".

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15400 🐛 fix: keep merge queue position visible during sweeps same files src/pkg/dashboard/static/index.html
#15470 🐛 dashboard: Merged counter is an odometer at rest, bee at full size same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15478 🐛 fix(dashboard): share tracker row pill assembly; fix shrink-priority comment same files src/pkg/dashboard/static/index.html
#15468 🐛 tracker: reporter-trust hold reads 'Triage needed' same files src/docs/dashboard-copy-inventory.md
src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker_accept_triage_test.go
src/pkg/dashboard/static/index.html
#15473 🐛 dashboard: Merged counter is an odometer at rest and the pill bee is 28 px same files src/pkg/dashboard/static/index.html
#15425 🐛 fix: identify tracker claims from the local ledger same files src/pkg/dashboard/static/index.html

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tracker: no bulk Accept triage — four selected "Triage needed" issues must be accepted one at a time

1 participant