Repository navigation
π dashboard: Merged counter is an odometer at rest, bee at full size - #15470
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission β 071-needs-author: optional-check-failing:test (dashboard shuffle 3/3) |
|
CI triage for head 2bc4408 (PR-local;
π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
#15409 enlarged the flying .cue-flight glyph, not the pill's .ham-merged-ico (12px), and drew the roll as a 900ms .ham-odo overlay over plain --fs-sm text, so at rest the Merged pill was a small hexagon and a bold number. The counter is now a persistent drum (one .ham-odo-col wheel per digit in a dark inset cell with a roller gradient, inner shadows and hairline dividers; monospace tabular 18px digits; no thousands separator) that only the changed wheels roll through, the pill's bee is 28px with the pill and sticky bar grown to fit, reduced motion swaps instantly, and the day/week line rolls through the same columns drawn plain. Signed-off-by: Andrew Anderson <andy@clubanderson.com> Fixes #15469 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
2bc4408 to
bb4fda7
Compare
There was a problem hiding this comment.
Read the diff against v5 and the callers of .ham-merged-n. Looks correct to me:
- The only consumers of the counter's value read
data-odo-value(tracker-merged.js:529), thearia-liveregion is written separately (:541), and the tests build their own nodes β so replacing the element's plain text with the persistent.ham-ododrum instageTrackerOdometerDrawbreaks no reader.role="img"+aria-labelon the element keeps the screen-reader value intact. - The new CSS stays inside the tokens-only rule at
stage_tracker_cues_test.go:101(color-mix(... black ...)keywords, no hex/rgba literals), which is the exact check that fails on the alternative PR.
Heads-up: #15473 fixes the same issue (#15469) by CSS-only paint over the same tracker.css rules (--ham-sticky-bar-h 40 px vs 42 px here, .ham-merged-ico, .ham-merged-n). They conflict rather than stack; I have left a note there recommending it be closed in favour of this one.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Signed-off-by: SACHIN NAIK <sachin.naik@ibm.com> hivecommons#15470 landed the same fix for hivecommons#15469 on v5; take its implementation.
Fixes #15469 (follow-up to #15398 / #15409).
Cause
#15409 is in the build, but it never changed what the Merged pill looks like at rest:
.cue-flightvia--cue-flight-size), not the pill's own.ham-merged-ico, which stayed12px Γ 12px.stageTrackerOdometerSetappended an absolutely-positioned, aria-hidden.ham-odooverlay for ~900 ms over the plain--fs-sm(12 px) bold text and then removed it. Between merges.ham-merged-nwas plain text β no cells, dividers or drum. The roll existed; the look never did.{text}, so most of the number was still plain text.Same element in both cases (
#activity-monitor-mergedin the sticky header bar); there is no sidebar instance.Fix
.ham-merged-nis now a persistent drum: one.ham-odo-colwheel per digit, dark inset cell (--surface-0β--surface-3roller gradient, top/bottom inner shadows, hairline dividers), monospace tabular digits at--ham-odo-digit: 18px, no thousands separator; light-mode variant underbody.light-mode. Value exposed viadata-odo-value+aria-label..ham-odo-rolland roll vertically through the intermediate digits (ease-out, 900 ms; carries roll too); the drum is redrawn at rest afterwards.prefers-reduced-motionβ instant swap (transition: none)..ham-merged-icoβ--ham-merged-bee: 28px, vertically centred; pill grows to 34 px;--ham-sticky-bar-h34 β 42 px so the column header still sticks beneath the bar.108 today Β· 934 this weekkeeps its size (same wheel columns drawn plain).stageTrackerOdometerRest/Draw/Set) for every Merged render; ids/classes asserted by tests unchanged.Measured in the harness: chip 20 β 34 px, bee 12 β 28 px, digit font 12 β 18 px, drum cells 0 β 4; mid-roll 2 wheels rolling for 9539 β 9541; reduced motion: 0 roll classes, text swapped.
Screenshots
Before, at rest:
After, at rest (dark):
After, mid-roll (dark, 9539 β 9541):
After, at rest (light):
Tests / docs
TestStageTrackerOdometerNode(node harness): N drum cells for N digits at rest; a change putsham-odo-rollon the changed wheels only; carry roll; reduced-motion/instant swap;data-odo-value.TestStageTrackerCuesWiring: drum CSS tokens/selectors present in the generated page.src/docs/dashboard-sections.mdheader pill entry;changelog.d/fixed-merged-odometer-at-rest.md.