Skip to content

πŸ› dashboard: keep the topbar hamburger on-screen on phones - #15481

Merged
clubanderson merged 1 commit into
v5from
fix/topbar-hamburger-mobile
Oct 29, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/topbar-hamburger-mobile

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Fixes #15476

Root cause. #oc-drawer-toggle carried a desktop-era margin-left: -10px, but the chip only ever renders inside the ≀1024px drawer tier, where its parent .oc-topbar-left has overflow: hidden. The negative margin pulled the 40px circle 10px past the strip's left edge and the overflow clip cut it off β€” on an iPhone (390px) only the right part of the ≑ circle survived.

Fix.

  • Drop the negative margin (the topbar's own 12px padding is the inset now).
  • ≀360px (iPhone SE/mini class): the right strip's five icon chips don't fit next to ≑ + ACMM and the strip clips rather than wraps, so collapse the πŸ› and βš™ chips. Both stay reachable: feedback from the drawer and account menu, Settings from a new Settings entry in the account menu.
  • dashboard-mobile-shots.mjs gains a clipped-by-strip finding: any .oc-topbar .nav-chip whose box pokes outside an overflow:hidden|clip ancestor. On the pre-fix build at 390Γ—844 it reports 26 findings (all #oc-drawer-toggle, chip spans -10..30 but overflow:hidden ancestor … spans 0..70); on this branch, 0.
  • .ham-merged* odometer rules untouched (πŸ› dashboard: Merged counter is an odometer at rest, bee at full sizeΒ #15470); measured β€” the odometer is not what pushes the width.

Verified headless (Playwright/Chromium, iPhone UA, light + dark) β€” hamburger left edge / topbar padding, and right strip extents:

viewport ≑ before ≑ after right strip
320Γ—568 x=2 (clipped) x=12 πŸ›/βš™ hidden, 118..304 βœ“
375Γ—667 x=2 (clipped) x=12 100..359 βœ“
390Γ—844 x=2 (clipped) x=12 100..374 βœ“
430Γ—932 x=2 (clipped) x=12 140..414 βœ“
844Γ—390 / 667Γ—375 landscape x=2 (clipped) x=12 βœ“

ACMM L6 pill and avatar status ring unaffected at every width.

Screenshots (390Γ—844@3, light, iPhone UA):

Before β€” ≑ clipped by the left edge:

before: hamburger clipped at 390px

After:

after: hamburger fully visible at 390px

After at 320Γ—568 β€” πŸ›/βš™ collapsed into the account menu:

after: 320px with bug and settings chips collapsed

The drawer toggle carried a desktop-era margin-left:-10px, but it only
renders inside the <=1024px drawer tier where .oc-topbar-left clips
overflow, so the chip's left 10px were cut off on every phone. Drop the
margin. On <=360px screens collapse the bug/settings chips (both still
reachable from the account menu, which gains a Settings entry) so the
right strip never overflows either. Teach dashboard-mobile-shots.mjs to
report chips that poke outside an overflow-clipping strip.

Fixes #15476

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15480 πŸ› tracker: name the merged PR that closed an issue under a follow-up PR same files src/pkg/dashboard/static/index.html
#15425 πŸ› fix: identify tracker claims from the local ledger same files src/pkg/dashboard/static/index.html
#15470 πŸ› dashboard: Merged counter is an odometer at rest, bee at full size same files src/pkg/dashboard/static/index.html
#15473 πŸ› dashboard: Merged counter is an odometer at rest and the pill bee is 28 px same files src/pkg/dashboard/static/index.html
#15468 πŸ› tracker: reporter-trust hold reads 'Triage needed' same files src/pkg/dashboard/static/index.html
#15477 ✨ tracker: accept triage for every selected issue at once same files src/pkg/dashboard/static/index.html
#15478 πŸ› fix(dashboard): share tracker row pill assembly; fix shrink-priority comment same files src/pkg/dashboard/static/index.html
#15400 πŸ› fix: keep merge queue position visible during sweeps same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read topbar.css, responsive.css, topbar.html and the shimmy dispatcher at e79c993; looks correct to me.

What I verified

  • The root cause holds: .oc-topbar-left is overflow: hidden (static-src/css/topbar.css:17) and #oc-drawer-toggle is its first child (static-src/html/topbar.html:4), so the removed margin-left: -10px was indeed pulling the chip under the clip. Replacing it with flex: 0 0 auto also stops the chip shrinking next to the title.
  • #feedback-bug-btn and #oc-settings-btn (topbar.html:26,28) are the ids hidden at ≀360px; neither is role-gated anywhere in static-src/js/, so the new avatar-menu Settings entry does not expose anything the chip didn't already.
  • The new menu item's data-action="openConfigDialog" data-arg0="governor" is the same action/arg pair the chip itself uses, and the dispatcher at static-src/js/tooltips-dialogs.js:236 reads dataset.arg0 as the config type β€” so it opens the same dialog.
  • Regenerated static/index.html via go run ./gen -src ../static-src -out ../static/index.html at the PR head: unchanged, so the committed file is in sync.
  • navbar_chip_consistency_test.go asserts the ids/classes still present in topbar.html; nothing this PR touches is removed from the markup, only hidden by media query.

The clipped-by-strip scanner addition in dashboard-mobile-shots.mjs is reporting-only (exits 0 on findings), so it cannot turn CI red. No findings.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read this against the tree at e79c993, not just the diff. Looks correct to me.

Root cause is real. src/pkg/dashboard/static-src/css/topbar.css:17 sets overflow: hidden on .oc-topbar-left, and #oc-drawer-toggle (html/topbar.html:4) is a child of it, so the old margin-left: -10px did put the first 10px of the 40px circle outside the clip box. Dropping the margin is the right fix; flex: 0 0 auto just stops the chip shrinking.

Nothing lost at ≀360px. The new avatar-menu entry (html/topbar.html:68) carries the identical data-action="openConfigDialog" data-arg0="governor" as the chip it hides (html/topbar.html:28), and the drawer/menu Feedback paths already existed, so hiding #feedback-bug-btn / #oc-settings-btn removes no capability.

Generated file is in sync. go run ./pkg/dashboard/webstatic/gen -src pkg/dashboard/static-src -out pkg/dashboard/static/index.html -check exits 0 on this head.

Scan helper. The new clipped-by-strip branch in src/scripts/dashboard-mobile-shots.mjs:189-199 only uses round/pathFor/add that are already defined in that scope (lines 143/144/169), and breaks after the first clipping ancestor, so it reports once per chip.

Not a defect, just noting: the red Sign-off survives the squash / verify PR contents checks are not caused by this diff β€” the single commit carries a Signed-off-by trailer, and the verifier job is the pulled-image step in pr-verifier.yml.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit 3ef38e6 into v5 Oct 29, 2026
81 of 85 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/topbar-hamburger-mobile branch October 29, 2026 19:42
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dashboard: topbar hamburger (≑) is clipped off the left edge on phones

1 participant