Skip to content

Review backlog (security): Issue-row caller still passes '' instead of null when lineage chip is empty (carried over) #15523

Closed

Description

@hivecommons-hive

Blocked on PR #15478. This finding came from reviewing PR #15478 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15478.

PR: #15478 (#15478)
Perspective: security
Severity: info (P3)
Evidence: src/pkg/dashboard/static-src/js/tracker-row.js:1246 (

prRefs = [STAGE_TRACKER_LINKED_GLYPH + stageTrackerPRPillsHtml(stageTrackerPRRef(lp.number, lp.url, lp.author_kind || '', lp.author, lp.title, (lp.title ? lp.title + '\n' : '') + 'Author: ' + who + ' · ' + stageTrackerLinkedTip(item, lp.number, ctx)), lp.lineage && typeof stageTrackerLineageChipHtml === 'function' ? stageTrackerLineageChipHtml(lp, nowMs) : null, lp.base_ref)];
)
Finding: Issue-row caller still passes '' instead of null when lineage chip is empty (carried over)

Previous-head correctness nit is still present at dc495f4: src/pkg/dashboard/static-src/js/tracker-row.js:1246 passes stageTrackerLineageChipHtml(lp, nowMs) directly, and that helper returns '' (not null) at tracker-row.js:967 when there is no lineage text, so stageTrackerPRPillsHtml (tracker-row.js:1009) emits a trailing space. Cosmetic, pre-existing behaviour preserved by the refactor; no security impact.

Fingerprint: 2c6cb4bdefd285ddd30e44fc9a7a25441bf75f4342bc2fa16e39b75fc7b3b338

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #15451: both cite src/pkg/dashboard/static-src/js/tracker-row.js, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  5. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15478 is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @odttlnt (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  8. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @odttlnt released (lease revoked).

  9. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15478 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  10. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Already fixed on base v5 by #15529 (|| null coercion at the issue-row call site, with a regression test). Per the issue instructions, closing without a PR; #15636 closed as superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions