Repository navigation
π dispatch: never open a second PR for an issue that already has one - #15506
Conversation
A person filed an issue, the hive dispatched its own relay fixer nine seconds later, and the person's PR (Fixes #N) landed 45 s after that. The webhook stopped the ledger offering the issue but never told the fixer already at work, so it opened a second PR; the duplicate-fix sweep then read the relay login (no author/* label) as a person's and the L4 write-back gate refused its notice; the deployed train admitted both PRs, and the one-PR-per-issue hold on v5 staged the loser at 080 "Approved; waiting its turn". - contribute hub: an open PR covering an issue preempts in-flight contributor tasks on it (the author's own PR excepted), via the PR-claims webhook hook (onCovered). - duplicate-fix sweep: Client.SetRelayKnownFunc from the contributor registry; a registered relay's later PR is the hive's own for the gate, gets one superseded notice, and is left open (never closed). - stage engine: merge-train duplicate-of parks with the author (072/071/070, rank owned); the 07x pass neither nudges nor adopts a held duplicate; the sentence reads "superseded by #winner". - docs (hive-merge, operator-reference), changelog fragment, tests. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission β 071-needs-author: optional-check-failing:relative links and anchors resolve |
β¦tion Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
@clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission β 071-needs-author: conflicting |
β¦etry #15307 alongside duplicate hold) Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 0a0c86f. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15505
Incident (#15469): the owner filed an issue, hive dispatched its own relay fixer 9 s later, the owner's PR #15470 (
Fixes #15469) landed 45 s after that, and the fixer β never told β opened #15473 eight minutes later. Both sat in the contributor-lane merge train as "Approved; waiting its turn". The duplicate-fix sweep saw the pair at 19:28Z and wrote nothing: the relay login has noauthor/*label, so it was read as a person's PR and the L4 write-back gate suppressed the notice.Changes
PRClaimDelivery.CoveringClaims()+onCoveredon the PR-claims webhook hook βContributeWSHub.PreemptIssueCoveredByPR(repo, issue, pr, author): releases every in-flight contributor task on the covered issue (except a session whose GitHub account is the PR author) and reassigns, like a claim takeover.Client.SetRelayKnownFunc(wired fromcontributorRelayKnown, the contributor registry). A registered relay's later PR is the hive's own for the gate (notice no longer suppressed), gets one<!-- hive:duplicate-fix -->superseded comment, and is left open β never closed by the sweep (LaterRelayβ comment-only).ClassifyStagemapsmerge-train:duplicate-of#Wto 072/071/070 by author kind (rank owned) instead of 080; the 07x pass skips nudge/adoption for a held duplicate (mergeTrainDuplicateOf); sentence now "superseded by #W β β¦ close it or let the delegate decide". Tracker already renders theduplicate-of:<W>gate state as "Duplicate of #W Β· needs a pick" at any stage.hive-merge.md,operator-reference.md(dispatch guard section); changelog fragment.Tests
TestPreemptIssueCoveredByPR_*(hub: other-author PR releases + reassigns; own PR / other issue / nil untouched)TestPRClaimsHookTellsCoverHookOnlyForOpenCoveringDeliveryTestSweepDuplicateFixPRs_RelayLaterPRCommentedThroughGateNotClosed(L4 gate, one comment, idempotent) and_UnknownLoginSuppressedByGate(pins the pre-fix suppression)TestClassifyStageMergeTrainDuplicateParksWithAuthor,TestDuplicateHeldClankerPRParkedAt072WithoutNudgeOrAdoptiontime.Sleep;TestDirectWriteRatchetpasses (only// writeback:gatedwrites).go build ./... && go test ./pkg/github/... ./pkg/dashboard/... ./pkg/stageengine/... ./cmd/hive/... ./pkg/writeback/...green.