Skip to content

πŸ› fix(dashboard): omit empty lineage separator - #15529

Merged
clubanderson merged 2 commits into
hivecommons:v5from
Karibhou:codex/fix-15493
Oct 29, 2026
Merged

clubanderson merged 2 commits into
hivecommons:v5from
Karibhou:codex/fix-15493

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Normalize an empty lineage chip to null in the single-covering-PR issue row, avoiding an extra separator before the base pill. Keep the generated dashboard in sync and add a regression case for incomplete lineage.

Fixes #15493

Validation: git diff --check passed. Tests were not run locally in accordance with AGENTS.md; CI runs the dashboard tests.

β€” hive: backend=codex

Hive-Run: hivecommons#15493
Hive-Plan: issue-15493
Hive-Spec: issue-15493#empty-lineage
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • changelog-fragment-guard

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 072-returned-to-contributor: check-failing:changelog-fragment-guard

Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15556 ✨ dashboard: toast countdown progress bar same files src/pkg/dashboard/static/index.html
#15550 πŸ› Activity monitor: an adoption pair never asks a human to pick a PR same files src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html
#15521 🌱 refactor: split tracker row source same files src/pkg/dashboard/static-src/js/tracker-row.js
#15530 πŸ› fix(dashboard): issue-row linked PR passes null when the lineage chip is empty CONFLICT src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 060-reviewed: contributor-lane:claim-tier-untrusted

clubanderson added a commit that referenced this pull request Oct 29, 2026
Riders behind a stalled train head (#15529, #15530 behind untrusted-author
#15425) drew an active amber chevron with no visible words: the stalled
label was in the DOM but painted --yellow (.ham-queue-stalled) on the
amber .ham-seg.active fill. The text now inherits the chevron colour and
reads "Merge queue Β· stalled β€” waiting on #15425 (needs maintainer merge)
Β· 1h21m" (head row: "Merge queue Β· stalled β€” needs maintainer merge Β·
1h21m"), every head_state has words, and an unmapped merge_train.state
falls back to its humanised name plus place instead of an empty string.

Ratchets: node test over every train state x stalled x head_state x
place asserts non-empty, slug-free chevron words; Go test asserts every
emitted merge_train carries a documented state/head_state.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
clubanderson added a commit that referenced this pull request Oct 29, 2026
…o train (#15553)

The Activity Monitor's train header read 'merge train Β· 3 PRs Β· 1st: #15425'
over one row: #15529 and #15530 were drawn as sub-rows of their linked
issues (nested_under), which the header grouping did not see. An issue row
now rides its open PR's train (key, contiguity, rail, merge order), the
header counts the rows drawn under it and names members the view hides,
and the payload carries merge_train.members.

#15425 fronted that train although it waits for a maintainer (untrusted
author): the lane's admission verdicts were not blocking for the planner.
A head whose last lane verdict maps to a human_merge_reason other than the
catch-all policy is now no train member at all; verdicts are keyed per lane
so another lane's opinion never evicts a member.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @1cce83c, 57/57 checks green, DCO yes, soak 30m0s elapsed. Blocked only by role/contributor (below require_tiers).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (correctness): Issue-row caller still passes '' (not null) when the lineage chip renders empty, leaving a pre-existing trailing space

2 participants