Repository navigation
π fix(dashboard): omit empty lineage separator - #15529
Conversation
Hive-Run: hivecommons#15493 Hive-Plan: issue-15493 Hive-Spec: issue-15493#empty-lineage Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
stage 080-awaiting-merge-admission β 072-returned-to-contributor: check-failing:changelog-fragment-guard |
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
stage 080-awaiting-merge-admission β 060-reviewed: contributor-lane:claim-tier-untrusted |
Riders behind a stalled train head (#15529, #15530 behind untrusted-author #15425) drew an active amber chevron with no visible words: the stalled label was in the DOM but painted --yellow (.ham-queue-stalled) on the amber .ham-seg.active fill. The text now inherits the chevron colour and reads "Merge queue Β· stalled β waiting on #15425 (needs maintainer merge) Β· 1h21m" (head row: "Merge queue Β· stalled β needs maintainer merge Β· 1h21m"), every head_state has words, and an unmapped merge_train.state falls back to its humanised name plus place instead of an empty string. Ratchets: node test over every train state x stalled x head_state x place asserts non-empty, slug-free chevron words; Go test asserts every emitted merge_train carries a documented state/head_state. Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
β¦o train (#15553) The Activity Monitor's train header read 'merge train Β· 3 PRs Β· 1st: #15425' over one row: #15529 and #15530 were drawn as sub-rows of their linked issues (nested_under), which the header grouping did not see. An issue row now rides its open PR's train (key, contiguity, rail, merge order), the header counts the rows drawn under it and names members the view hides, and the payload carries merge_train.members. #15425 fronted that train although it waits for a maintainer (untrusted author): the lane's admission verdicts were not blocking for the planner. A head whose last lane verdict maps to a human_merge_reason other than the catch-all policy is now no train member at all; verdicts are keyed per lane so another lane's opinion never evicts a member. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Ready for a human merge: verdict approved @1cce83c, 57/57 checks green, DCO yes, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
Normalize an empty lineage chip to null in the single-covering-PR issue row, avoiding an extra separator before the base pill. Keep the generated dashboard in sync and add a regression case for incomplete lineage.
Fixes #15493
Validation:
git diff --checkpassed. Tests were not run locally in accordance with AGENTS.md; CI runs the dashboard tests.β hive: backend=codex