Repository navigation
arm64: dts: exynos: google: zumapro-tegu: Add the haptics and the torch - #96
Conversation
9fd69bf to
d113ffd
Compare
|
Thanks. Both nodes match Google's tegu sources: the CS40L26 at 0x43 on The CI failure is the stack's, not this commit's: it validates against bindings that don't have #89's So this merges after the board stack, #89, #90 and #95. Once those land, please rebase it onto |
d113ffd to
9254f9e
Compare
9254f9e to
0e4454b
Compare
|
Your commit is unchanged, and it's now the top of a stack that sits cleanly on today's This is the PR I'll rebase-merge to land the whole 9a stack, once the boot on #80 is in. The short comment on |
0e4454b to
a0e6dfc
Compare
|
Thanks. The haptics and torch commit is the same patch as before, with an identical tree ( This is still the PR I'll rebase-merge to land the 9a's board stack. Two things before that, both described on #80:
When those are in, I'll merge this and close #80, #81, #85, #87 and #90 as landed here. #105, #106, #119, #122 and #118 then follow on their own threads. |
a0e6dfc to
d8acd98
Compare
|
Thanks for the rebase. It's exactly the Makefile resolution from #80: With the conflict gone, CI ran on every head and passes, So one thing is left before I merge this, as asked on #80: the boot of this head. Please post:
When that's in, I'll rebase-merge this PR, which lands all twelve commits, and close #80, #81, #85, #87 and #90 as landed here. Elsewhere in the stack, nothing new: #106's ramoops layout question and the three small changes on #122 are still open as I wrote them earlier today. #119 is ready and waits on #106. #105 waits on #100 and #104. |
|
Booted this head on the palmtop:
If you'd like the display and GPU rows from this tree too, I can boot it again with #84 and #89 merged on top. |
|
Thanks for the boot report, and for keeping to the read-only checks. The kernel release has no One thing still stands between this PR and a merge: the display and GPU rows. I don't think the reason you give holds, though. The TG4C panel driver (#89, So I suspect the config. You built with your integration tree's config and Could you check and boot once more?
No haptics or torch re-check is needed. The probe lines you posted cover them, and step 2 doesn't change those drivers. For the record, this boot's bootargs aren't the DTB's own. The DTB built from this head carries Once the display and GPU rows are in from this commit, I'll rebase-merge this PR, which lands all twelve commits, and close #80, #81, #85, #87 and #90 as landed here. After that, #55 needs a rebase, and it should bring the 9a's |
|
Thanks for your patience with this one. A status from my side, and an offer. I rebuilt this head on today's The one thing still open is what I asked for on the 29th: the display and GPU rows from a boot of this commit, built with While checking that, I found a gap on my side too. Our shared config fragment in omarchy-mobile doesn't build the TG4C panel driver either, and it doesn't build the ACPM thermal driver your thermal zones need ( So that the boot and touchscreen aren't held up, I've landed them now by rebase-merging #81 (its five commits had all run in the form that lands: the board in your 10-28 boot, touch in your 10-29 boot of this head). This branch and the ones above it only need a |
d8acd98 to
532a6f3
Compare
|
Rebased onto #90's new head (one commit, unchanged). Compiles; checkpatch clean. |
|
Thanks, the rebase is clean and the 9a's DTB is still |
Turn on CMU_G3D and the Mali-G715 for the Pixel 9a, with its core clock on ACPM's paired "gpu" clock (index 17), which sets the shader (G3D) and L2 (G3DL2) domains together, and coregroup and stacks on CMU_G3D's gates. The operating points are the shader rates of the 9a's GPU DVFS table up to 649 MHz. The levels above it, to 940 MHz, wait for a GPU thermal zone, since nothing throttles the GPU yet. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Give the three CPU clusters their ACPM DVFS clocks (cpucl0-2, by the zumapro ACPM clock ids) and operating points for cpufreq-dt, with capacities and power coefficients for the energy model from Google's zumapro-cpu.dtsi, and add the ACPM TMU sensor and the big, mid, little and GPU thermal zones. The CPU levels are the APM firmware's own (its DVFS table, read on the Pixel 9a), up to the 9a's thermal headroom: 1950 MHz little (Google's max-freq for that cluster), 2367 MHz mid and 2687 MHz big. The little cluster's 324 and 610 MHz lie below stock's 820 MHz floor. Each CPU zone throttles its cluster from 80 C, forces the cluster's lowest levels from 95 C and shuts down at 105 C, all below stock's 112 C (CPU) and 115 C (GPU) hot trips. gpu-thermal throttles panthor's devfreq from 85 C. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
… MHz With gpu-thermal throttling the GPU, add the 9a's GPU levels above 649 MHz: 723, 807, 850 and 890 MHz. The table's top, 940 MHz, stays out until it has run on the 9a. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Tensor G4 (zumapro) display pipeline has the gs201 DSIM, at the same register layout and with the same three register windows. Add google,zumapro-dsim with google,gs201-dsim as its fallback. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Add DSIM0, the DSI master between DECON0 and the panel: its link and D-PHY register windows and its interrupt (GIC SPI 252), as in Google's GPL zumapro device tree, disabled until a board names its panel. Link: https://android.googlesource.com/kernel/devices/google/zumapro/+/8831630eee2ad095b85ed452944e6353940966a5/dts/zumapro.dtsi Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Turn on the Pixel 9a's display pipeline: DECON0 with a 64 MiB reusable scanout pool below 4 GiB and the bootloader's splash as its boot framebuffer, scanning out to DSIM0, and the TG4C panel on DSIM0's virtual channel 0. With DECON's output on DSIM0, gs-decon switches the link and the panel between 60 and 120 Hz. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Add the Pixel 9a's haptics, a Cirrus Logic CS40L26 on USI9's I2C bus (0x43, interrupt on gpa6-3, reset on gph2-3), with Google's limits for its LRA (2.5 A boost peak, 10 V boost, 162 Hz, ReDC 14.1 ohm) and VP brownout prevention at 3.008 V, and its torch, a TI LM3644 on USI4's I2C bus (0x63, enable on gpp24-1) driving one white LED from both outputs, limited to 75 mA. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
532a6f3 to
5628f18
Compare
|
The boot you asked for, from this head (5628f18) on the palmtop. Build. defconfig, then One thing had to change first. Built from the fragment as it stands, the 9a boots with no USB at all: it reached the lock screen, but no gadget ever appeared on the host. The eUSB2 PHY, and the ACPM/mailbox/PMIC path its rails come through, are modules in defconfig, and the initramfs loads none. omarchy-mobile#227 builds those four in. The boot below is with that change. Nothing else differs. Boot. DTB sha256 (before the bootargs overlay):
The graphics unit itself reported "failed: gauge", only because |
…DT stack The gs201 Trusty, GSA and AoC drivers and bindings, on top of derekross#96 and derekross#119 (6bbb335). Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
|
Thank you, @W4HO-ham, for this boot. It's exactly the run I asked for, and thanks for chasing down the missing USB along the way instead of working around it. What I checked:
The USB problem is real but separate from this stack: the eUSB2 PHY and its ACPM/PMIC path being modules that the initramfs never loads is a question for our config fragment. I'll take it up on omarchy-mobile#227. So this is ready. I'll rebase-merge it, which lands the seven commits, and close #85, #87 and #90 as landed here. Their patches are all in this branch. After that, here's the order for the rest:
|
Stacked on #90 and the DT and clock PRs under it. It uses #95's
cirrus,vpbr-threshold-microvolt. Only the last commit is new.The Pixel 9a's haptics and torch:
Against the palmtop: both nodes, their buses and pin groups match what it runs, property for property. The only differences are the PERIC0 clock numbers, renumbered by the clock series (same clocks), and the torch limit: the palmtop gets 75 mA from a runtime overlay, and this puts it in the DT.
CHECK_DTBS=y W=1forzumapro-tegu.dtbis clean (with #95's binding), and checkpatch --strict is clean.