Skip to content

Pixel 9a (zumapro): the AoC, GSA, Trusty and speaker amplifiers from the device tree - #162

Merged
derekross merged 17 commits into
derekross:omamobilefrom
W4HO-ham:tegu-dt-aoc
Nov 8, 2026
Merged

derekross merged 17 commits into
derekross:omamobilefrom
W4HO-ham:tegu-dt-aoc

Conversation

@W4HO-ham

@W4HO-ham W4HO-ham commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

This makes the 9a's audio and sensor DSP (the AoC) start from the device tree, with no runtime overlays and no out-of-tree modules: Trusty, the GSA, the AoC with its mailboxes, the two TAS2572 speaker amplifiers and the AoC sound card.

Rebased on today's omamobile (4cf2c8b). It's now the 18 commits below on top of omamobile, no merges. Everything else this branch used to carry is already on omamobile.

What's in it

44d7300cb dt-bindings: clock: google,zumapro: Add the HSI0 USI4 clocks
a3948cb50 clk: samsung: zumapro: Add the HSI0 USI4 clocks
45d04431c dt-bindings: soc: google: gs201-gsa: Add Tensor G4 (zumapro)
3c5a3b716 soc: google: gsa: Add Tensor G4 (zumapro)
823e00c8b dt-bindings: mailbox: google,gs201-aoc-mbox: Add Tensor G4 (zumapro)
7f35b9e47 soc: google: aoc: mailbox-wc: Add Tensor G4 (zumapro)
b969614bf dt-bindings: soc: google: gs201-aoc: Add Tensor G4 (zumapro)
d09496957 soc: google: aoc: Add Tensor G4 (zumapro)
ceea6c128 soc: google: aoc: Read the ACPM DVFS rates before a firmware start
b9e8739f3 soc: google: aoc: Clear the heaps on zumapro before the first start
f5a6d9825 arm64: dts: exynos: google: zumapro: Add HSI0's USI4 and its I2C controller
440bc69a3 arm64: dts: exynos: google: zumapro: Add Trusty
69fc954f4 arm64: dts: exynos: google: zumapro: Add the GSA
18cdbbabb arm64: dts: exynos: google: zumapro: Add the AoC and its mailboxes
03854634b ASoC: dt-bindings: Fix TAS2563 address constraints
6f14a7f34 arm64: dts: exynos: google: zumapro-tegu: Add the speaker amplifiers
8a2ceebc3 arm64: dts: exynos: google: zumapro-tegu: Enable the AoC
a1c819d9c arm64: dts: exynos: google: zumapro-tegu: Add the AoC sound card
  • Clocks: HSI0's USI4 clock ids and clocks (binding and driver).
  • Compatibles: the zumapro compatibles for the GSA, the AoC mailbox and the AoC (bindings and drivers).
  • AoC driver, zumapro support: per-SoC data and no S2MPU or System MMU writes. It reads the sensor supplies and the firmware name, checks the GSA state before copying, refuses a second load and doesn't restart after a fault.
  • DVFS: the AoC reads its 17 ACPM DVFS rates before a start, replacing a bring-up helper.
  • Heaps: cleared on zumapro before the first start.
  • zumapro.dtsi: USI4/I2C19, Trusty, the GSA, the AoC and its mailboxes, all disabled.
  • Binding backport: Rob Herring's TAS2563 address-constraints fix, which a ti,tas2572 at 0x48 needs.
  • zumapro-tegu: the two TAS2572s (0x48 and 0x49), the AoC enabled (aoc-tegu.bin, the board ids, gnss-type 2, the sensor rails) and the sound card.

All 18 are the same patches as before the rebase (git patch-id matches; the one context difference is in Enable the AoC, where the surrounding lines of zumapro-tegu.dts moved). Authors and sign-offs are unchanged.

What dropped out, and why

The 65 commits already on omamobile (old commit here, then omamobile's)
this branch before omamobile subject
0dfc2bb08297 e81264f72600 mfd: sec: Add the S2MPG15 sub-PMIC
0b8cbcea7a2d b3b8cdc3314c power: supply: max17042_battery: use dSOCi for MAX77759 SOC alerts
006e9ff656fa dcf4eb4fd86c power: supply: max77759: disable the fast-charge safety timer
479c3e0e05d8 4fa270cbc608 power: supply: max77759: stay online while a full battery is on the charger
dca66f96f76b a72a90916b37 ASoC: dt-bindings: cirrus,cs35l41: add cirrus,dsp-no-hibernate
72d1b11ef841 5dc20714d749 dt-bindings: vendor-prefixes: add android
b6da930a0037 0efda152fe34 dt-bindings: firmware: add Trusty
73ee7b7aff32 160168089cfb dt-bindings: soc: google: add the gs201 GSA mailbox
b9da3e5d8980 ad5940fc0812 dt-bindings: soc: google: gs201-gsa: add the GSA's S2MPU
d38da912bf45 932b70138fb2 dt-bindings: soc: google: add the gs201 AoC System MMU
e1358a42b1dc 20aea4fa2769 dt-bindings: soc: google: add the gs201 AoC
434e077dd4dd c4f4d4bc823c dt-bindings: soc: google: gs201-aoc: add the PCU and the watchdog interrupt
b2b612916d33 3177acb9210a dt-bindings: soc: google: gs201-aoc: add the AoC mailboxes
cd18b5902d41 f124e82e1daa ASoC: cs35l41: honour cirrus,dsp-no-hibernate
9acf8a5c9fc9 c4733c34ebeb ASoC: cs35l41: keep the ASP word length within 24 bits
fa3362f45fc9 a616bc0fa545 ASoC: cs35l41: bring-up option to feed DSP RX6 from the class H target
1c55d4699d42 cd9e5a972fcf ASoC: cs35l41: bring-up option to switch the weak-FET output mode off
2c0a9a4de06c 61225e824040 ASoC: cs35l41: bring-up option to run without the boost converter
f012500caa5b c9fdb330c099 ASoC: cs35l41: bring-up option for a fixed boost target
d4322eb10448 8dbf3732949b ASoC: cs35l41: keep boost_en through a boost fault release; say when the knobs apply
4b15d50a67ad 7b06f00d335c kthread: export kthread_set_per_cpu()
49c40ba0dc6d b0148c449400 trusty: add Google's Trusty driver
56fd1d8b190a 066ed3dd9a46 trusty: keep CPUs online while Trusty is bound
2301282495c3 09b549ce5324 trusty: share a dma-buf by its attachment's DMA addresses
636f0e13fc82 a040a1db7ed8 soc: google: add a GSA mailbox driver
204a6ae39286 8c319a2623cf soc: google: gsa: load and start AoC firmware
e4f446e9dd3a 9c9d5c59b1bc soc: google: gsa: unload AoC firmware
855491ba1ebd 25bd22162e11 soc: google: add the gs201 AoC System MMU windows
e47eb170c05f 1f26af8a7f10 soc: google: gs201-aoc-sysmmu: detect and repair a cleared setup
1f04f5b3635f 5e5c670fe7fb soc: google: add a gs201 AoC firmware boot driver for bring-up
e93600d6ab20 0cd12cfeb5d8 soc: google: gs201-aoc-boot: add unload
0b31f3e19915 c5915f4bdba1 soc: google: gs201-aoc-boot: diagnose a start that does not finish
ea9622f44b9a f279a0ef8991 soc: google: gs201-aoc-boot: gate the PCU read, no lock in read-only views
cf7ea798862d d73f96b9966b soc: google: gs201-aoc-boot: read the AoC mailboxes
6a66da04f866 4658dcd08484 soc: google: add the gs201 AoC supplies over ACPM for bring-up
12b5a180068f 460b9c8c06cb soc: google: gs201-aoc-rails: power-cycle the sensor rails on request
930bdcd41e96 76952955f88a soc: google: aoc: import Google's AoC core driver
595fc7e7dadc 6b0df5fa7b17 soc: google: aoc: port Google's AoC core to gs201 on Linux 7.3
1234b005d24a 496575f9ca6d soc: google: aoc: read the board id from google,board-id; channel defaults
979348605dcb 181abf7fccbf soc: google: aoc: refuse a firmware load while the AoC runs
4f96f59eed53 6637ab2f6173 soc: google: aoc: list all services in debugfs
6bfc003cd568 0435d11c015a soc: google: aoc: do not fill a ring that is already at its start
c4031040c1b1 34fc2dd875a8 soc: google: aoc: import Google's AoC ALSA driver
5f4f082be599 f9dc67a01c0a soc: google: aoc: port the AoC sound card to Linux 7.3 with speaker limits
af8d6e15688b dfbe08986bf5 soc: google: aoc: alsa: log the ring counters when a playback write has no room
266809cfd3e8 24a43ac75ee6 soc: google: aoc: alsa: unregister the platform drivers on unload
380097c5eddc 47a28b8e9182 soc: google: aoc: alsa: optionally log the PCM ring counters
51d2a47f81ab f83b32fcaeba soc: google: aoc: alsa: make the second entry point setup optional
80466668758b 19971a87822a soc: google: aoc: alsa: refuse a PCM whose number is not its entry point
8573a2848885 a4fdf705ea8d soc: google: aoc: alsa: put the card's DAI links in the stock order
55e118788d7e 6457f79fb061 arm64: dts: exynos: google: gs201: add the GSA mailbox
9f53c08a165d c752eeaebeae arm64: dts: exynos: google: gs201: add the GSA's S2MPU range
2f98a109af10 93ae40d15888 arm64: dts: exynos: google: gs201: add Trusty
4c6c4e4bac4f daeb37595811 arm64: dts: exynos: google: gs201: add the AoC and its System MMU
05abf9aeae1b 8b14436589f7 arm64: dts: exynos: google: gs201: add USI7 SPI
cc6bd0353710 7ee3455472e5 arm64: dts: exynos: google: gs201-cheetah: describe the speaker amplifiers
745429c46b8b 522c273acf48 arm64: dts: exynos: google: gs201-cheetah: keep the amplifier DSPs out of hibernate
dbeae8e3f908 3e43b0cd3808 arm64: dts: exynos: google: zumapro-tegu: Enable the GPU
babf9742a49e ba808a07eeb1 arm64: dts: exynos: google: zumapro: Add CPU DVFS and thermal zones
94f81703f020 02e4019e72ea arm64: dts: exynos: google: zumapro-tegu: Add the GPU's levels to 890 MHz
4a1fd4a360ad e88fc8122b53 dt-bindings: display: samsung: google,gs201-dsim: Add Tensor G4
52136cdd274e 599405132bb3 arm64: dts: exynos: google: zumapro: Add DSIM0
6c3e80e98324 9b216c2cc42d arm64: dts: exynos: google: zumapro-tegu: Enable the display
5628f1888904 3af51a3d2b77 arm64: dts: exynos: google: zumapro-tegu: Add the haptics and the torch
6bbb335874c5 b74615d524e7 arm64: dts: exynos: google: zumapro-tegu: Add the fuel gauge and USB-C port controller

Hardware

These 18 commits ran on the palmtop today (2026-11-03) on top of the 9a modem series. The AoC came up from the device tree with 93 services, the sound card google,tegu-aoc-snd-card registered, and two phone calls had audio both ways. The earlier runs on this branch (speaker heard by ear through the TAS2572s, microphone capture, the sensors through omamobile-sensor-proxy) are in the comments below. That kernel had omamobile's newer AoC doorbell code (6d37aa0, 93640e5), the same as this rebase.

Checks

tools/kernel-pr-check --build --merge against omamobile 4cf2c8b:

  • merges cleanly; 18 commits signed off by their authors; subjects have subsystem prefixes; policy checks (identifiers, blobs) pass.
  • checkpatch --strict: no errors. Warnings: soc: google: aoc: Add Tensor G4 (zumapro) asks whether MAINTAINERS needs updating for the new aoc_sensor_power.c, and the sound-card commit's eight google-aoc-* compatibles are undocumented.
  • W=1 builds of the 6 touched C files: no warnings.
  • dt_binding_check on the 4 touched bindings (google,gs201-gsa, google,gs201-aoc-mbox, google,gs201-aoc, ti,tas2781): clean.
  • Device trees: every exynos/google board builds with W=1 with nothing new. dtbs_check on zumapro-tegu: 0 lines at the base, 184 new at the head, nothing gone, no other board changed. All 184 are inside the sound card: /sound-aoc, its be_*/fe_* links and codec_cfg, and the seven aoc_* nodes. They are the eight compatibles without a schema and dtschema's type checks on the properties under them. Trusty, the GSA, the AoC, its mailboxes, USI4/I2C19 and the two TAS2572s add nothing. This is the only failing check.

The card binding

You asked me to follow #141's gs201 card binding. #141's content is on omamobile now, but it has no sound-card binding: gs201's card is still described by an overlay on the 7 Pro side. So there's nothing to follow yet, and the card commit still uses Google's google-aoc-* compatibles as stock's device tree does.

My proposal: keep this PR to what's above, and write one AoC sound-card binding as a follow-up that covers gs201 and zumapro together, with both boards' cards moved onto it. That would also clear the 184 dtbs_check lines. If you'd rather have the binding in this PR, say so and I'll add it here, or I can drop the card commit from this PR until the binding lands.

@W4HO-ham

Copy link
Copy Markdown
Contributor Author

Two more runs on the same kernel (7.3.0-rc6-omamobile-push1-g922812d75006), with omamobile-audio 0.5.6's UCM profile and the AoC started at boot by device-tegu 0.2.2:

  • Speaker: PipeWire shows the Built-in Audio Speaker sink (EP6 through TDM_0_RX, the profile's route). A 1.5 s 440 Hz tone at -20 dBFS (pw-play --volume 0.5) played to the end with exit status 0. Whether it was audible is for the owner to confirm by ear; I'll add that here.
  • Microphone: PipeWire shows Built-in Audio Microphone (EP1 capture, INTERNAL_MIC_TX). A 4 s pw-record at 48 kHz mono came back with 186368 frames, RMS -32.4 dBFS and a peak of 3836. That's real input, room and road noise in a moving car, not digital silence.

@W4HO-ham

W4HO-ham commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Speaker confirmed by ear. On the same kernel, with the AoC started at boot by device-tegu 0.2.2, a 5 s 440 Hz tone at -10 dBFS (pw-play --volume 1.0 through the Built-in Audio Speaker sink, the UCM profile's ceiling in place) played from the speaker and was heard by the owner. So the TAS2572s drive the speaker through the AoC card from this device tree.

@derekross

Copy link
Copy Markdown
Owner

Thanks for the question, and congratulations on the speaker by ear. Please follow #141's gs201 card rather than adding a separate binding: one AoC sound-card binding, with the tegu compatibles added to it next to gs201's, so the two cards share a schema and a driver path. I'll get #141 out of draft so you have something stable to build on; until then it's fine for this branch to carry it, as it does now.

Add CMU_HSI0's USI4 clock ids, 28 to 32, appended after USI3's. On the
Pixel 9a USI4 is I2C19, the control bus of the two TAS2572 speaker
amplifiers.

Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-sfr.c
Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Add CMU_HSI0's USI4, the Pixel 9a's I2C19 (the TAS2572 speaker
amplifiers' control bus). The bootloader leaves the path running, so
it is described read-only: the local mux and the divider take
CLK_MUX_READ_ONLY and CLK_DIVIDER_READ_ONLY, and the source, IP and
PCLK gates go in hsi0_ro_gates rather than hsi0_regs. The I2C driver
derives its timing from the inherited rate.

The mux (0x1024), divider (0x1824) and gates (0x2128, 0x210c, 0x2110),
and the mux parents (HSI0 PERI user, oscclk), follow zuma's
cmucal-sfr.c and cmucal-node.c, four bytes on from USI3's.

Booted on the Pixel 9a:
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty carries these
clocks under that tree's own ids. The bootloader's state read back as
the PERI user route, divide by one, and the three gates on; with them
the exynos5-hsi2c driver binds I2C19 and both TAS2572s probe and play.

Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-sfr.c
Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-node.c
Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Pixel 9a's GSA (Tensor G4, zumapro) takes the same mailbox commands
as gs201's, at 0x16490000 with GIC SPI 375. Its AoC firmware loads with
no write to the GSA's stage-2 MPU, so a zumapro node describes the
mailbox only.

Address and interrupt from Google's GPL zumapro device tree.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Match google,zumapro-gsa. The 9a's GSA answers the same mailbox and
Trusty hwmgr commands as gs201's, and the driver already leaves the
S2MPU alone when the node has no "s2mpu" range, as a zumapro node
doesn't.

Booted on the Pixel 9a:
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty runs this
driver with only this match added. With it the GSA reports the AoC
inactive, authenticates the signed AoC image and starts it, and the
AoC comes up with its 93 services.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Pixel 9a's AoC mailboxes (Tensor G4, zumapro) have gs201's register
layout: three of them, A32, F1 and P6, at 0x15200000, 0x15220000 and
0x15240000 with GIC SPIs 77 to 79, 16 doorbells each way.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Match google,zumapro-aoc-mbox. The 9a's three AoC
mailboxes have gs201's registers.

Booted on the Pixel 9a:
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty runs this
driver with only this match added; the AoC's 48 doorbells carry its
startup and its 93 services.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Pixel 9a's AoC (Tensor G4, zumapro) runs the same firmware protocol
as gs201's, but its authenticated firmware owns the AoC's memory
protection: Linux writes neither the AoC's S2MPU nor its System MMU, so
a zumapro node has only the power request and chip id ranges and no
google,sysmmu. It also names its signed image (firmware-name, one per
board), and takes the two sensor rails as supplies in their power
order, where gs201 nodes list regulator names.

Add google,gnss-type for the board's GNSS receiver, which the firmware
takes as a boot parameter (2 on the 9a, as in Google's GPL
zumapro-phone-ignss.dtsi), and clocks, the ACPM DVFS domains read
before each start: on the 9a the firmware faulted at every start until
the AP had asked ACPM for the DVFS rates first.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
@W4HO-ham

W4HO-ham commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto today's omamobile (4cf2c8b): the branch is now the 18 commits omamobile doesn't have yet, no merges, all patch-identical to before, and it merges cleanly. These 18 ran on the palmtop today with the AoC up and two calls with audio both ways. kernel-pr-check --build --merge passes except for the sound card's 184 dtbs_check lines. On the card binding: there's no gs201 card binding on omamobile to follow yet, so I've proposed one shared binding as a follow-up in the description. Tell me if you'd rather have it in this PR. Ready for review.

@W4HO-ham
W4HO-ham marked this pull request as ready for review November 3, 2026 00:57
@derekross

Copy link
Copy Markdown
Owner

Thank you, @W4HO-ham, for the rebase down to 18 clean commits, and for calls with audio both ways from the device tree. You're right about the card binding, and I'm sorry: #141 landed without one (the 7 Pro's card is still an overlay), so there was nothing to follow. I withdraw that request.

The gate passes apart from the card, and every DTB except the 9a's is unchanged. I also went through the AoC driver's gs201 path: the PCU and GPIO bases, the doorbell offsets, the chip id fields and the force-vnom default all match the old constants, and my 7 Pro's node has no clocks and no firmware-name, so the new DVFS reads and firmware name do nothing there.

Before it lands:

  1. The card. Its 184 dtbs_check lines would land a red check. A binding needs vendor-prefixed compatibles and matching driver changes that also touch my 7 Pro's card, so I'd rather do that in its own PR covering both boards. Please move the card commit there and keep this PR to the other 17; until then the 9a can carry its card the way the 7 Pro does.
  2. One gs201 change in "Add Tensor G4 (zumapro)": the new goto free_fw after a failed _aoc_fw_commit() also applies to the 7 Pro, which used to carry on to authentication. Please put it behind firmware_managed_mmu, or say in the message that it's meant for gs201 too.
  3. A tools/phone-smoke report from a kernel built from this head.

Since the AoC driver's constants moved into per-SoC data, I'll boot this on my 7 Pro (AoC, sound card, sensors) before merging. Without the card commit it merges cleanly with #187.

@W4HO-ham

W4HO-ham commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Added the two bindings, ahead of the card's device tree commit: sound/google,aoc-snd-card.yaml (the card: its long name, codec prefixes, the AoC-driven clocks and the DAI links) and sound/google,aoc-path.yaml (the AoC path DAI and the six PCM driver nodes). Both pass dt-doc-validate and yamllint. Checked against these two schemas, the 9a's DTB reports nothing for the card (it reported 184 lines without them), and so does the 7 Pro's card, applied as an overlay on gs201-cheetah; a deliberately bad property is caught. That's one binding for both phones' cards, as you wanted on #141. The full dtbs_check run on this branch comes with the next build in the project container (nixpkgs' dtschema can't build this tree's processed schema).

@derekross

Copy link
Copy Markdown
Owner

Thank you, @W4HO-ham, for writing the two bindings, and for checking them against both phones' cards. CI's dtbs_check and dt_binding_check now pass on this head, so the 184 lines are gone. Everything else is unchanged from the 18 commits I read this morning, and kernel-pr-check --build --merge on today's omamobile passes.

On the bindings, I'd still like them, with the card, in their own PR. A binding becomes ABI once it lands, and these document Google's names as they are: google-aoc-* compatibles without the vendor comma, and properties like aoc-card-name, codec_cfg and of_drv without a prefix. Those are the things writing-bindings.rst asks us not to add, and once they're in, any later move to google,… names has to keep them as well. I'd rather settle the names once, together with the driver change, for both phones. You've done most of the work for that PR already. So please drop the top three commits here (the two bindings and the card) and open them as a follow-up. The other 17 merge cleanly with #187. With the card, zumapro-tegu.dts conflicts with #187's Wi-Fi regulator, because both add a block at the same spot; the fix is to keep both, regulator first. I've checked that it builds.

Two points from this morning are still open:

  1. The new goto free_fw after a failed _aoc_fw_commit() in "Add Tensor G4 (zumapro)" also changes my 7 Pro, which used to carry on to authentication. Please put it behind firmware_managed_mmu, or say in the message that it's meant for gs201 too, and why.
  2. A tools/phone-smoke report from a kernel built from this head.

Then I'll boot the 17 on my 7 Pro (AoC, sound card, sensors) and merge.

W4HO-ham and others added 10 commits November 3, 2026 14:39
The Pixel 9a's AoC takes gs201's firmware protocol, with these
differences, kept in per-SoC match data:

- Its authenticated firmware owns the AoC's memory protection: the GSA
  authenticates the image with the S2MPU and System MMU untouched, so
  the driver neither maps nor writes them.
- The PCU, GPIO and doorbell blocks sit at 0x1400000, 0x1c00000 and
  0x1f004/0x1f008 in the AoC's address space, from Google's zumapro
  AoC device tree.
- The chip type is the product id's low byte, and the main revision is
  in it too, not in the 0x10 word.
- The firmware image is named by firmware-name; a zumapro node must
  have it, and the board id and revision.
- The sensors' 1.8 V and 3.3 V are two named supplies, turned on in
  that order at probe and off in reverse (aoc_sensor_power.c).
- Without force-vnom in the DT the firmware gets forced VNOM off. gs201
  keeps getting it on, as it always has (dt_property() returns
  DT_PROPERTY_NOT_FOUND, not 0, for a missing property).

The firmware path is hardened where a zumapro failure could otherwise
go wrong without a way back: the image is copied only while the GSA
reports the AoC inactive and the power request is acknowledged, a
failed copy stops the load, the authentication header stays allocated
(the GSA may still read it after a timeout), a second submission in the
same boot is refused, and a watchdog or AP reset leaves the AoC down
for a reboot rather than dumping or restarting it, since the image is
locked once authenticated. "google,gnss-type" replaces the unprefixed
"gnss-type", which no gs201 DT sets.

Booted on the Pixel 9a:
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty runs this
driver with bring-up parameters on top (startup tracing, a boot
parameter readback, a gate on power request writes, left at "write").
With it the AoC authenticates, starts and reaches its 93 services and
stays up; seven fresh boots in a row passed, with speaker and
microphone audio through the AoC sound card and the AoC's sensors on
D-Bus.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
On the Pixel 9a the AoC firmware faulted at every start (a DSP watchdog
right after it announced its services) until the AP had asked ACPM for
the DVFS domains' rates first. With one GET-rate request for each of
the 17 domains before the firmware request the start is stable: 93
services, no watchdog interrupt, online indefinitely. Stock does the
same query at boot (cal-if's vclk_get_boot_freq() calls
exynos_acpm_get_rate()), so the APM's DVFS plugin evidently expects it
before it serves the AoC's own votes. Which domain matters hasn't been
narrowed down.

Take the domains as clocks: the ACPM clocks have CLK_GET_RATE_NOCACHE,
so clk_get_rate() sends the same request. The rates are read in the
firmware callback before the power request; a node without clocks
(every gs201 one) reads nothing.

Tested on the Pixel 9a,
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty, with the same
requests sent through the exynos-acpm handle by a helper module just
before the firmware request: the AoC came up and stayed up on every
start since (the first two runs, then seven fresh boots in a row).

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Android creates the AoC's sensor, playback and capture heaps with its
physical-heap constructors, which clear them at probe. This port lays
the heaps out without creating them, so on zumapro clear the three
together (they're contiguous at the top of the carve-out) before the
firmware is first authenticated.

On the Pixel 9a this is part of the composition that runs,
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty, where the
same clearing is behind a bring-up parameter that every start since
2026-10-25 has set. On its own it didn't fix the firmware's startup
fault (that was the DVFS query); it is kept so the firmware sees the
memory Android gives it.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
…roller

Describe CMU_HSI0's USI4 in I2C mode and its controller, the Pixel 9a's
I2C19 (the speaker amplifiers' control bus), as USI3's SPI is: the USI
control registers at 0x111f00c0 apart from the controller's, the HSI0
sysreg's selector at 0x1024, GIC SPI 410. Both stay disabled.

Booted on the Pixel 9a:
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty has these two
nodes, enabled by an overlay at runtime; exynos-usi and exynos5-hsi2c
bind them and the two TAS2572s answer at 0x48 and 0x49.

Address, selector and interrupt from Google's GPL zumapro-usi.dtsi.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Describe Trusty, the secure OS the bootloader starts, as on gs201: its
IPIs are GIC SGIs 8 to 15. It stays disabled. The GSA starts the AoC
through Trusty's hwmgr service, so audio and sensors need it.

Booted on the Pixel 9a:
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty has this node,
enabled by an overlay at runtime; trusty-core, -log, -ipc and -virtio
bind it and the GSA reaches its hwmgr port.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Describe the GSA's mailbox at 0x16490000 with GIC SPI 375. It stays
disabled.

Booted on the Pixel 9a:
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty has this node,
enabled by an overlay at runtime; the gsa driver binds it, reads the
AoC's state through Trusty, and authenticates and starts the AoC.

Address and interrupt from Google's GPL zumapro device tree.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Describe the AoC, the audio and sensor DSP, and its three mailboxes
(A32, F1, P6, GIC SPIs 77 to 79). The AoC's power request is at
0x154b0000, its watchdog on SPI 130, and it reads the chip id block at
0x10000000; its 48 doorbells are the mailboxes' 16 each. Its clocks are
the 17 ACPM DVFS domains, all of which the 9a's AoC driver asks ACPM
about before each start. The firmware owns the AoC's memory protection,
so neither its S2MPU nor its System MMU is described. All stay
disabled; the board adds the carve-out, its firmware name, its board
id and the sensor supplies.

Booted on the Pixel 9a:
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty has these nodes
(plus a disabled System MMU node this driver no longer uses), enabled
by overlays at runtime; the AoC starts and reaches its 93 services.

Addresses and interrupts from Google's GPL zumapro device tree.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Apply the TAS2781 register range only when the compatible is exactly
ti,tas2781. This avoids applying the TAS2781 single-address rule to
TAS2563 nodes with 0x4c-0x4f addresses.

Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20260922212122.1116270-1-robh@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
The Pixel 9a's two speakers have a TI TAS2572 each on I2C19 (HSI0's
USI4): the top one at 0x48 with its reset on gpp6-3, the bottom one at
0x49 with its reset on gph2-1, as in Google's GPL
zumapro-tegu-audio-common-tas2572.dtsi. Describe them one node each:
the tas2781 driver takes one register profile (RCA file) per node, and
the TAS2572 profiles in linux-firmware cover one device.

Booted on the Pixel 9a:
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty with these
nodes applied as an overlay at runtime: both bind to tasdev-codec, and
with the AoC sound card both speakers play through PipeWire.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Turn on Trusty, the GSA, the AoC's three mailboxes and the AoC, and give
the AoC the board's parts: the carve-out, its signed image
(aoc-tegu.bin), stock's board id and revision (0x60b02, 0x10000, from
Google's GPL tegu device trees), GNSS type 2 (the modem's integrated
receiver, as Google's zumapro-phone-ignss.dtsi), and the sensor rails,
the S2MPG15's LDO7S (1.8 V) and LDO5S (3.3 V).

Nothing starts the AoC at boot: the firmware is loaded when userspace
writes its name to the AoC's "firmware" attribute, once the modules are
loaded in order. The drivers' probes only map registers, talk to Trusty
and the GSA, and turn on the two sensor rails.

Booted on the Pixel 9a:
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty with the same
nodes (the Trusty, GSA, mailbox and AoC ones enabled by overlays at
runtime, the AoC's board properties in its DT): the GSA authenticates
and starts the firmware, which reaches its 93 services and stays up,
and the sensor proxy finds the accelerometer, light, proximity and
compass sensors on the AoC.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
@W4HO-ham

W4HO-ham commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Done. This branch is now the 17 commits (c3bfbdd). The two bindings and the card are in #193, a draft stacked on this one, until the names are settled for both phones.

The new goto free_fw after a failed _aoc_fw_commit() now sits behind firmware_managed_mmu, so gs201 carries on to authentication as before, with a one-line comment saying so. W=1 of aoc.o is clean, and kernel-pr-check passes (17 signed off, no checkpatch errors).

The tools/phone-smoke report from this head still owes you a palmtop boot. I'll do it with #187's after the current sleep series, attended.

@W4HO-ham

W4HO-ham commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

The smoke report from this head. The kernel is these 17 commits (c3bfbdd) merged onto today's omamobile (5df2fd3), release 7.3.0-rc6-omamobile-push1-g433a63e40279. Config: kernel/configs/omamobile.config plus EXYNOS_GNSS_IF_SPI=m and PHY_ZUMA_PCIE=m. The only build warnings are aoc_alsa_compr.c's two -Wformat lines, as before. One boot on the palmtop, pushed and pushed back, with no reset, no oops and no UFS errors.

The AoC came up from the device tree at boot through omamobile-device-tegu's unit: omamobile-tegu-aoc: up: Services : 93, with aoc-tegu.bin loaded and board id 0x60b02 read. That includes the goto free_fw change, which on the 9a takes the firmware_managed_mmu path.

Three rows don't apply to this branch:

### phone-smoke: tegu

Kernel `7.3.0-rc6-omamobile-push1-g433a63e40279`, tools at `330a7f2`, 2026-11-04T03:00Z.

| Check | Result | Detail |
| --- | --- | --- |
| boot (required) | ok | kernel 7.3.0-rc6-omamobile-push1-g433a63e40279, slot b, up 157s |
| storage guard (required) | ok | 62 partitions; only userdata and slot B's boot images writable |
| root (required) | ok | ext4 on userdata, 16G free |
| kernel health (required) | ok | no oops or BUG; 0 WARN, 36 error lines in dmesg (22 known, 14 new) |
| new dmesg errors | not ok | samsung-pinctrl N: irq number not available x6; maxtcpc N: Failed to get vbus regulator handle x3; goodix_fp: version magic '…' should be '…' x2 |
| systemd units | not ok | failed: systemd-backlight@backlight:19440000.dsi.0.service tegu-gpu-dvfs.service tegu-nfc-clkpad.service |
| USB gadget (required) | ok | bound to 11210000.usb |
| display | ok | card1-DSI-1 connected, 1080x2424 |
| GPU | ok | render node on panthor |
| session (required) | ok | Hyprland and the Omarchy shell running |
| lock | ok | PAM file present, the shell can lock (passwordPam true, locked true) |
| touch | ok | Synaptics TouchComm Touchscreen |
| buttons | ok | gpio-keys |
| Wi-Fi | skip | no wireless interface |
| Bluetooth | ok | hci0, powered true |
| battery | ok | 89% Full, 30 °C |
| sound cards | skip | none |
| sensors | skip | no sensor proxy |
| cameras | not ok | libcamera lists none (or a camera app holds them) |
| thermal | ok | hottest zone 44 °C |

Packages: hyprland 0.56.2-5.1, libcamera 0.7.2-4.22, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamessages 0.2.2-1, omamobile-apps 0.2.2-1, omamobile-audio 0.5.13-1, omamobile-device-tegu 0.2.12-1, omamobile-fingerprint 0.1.8-1, omamobile-firstboot 0.1.0-1, omamobile-gnss 0.2.7-1, omamobile-keyring 20261013-1, omamobile-mirror 0.1.1-1, omamobile-mmd 0.1.4-1, omamobile-modem 0.1.11-1, omamobile-modem-sit 0.3.36-1, omamobile-omarchy 0.1.31-1, omamobile-owl-widgets 0.1.2-1, omamobile-sensors 0.2.1-1, omamobile-shell 0.2.100-1, omamobile-telephony-tegu 0.1.0-1, omaphone 0.2.3-1, omarchy 4.0.6-1, omatel-agent 0.2.4-2

@derekross

Copy link
Copy Markdown
Owner

Thank you, @W4HO-ham, for the split, the gate and the smoke report, all in
one evening. I read the changed hunk: the new goto free_fw now runs only
where firmware_managed_mmu is set, which is zumapro alone, so my 7 Pro
carries on to authentication as before. The other 16 commits are unchanged
from what I read yesterday. The two bindings and the card in #193 are
exactly the commits you dropped. kernel-pr-check --build --merge on today's
omamobile passes, CI is green, and this now merges cleanly with #187.

The smoke report shows the AoC coming up from the device tree with 93
services, which covers the zumapro side of the changed hunk. Thanks for
explaining the not ok rows: the pinctrl irq number not available lines
are the zuma ALIVE-bank message we've seen on the 8 Pro too, and the others
come from the palmtop's bring-up setup.

That's everything from you. What's left is on my side: a boot of these 17 on
my 7 Pro (AoC, sound card, sensors, smoke test). Then I'll rebase-merge this.
When it lands, #193 will need a rebase onto omamobile, since its commits
below the card get new ids.

@derekross

Copy link
Copy Markdown
Owner

@W4HO-ham the 7 Pro run is done and it's clean, so this goes in. The kernel was omamobile with this PR's c3bfbdd0 merged on top, 7.3.0-rc6-omamobile-push1-g2a631696df00.

  • AoC and sound card: the AoC came up at boot through omamobile-aoc, and the card registered with the same 18 playback and 14 capture PCMs as the kernel before. The only kernel lines are the usual ones: the card's -517 deferrals while the amplifier codecs probe (8 retries here, 6 on the boot before; the number follows boot timing), and the existing failed to register acpm aoc reset callback. No WARN.
  • Amplifiers: both CS35L41s loaded their protection firmware (top and bottom tunings), and omamobile-speaker-protection finished as usual.
  • Sound: a 2 s 1 kHz tone at -20 dBFS through pw-play played clean from both speakers, by ear, with no AoC or amplifier error.
  • Sensors: the sensor proxy runs, and the accelerometer, ambient light and proximity are all present.
  • tools/phone-smoke: 18 ok; cameras skipped (no libcamera tools on this image).

Since the test kernel was built, omamobile gained #176's reboot-mode nodes in gs201-cheetah.dts and nothing else under the AoC, sound or gs201 paths, so the run carries over. Merging now. #193 can rebase on this.

@derekross
derekross merged commit 41e5d73 into derekross:omamobile Nov 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants