Repository navigation
Conversation
b533af3 to
6619a7e
Compare
|
Thank you, @W4HO-ham. This is a tidy node, and keeping it off the SPI bus because the secure world owns that bus is right. I checked it against Google's CI passed on all fifteen commits, on a base from before yesterday evening. It still merges cleanly onto today's What I'd like changed:
A small one: stock's On order: this waits for #161 (and the #96/#119 stack under it), #101 and my #147. Then it needs a rebase onto |
|
Done:
On the drive strength: stock's built DTBO (the vendor |
6619a7e to
a9b70ef
Compare
|
Thank you, @W4HO-ham, for turning these round so quickly, and for taking the drive strength from stock's built DTBO rather than guessing. I owe you a correction on my first point. I asked you to pin LDO15S at 3.3 V because "with min = max, the core sets 3.3 V before enabling it". That's wrong for this driver, and my wording is now in your comment and your commit message. #101's LDO ops (
So the pin is only safe if the hand-off voltage is already 3.3 V. Could you check that? The boot of
Sorry for the extra round on this one. The drive-strength line ( The rest is as we agreed: this waits for #161, #101 and my #147, then a rebase onto |
|
No need to apologise, and thanks for checking the driver. It reads 3.3 V. On the palmtop's daily kernel, whose So I kept the two lines and reworded both places to say what they do (head dd18680, only the comment and the message changed). The comment now says the selector is firmware-owned and reads 3.3 V at hand-off, and that min = max records stock's value and makes the core refuse the rail if it ever reads anything else. The message says the same, and that the S2MPG15 LDOs have no voltage setting. checkpatch is clean. The rebase onto |
a9b70ef to
dd18680
Compare
|
Thank you, @W4HO-ham, for checking the hand-off voltage and for the clear write-up. A 3300000 µV reading with empty So the node is settled. What's left is the order:
After that rebase I'll run the builds and the binding checks again. |
Describe the Pixel 9a's Goodix under-display fingerprint sensor as Google's GPL zumapro-tegu-udfps.dtsi has it: the event line on gpa7-6 (EINT, rising edge) and the reset on gpp1-0 (active low, its previous state kept in power-down). Its SPI bus belongs to the secure world, so the node is on no bus. The pin state touches only gpp1-0; the touchscreen's reset is gpp1-1 in the same bank. Its 3.3 V, S2MPG15 LDO15S, is always on, as on stock. It is off at hand-off, and until it is on the trusted app reads chip id 0. This adds the sub-PMIC and gpa7's interrupts (GIC SPI 36-43, as stock). LDO15S's selector is firmware-owned (the S2MPG15 LDOs have no voltage setting) and reads stock's 3.3 V (1.8 V + 60 x 25 mV) at hand-off, so min = max writes nothing: it records stock's value, and the core refuses the rail if it ever reads anything else. gpp1-0's drive is stock's X1 (0). Tested on the 9a with this tree (7.3.0-rc6-omamobile-push1-gb533af3f1cbc, before the 3.3 V constraint and the drive line): goodix-fp binds from the device tree on gpa7-6 with /dev/goodix_fp, and touch, keys and haptics are unaffected. Matching through the trusted app ran on the integration tree, which has the same node, and with no voltage constraint there the rail reads 3300000 uV. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
dd18680 to
1267286
Compare
|
Rebased onto today's |
|
Thank you, @W4HO-ham. The rebase is clean: one commit on today's Two small things before it comes out of draft:
On order: this and #164 both add to |
One commit of mine: the 9a's under-display fingerprint sensor node, on top of #161 (charger, on #119, on #96). It merges #101 for LDO15S and carries #147's binding and driver commits (edec836, b1e4b89) as they are in #147. The rest of #147 is the Pixel 7 Pro stack on another base.
The node is the gpa7 interrupt and the event line gpa7-6, reset on gpp1-0, and LDO15S always on. It has no SPI bus, because the integration tree and Google's source agree the secure world owns that bus. Every value comes from the integration DT, where the sensor answered and matched on 10-29.
Tested on the palmtop today, head b533af3. The kernel was defconfig + omarchy-mobile's fragment with omarchy-mobile#227, then
olddefconfig;uname -rwas7.3.0-rc6-omamobile-push1-gb533af3f1cbc. At boot, from the device tree:omamobile-fp.serviceandstorageproxyd.servicestayed masked for the whole boot, so nothing touched Trusty's secure storage. Matching through the HAL hasn't been run on this kernel; it needs the AoC/Trusty stack of #162 and the owner's go for the service.Why draft: it depends on #101 and #147, both still in review, and my commit needs the owner's sign-off. The DTB builds W=1 clean, and dt-validate shows 0 errors.