Repository navigation
arm64: dts: exynos: google: zumapro: Add USI10 and its I2C controller - #136
Conversation
|
Thank you, @W4HO-ham. This is exactly the piece I asked for, and it came quickly. What I checked:
CI is green on this head: checkpatch, W=1, dtbs_check and dt_binding_check all ran over the whole stack. My own gate run, merged onto today's It sits on #119 (its parent is #119's head |
|
Thanks for checking it line by line. Nothing more from my side; the board commit will enable both usi10 and hsi2c10 with its pins, as #127's does. |
|
Unchanged and still merge-ready in content; it waits on the stack below it. The status is in my note on #105. |
ddd3bab to
3f944cc
Compare
|
Rebased onto #119's new head (one commit, unchanged). Compiles; checkpatch clean. |
|
Same patch as the one I checked. It follows #119 wherever that lands. |
3f944cc to
6f469f5
Compare
|
Thanks, @W4HO-ham. It's the same patch as the one I checked on the 29th (its added and removed lines are identical), now on #119's new head. The gate passes merged onto today's Nothing more is needed. It merges right after #119. When #96 and #119 are in, a |
6f469f5 to
9712003
Compare
|
Thanks, @W4HO-ham. The rebase changed only the base: both commits are the same patches as before, so my last review stands, and the gate passes merged onto today's One step left: #161 has now landed #119's commit. This branch has its own copy of that commit, so please |
USI10 on PERIC1 carries the Pixel 9a's RT9470 (the USB OTG boost) at 0x5b. Add the USI and its HSI2C controller, disabled, with the clocks from CMU_PERIC1 (merged as "clk: samsung: zumapro: Add the PERIC1 USI10 clocks"), PERIC1 sysreg offset 0x8 and GIC SPI 658. The board enables it with its pins. Google's zumapro-usi.dtsi describes hsi2c_10 at 0x10CA0000 with IRQ_USI10_USI_PERIC1, SCL and SDA on gpp20-0 and gpp20-1, and the USI at sysreg_peric1 offset 0x8; the header defines IRQ_USI10_USI_PERIC1 as SPI 658. On the Pixel 9a the node, enabled by the board, bound hsi2c10 and talked to the RT9470. Link: https://android.googlesource.com/kernel/devices/google/zumapro/+/8831630eee2ad095b85ed452944e6353940966a5/dts/zumapro-usi.dtsi Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/include/dt-bindings/interrupt-controller/zumapro.h Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
9712003 to
28eb4eb
Compare
|
Thank you, @W4HO-ham. The branch is now the one commit, "Add USI10 and its I2C controller", and it's the same patch as before ( Merged with "Rebase and merge". |
The first piece of #127 on its own, as asked there: USI10 on PERIC1 and its HSI2C controller, disabled, on top of #119 (zumapro.dtsi comes from that stack; only the last commit is new). The board will enable it with its pins in a later commit, with the RT9470 node once its binding question is settled.
The node follows Google's zumapro-usi.dtsi (hsi2c_10 at 0x10CA0000, IRQ_USI10_USI_PERIC1, SCL/SDA on gpp20-0/1) and the interrupt number from the zumapro.h header in google-modules/soc/gs, both cited by commit in the message. The clocks are the merged PERIC1 USI10 ones (#102).
checkpatch --strict is clean. On the palmtop this node, enabled by the board overlay, bound hsi2c10 and talked to the RT9470 on 10-28 (USB-HOST-PLAN H3 on derekross/omarchy-mobile#136); nothing changes for the Pixel 7 Pro.