Skip to content

Pixel 9a (zumapro): the three cameras from the device tree - #164

Draft
W4HO-ham wants to merge 26 commits into
derekross:omamobilefrom
W4HO-ham:tegu-dt-cameras
Draft

W4HO-ham wants to merge 26 commits into
derekross:omamobilefrom
W4HO-ham:tegu-dt-cameras

Conversation

@W4HO-ham

@W4HO-ham W4HO-ham commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

This describes the 9a's cameras in the device tree, so they come up from a published kernel with no runtime overlays and no out-of-tree modules. It sits on #161 (charger, on #119, on #96) and merges #101 (S2MPG15, for LDO12S) and #103 (which contains #63, the gs201-csis zumapro path and the DC-PHY receiver). Both merges were clean. On top:

  • PMIC GPIO blocks: the S2MPG14 and S2MPG15 GPIO blocks (binding, the MFD cells, and gpio-s2mpg13 learning both chips). The cameras' power switches hang off them, and the published tree had no driver for them. These are ported from the integration tree's uncommitted changes.
  • ISP-FE sysreg: the zumapro ISP-FE sysreg binding entry.
  • zumapro.dtsi: the camera receiver (ISP-FE sysreg, DC-PHY, links 0, 1 and 6), disabled in the SoC file.
  • zumapro-tegu, camera power: the two PMIC GPIO blocks, LDO12S, the 1.35 V and main-camera switch regulators, the RT6160 and the SLG51002.
  • zumapro-tegu, the cameras: the three sensors, their buses, pins and endpoints, and the receivers turned on.
  • exynos-pmu, zuma: allow PMU 0x3ebc, the DC-PHY's isolation. The zuma PMU regmap only accepts listed registers, so without this every phy_power_on() failed with -EIO ("phy poweron failed --> -5") and no buffer could be queued.

Every node, address, IRQ, supply, voltage and pin comes from the integration DT, where all three cameras streamed on 10-27. The changes beyond that are layout only: SoC nodes moved into zumapro.dtsi, and pin groups renamed. One difference, now tested: the published tree runs the camera power chips' bus at 100 kHz (for the torch), where the integration tree ran 390 kHz; the boot of this head ran hsi2c4 at 100 kHz and all three cameras streamed.

Tested on the palmtop today, head 4023f58. The kernel was defconfig + omarchy-mobile's fragment with omarchy-mobile#227 and CONFIG_REGULATOR_RT6160=m, then olddefconfig; uname -r was 7.3.0-rc6-omamobile-push1-g4023f585ccae. The modules loaded from the device tree with nothing by hand: gpio_s2mpg13 rt6160_regulator slg51002_regulator phy_gs201_mipi_dcphy_rx gs201_csis imx386 s5kgn1. /dev/media0-2 and /dev/video0-2 appeared. cam -l (libcamera's simple pipeline) listed:

1: Internal back camera (/base/soc/usi@108c00c0/i2c@108c0000/camera@56)
2: Internal back camera (/base/soc/usi@108900c0/i2c@10890000/camera@1a)
3: Internal front camera (/base/soc/usi@108a00c0/i2c@108a0000/camera@1a)

cam -c N -s width=1280,height=960 --capture=3 captured 4915200-byte frames from each: the main camera at about 19 fps, the ultrawide and the front at about 30 fps. On the ultrawide, csis reported 8 frame starts, 7 frame ends, 6 WDMA done with 0 errors, and 0 AXI errors. There are 8 link errors (INT0 bit 3), one per frame, which the integration tree also showed; the frames are intact.

Why draft: it carries #101 and #103, which are still in review, and the commits need the owner's sign-off. dtbs_check (with a tolerant schema build, since dtschema 2026.04 crashes on the tree) shows 0 errors. W=1 builds of the DTB and the touched C files are clean. checkpatch --strict reports only the missing sign-off.

2026-11-01 update (review round): the PMU commit (0x3ebc) is now the first commit, ahead of everything that adds or enables the receiver. The gpio-s2mpg13 message says the S2MPG13's registers and bits are unchanged, and its header comment is rewrapped under 80 columns. The tree is identical to the booted head apart from that comment.

@derekross

Copy link
Copy Markdown
Owner

Thank you, @W4HO-ham. Three cameras coming up from the device tree alone, with every module loading on its own, is a big step for the 9a. The description shows exactly what ran: the release, the module list, cam -l, frame sizes and rates, and the csis counters including the link errors the integration tree also had. The push at 00:07 changed only messages: the tree is identical to 4023f585ccae, the head you booted.

CI: the run for this head was cancelled after an hour while the runner was still installing packages, before any check started, so that's the runner, not your branch. I'll re-run it. Locally, on today's omamobile, it merges cleanly: all 38 commits are signed off, checkpatch --strict reports no errors (four warnings to read: one 102-column line in the CSIS core commit and three MAINTAINERS notes), the ten touched C files build with W=1, and the device trees show no new warnings. My container has no dtschema, so dtbs_check and the binding checks wait for the re-run.

What I'd like changed:

  1. Move the PMU commit before the device-tree commits. "allow the camera receiver's PHY control" (0x3ebc) is the last commit, after the commits that add and enable the receiver and the cameras. Kernel PRs land commit by commit, so a bisect that stops between them gets cameras whose every phy_power_on() fails with -EIO, which is the bug that commit's message describes. Putting it first (or at least ahead of zumapro: Add the camera receiver) costs nothing. It merges cleanly with Pixel 9a (zumapro): the PCIe channel-1 host and Wi-Fi #168's 0x3ec8 in the same table.
  2. gpio-s2mpg13 is the Pixel 7 Pro's driver too. gs201-cheetah.dts has a samsung,s2mpg13-gpio node, and my camera bring-up overlays use it. Moving the constants into match data keeps cheetah's values exactly: s2mpg13_data is the old S2MPG13_GPIO_0_SET, S2MPG13_GPIO_STATUS and S2MPG13_GPIO_NUM, and with eight pins status + offset / 8 and BIT(offset % 8) are the old register and bit. Loads through match data change cheetah's object anyway, so besides that table I'll boot it once on my 7 Pro with my camera power overlay before merging. Please put that table in the commit message ("the S2MPG13's registers and bits are unchanged") so anyone reading the history sees it. While you're there, the reworded header comment has one line far past 80 columns ("register headers and its s2mpg1x GPIO driver. Only the output level…").
  3. pmic-2 collides with arm64: dts: exynos: google: zumapro-tegu: Add the fingerprint sensor #165. Both add pmic_sub: pmic-2 for the S2MPG15 to zumapro-tegu.dts, and the two PRs conflict there and in &pinctrl_peric0. Whichever lands second needs one node with this PR's gpio child and ldo12s plus arm64: dts: exynos: google: zumapro-tegu: Add the fingerprint sensor #165's ldo15s.

On the bus speed: your boot of this head ran hsi2c4 at 100 kHz, so the cameras did stream with the published tree's setting. If I've read that right, the description can say it's tested rather than "one untested difference".

On size and order: this carries #63, #103 and #101 through merge commits, so it lands after those and after #161, then rebased onto omamobile without the merges. If you'd like part of it reviewed sooner, the PMIC GPIO block (the binding, the MFD cells and gpio-s2mpg13) stands on its own on top of #101 and could be its own PR. It's your call; it's fine as one draft too.

@derekross

Copy link
Copy Markdown
Owner

7 Pro check done for the shared part: gpio: s2mpg13: Add the S2MPG14 and S2MPG15 with the two mfd: sec commits it needs, on my phone's integration kernel (7.3.0-rc6-omamobile-push1-g291da0df9327). The S2MPG13 GPIO driver registers, the camera start script loads it and brings up all four media devices, and libcamera lists four cameras. So nothing on the Pixel 7 Pro side holds this up; the review points above still stand.

@W4HO-ham

W4HO-ham commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Done:

  1. The PMU commit (0x3ebc) is now first, ahead of the GPIO block and everything that adds or enables the receiver, so no bisect point has cameras without it.
  2. gpio-s2mpg13: the message now says the S2MPG13's registers and bits are unchanged (s2mpg13_data is the old S2MPG13_GPIO_0_SET, S2MPG13_GPIO_STATUS and S2MPG13_GPIO_NUM, and with eight pins status + offset / 8 and BIT(offset % 8) are the old register and bit). The long header line is rewrapped. Thanks for booting it on the 7 Pro.
  3. pmic_sub with arm64: dts: exynos: google: zumapro-tegu: Add the fingerprint sensor #165: noted. Whichever lands second gets the one combined node, and I'll do that rebase when the first is in.

The description now says the 100 kHz bus is tested. The tree is identical to the booted head (4023f585ccae) apart from the rewrapped comment, and checkpatch is quiet on the changed commits. I'll keep it as one draft.

@derekross

Copy link
Copy Markdown
Owner

Thank you, @W4HO-ham. All three points are done, and I checked each against the new head:

  1. "allow the camera receiver's PHY control" (0x3ebc) now comes before the GPIO block and before "zumapro: Add the camera receiver", so no commit in the series has the receiver without it.
  2. The gpio: s2mpg13 message now carries the S2MPG13 table, and the header comment is rewrapped. The only change to the tree since the head you booted (4023f585ccae) and since the head I tested on my 7 Pro is that comment, so both runs still stand.
  3. The pmic_sub plan with arm64: dts: exynos: google: zumapro-tegu: Add the fingerprint sensor #165 is noted.

The description now says the 100 kHz bus is tested, which matches your boot.

One thing to know for the combined pmic_sub node: on #165 I've had to correct my LDO15S request. #101's LDOs can't set a voltage, so a min = max pin either writes nothing (if the rail already reads that voltage) or fails the whole sub-PMIC's probe, LDO12S included. Your ldo12s has no voltage limits, so it's not affected. Whatever #165 settles on for ldo15s goes into the combined node as it is.

On the checks: the commit checks pass on this head (all 38 commits signed off, checkpatch --strict with no errors; the one 102-column line in the CSIS core commit is still there if you want it). It doesn't merge onto today's omamobile yet, which is expected: it still carries the old copies of #96, #119 and #161 and #101's previous head through merges. So the order stands: #63 and #103, then #101 and #161, then a rebase onto omamobile without the merge commits, with the combined pmic_sub node if #165 is already in. After that rebase I'll run the builds and the binding checks again.

The Tensor G4 (zumapro) camera front end has the same Samsung DC-PHY
receiver with nine slaves for its twelve CSIS links, the clock lane
first on each and one reset bit per slave. Add its compatible; the PHY
cell is the CSIS link.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
zumapro's DC-PHY slaves sit at 0x1c100000 with the bias block at +0x1000
as on gs201, but every slave has its clock lane first and up to four data
lanes (three C-PHY trios) after it, and three slaves are a clock lane
only, which links 4 and 6 enable next to their own in four-lane D-PHY
mode. The layout comes from the Pixel 9a camera HAL's register table and
Google's GPL zuma DT; the reset bits are one per slave in the ISP-FE
system registers at +0x500.

Make the link layout per SoC with the reset bits and the partner clock
lane in it, and add zumapro's four-lane links (0, 1, 2, 4 and 6). The
data file format is unchanged.

On the Pixel 9a, link 1 (the ultrawide IMX712, four lanes at
1105.92 Mbps) powers on with settle 55, and the CSIS link receives about
30 frames a second with no SOT, CRC or ECC errors.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
zumapro has the same CSIS link (version 0x08010000 against gs201's
0x05040000, the same register layout) with twelve link contexts, but a
different DMA path. Add its compatible with the link registers and the
link interrupt only.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
zumapro's CSIS link has gs201's layout, but its frames reach memory
through the ISP front end's CSIS core, which this driver doesn't drive
yet. Add a zumapro match that maps the link only and always runs as
link_only does: PHY, link and sensor, counting frames, with no WDMA, no
routing and none of gs201's CSIS sysreg accesses (an unknown sysreg word
aborted gs201).

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
On zumapro a link's frames reach memory through the ISP front end's CSIS
core, one page shared by all links, with one interrupt for all of them.
Describe it as an optional second register range and interrupt of a
zumapro link, with the image logical channel the link writes through.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
zumapro's CSIS core takes a link's data type on one virtual channel into
an image logical channel (LoCH) and writes it to memory through its Bayer
WDMA. The register layout and fields come from the Pixel 9a camera HAL's
register table and value packers and, for the interrupt bits, Google's
GPL zuma ISP event description.

Route the link's channel 0 into a LoCH, write packed RAW10 (or RAW8) at
the stride the video node set, and program the batch slot at each start
of frame only: a configuration written during a frame is a late config
and stops the LoCH, so frames with no queued buffer go to a scratch
buffer. A status queue page takes the LoCH's per-frame record.

The link differs from gs201 in three bits the zumapro HAL sets or clears:
pixel mode 3, CMN_CTRL bit 12, and DBG_OPTION_SUITE cleared. gs201 sets
DBG_OPTION_SUITE bit 23, and with it the link hands out unpacked 16-bit
words, which gs201's WDMA expects; zumapro's core reads them as packed
RAW10 and scrambles every pixel.

On the Pixel 9a the ultrawide's solid colour test pattern (R 1023, Gr 0,
B 341, Gb 682) reads back exactly in RAW10 and RAW16, and libcamera's
simple pipeline streams it at 30 fps.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Pixel 9a main camera is a Samsung part with model ID 0x08e8 that
takes the GN1's register layout and data file, with a second auxiliary
supply and its digital supply switched by the board.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Pixel 9a main camera (model 0x08e8) powers up as stock's module power
sequence has it: the interface supply, two 2.9 V auxiliary supplies, the
analog and the digital supply, reset released, then the clock and 10 ms.
Its soft reset goes through the direct page, its standard registers too,
and its horizontal addresses count pixels. Its initialisation and modes
come from the data file, as for the other parts.

On the Pixel 9a it identifies at 0x56 and streams 2000x1128 over three
C-PHY trios.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
All zumapro links write through image LoCH 0, so a stream that stopped
with the LoCH in error (the main camera's first C-PHY attempts) left it
taking a few frames and then nothing for the next link. Disable, abort
and clear the LoCH before routing it. Count the core interrupts each link
handles in debugfs, with the last aggregate and processing sources.

Bring-up parameters for the link and the core (pixel and parallel mode,
CMN_CTRL bits, LoCH data type and memory format) stay for the C-PHY work.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
zumapro's camera software never writes the link's PHY_CMN_CTRL: its PHY
lanes are enabled in the DC-PHY transaction. Write it on gs201 only. The
ultrawide and front cameras stream as before without it.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
…ocks

A zumapro link takes the INT DVFS domain, the rail of the ISP front end's
NOC clock, and that clock, as "int" and "fe". gs201 keeps its "cam" and
"int" DVFS domains.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
ABL leaves the ISP front end's NOC clock at a sixth of SHARED3 (111 MHz).
The Pixel 9a main camera's three C-PHY trios at 2740 Msps (18.8 Gbps)
overrun the front end at that rate: the link reports ERR_DESKEW_OVER and
the LoCH a size mismatch and stream error, with a few hundred bytes of
each frame in memory. At 332 MHz every frame lands whole.

Take the INT DVFS domain (the clock's rail, through ACPM) and the front
end clock as "int" and "fe", and raise both while a link streams, the
rail first, restoring them in reverse afterwards.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Pixel 9a's ultrawide and front cameras are Sony IMX712s (model
0x0712), with the IMX386's register map and their own initialisation and
modes in the data file.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Pixel 9a's ultrawide and front cameras answer with model 0x0712 at the
IMX386's chip ID register and take the same CCS-style register map. Take
the expected model ID from the compatible, for the probe's check and the
data file's header. Both cameras stream 4208x3072 RAW10 on four D-PHY
lanes on the palmtop with their data file from the 9a's camera HAL.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
…used define

The LoCH interrupt registers' offsets are also in Google's GPL
zuma-isp-event-info.dtsi, not only their bits: say so. ZP_STRIDE_ALIGN
was never used (CSIS_STRIDE_ALIGN, 64, already covers it).

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
…roles

The GN8's power-up order is rear_main_camera_power_seq in Google's GPL
zuma-tegu-camera.dtsi, which also names ldo5 and ldo4 as the actuator's
and OIS's AVDD and AF_VM (the sensor's own being ldo1 and vdig). Replace
the open question with that; both stay required, as the module's
sequence powers them before the sensor.

Link: https://android.googlesource.com/kernel/devices/google/tegu/+/6276884d9940694b25a6934671918ec8ac412ee8/dts/zuma-tegu-camera.dtsi
Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
None of gs201-csis, the MIPI DC-PHY receiver or the S5KGN1 and IMX386
sensor drivers had an entry. Add one block for the four and their
bindings.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
On the Pixel 9a the first capture after switching cameras came back
empty whenever the previous stream ran on a D-PHY link (the ultrawide
or the front camera) and worked: the new link received its frames,
but the LoCH raised no interrupt and wrote nothing. The next capture
on the same link worked.

The LoCH's EN_STATUS register (0x0a8, named in the camera HAL's
register table) shows why. After a stream that stopped cleanly it
still reads active with the old link in its low bits (0x106 after link
6, 0x101 after link 1), and every failing start began that way, every
good start with it clear. The abort at route time didn't clear it,
because the LoCH ignores an abort while it is disabled.

So when the LoCH is still active, enable it (its DMA is already off)
for the abort, and disable it afterwards. Nine captures in a row,
switching between all three cameras in every order, now all write
frames; before, about half of the switches failed.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The zuma PMU regmap only accepts listed registers. The MIPI DC-PHY receiver
isolates its PHY through PMU offset 0x3ebc, which was not listed, so every
phy_power_on() returned -EIO and no camera buffer could be queued on the
Pixel 9a ("phy poweron failed --> -5" for each queued buffer).

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Describe the general purpose pins of the Tensor G4's two PMICs as a
gpio child node, as for the S2MPG13: six on the S2MPG14 main PMIC and
ten on the S2MPG15 sub-PMIC.

On the Pixel 9a they switch the camera power: the S2MPG15's pins enable
the camera buck-boost, select the camera PMIC and enable the cameras'
1.35 V supply, and one S2MPG14 pin switches the main camera's digital
supply (Google's GPL zumapro camera device trees).

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Give both Tensor G4 PMICs a gpio regmap on ACPM access type 0x0c and a
gpio cell, as the S2MPG13 has. The regmaps read the interrupt masks,
the status and the per-pin SET registers and write only the SET
registers; the clear-on-read interrupt registers stay out.

The register layout is from Google's GPL s2mpg14-register.h and
s2mpg15-register.h: six pins on the S2MPG14, ten on the S2MPG15 with
their status in two registers. On the Pixel 9a these pins switch the
camera power.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Tensor G4's PMICs have the S2MPG13's pin control registers, with
the same output level and output enable bits, at other offsets: six
pins on the S2MPG14 and ten on the S2MPG15, whose input levels take two
status registers. Describe each chip's SET base, status register and
pin count in match data, and take it from the platform id when the
device has no OF node.

On the Pixel 9a the S2MPG15's pins enable the camera buck-boost, select
the camera PMIC and enable the cameras' 1.35 V supply, and an S2MPG14
pin switches the main camera's digital supply. Run there with the
integration tree: the sub-PMIC's ten SET registers read 0x40 (output,
low) at hand-off, and all three cameras power up through these pins.
Register layouts from Google's GPL s2mpg14 and s2mpg15 register headers.

The S2MPG13's registers and bits are unchanged: its match data is the
old constants (set_base S2MPG13_GPIO_0_SET, status S2MPG13_GPIO_STATUS,
ngpio S2MPG13_GPIO_NUM), and with eight pins `status + offset / 8` and
`BIT(offset % 8)` are the old status register and bit.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Tensor G4's ISP front end, which holds the camera receiver links and
the MIPI DC-PHY slaves, has a system register block of its own. The
DC-PHY driver releases each slave's reset through it (offset 0x500, one
bit per slave), as gs201's does through the CSIS sysreg.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Add the ISP front end's camera receiver: its system registers, the MIPI
DC-PHY with its nine slaves, and receiver links 0, 1 and 6, the ones the
Pixel 9a's main, ultrawide and front cameras use. Each link has its own
registers and interrupt and shares the CSIS core, through which frames
reach memory; it streams with the INT DVFS domain and the ISP-FE NOC
clock raised.

The bootloader leaves the ISP front end powered and its gates on, and
nothing describes its power domain or CMU yet. Everything stays
disabled; a board enables what it wires.

Addresses, interrupts and the slave reset bits from Google's GPL zuma
device trees (zuma-isp.dtsi) and isp_fe.h, checked on the 9a, where all
three links have streamed.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Describe the Pixel 9a's camera supplies as stock's board description
has them: the RT6160 buck-boost (PP3200_CAM_BB) and the SLG51002 camera
PMIC on hsi2c4, enabled and selected by the S2MPG15's GPIO 1 and 0;
the 1.35 V rail on the S2MPG15's GPIO 2; the sensors' shared 1.8 V on
S2MPG15 LDO12S; and the main camera's digital supply, a switch on the
S2MPG14's GPIO 0. This adds the sub-PMIC and both PMICs' GPIO blocks.

Nothing is always on: every rail stays off until a sensor driver powers
its camera. Run on the 9a with the integration tree, where all three
sensors power up and stream through these supplies.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Describe the Pixel 9a's three cameras and wire them to their receiver
links: the main camera, a Samsung GN8, on hsi2c5 and three C-PHY trios
into link 0; the ultrawide, a Sony IMX712, on hsi2c2 and four D-PHY
lanes into link 1; and the front camera, a second IMX712, on hsi2c3 and
four lanes into link 6. Each sensor has its own master clock from
CMU_TOP, its reset line and its supplies in stock's power-up order.

Buses, pins, pulls, resets, master clock outputs and supplies follow
stock's board description and Google's GPL zuma-tegu-camera.dtsi and
zumapro-pinctrl.dtsi. The sensor modes and the DC-PHY receive settings
aren't public: they are data files taken from the owner's own phone.

All three cameras stream on the 9a through libcamera with these nodes.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
@W4HO-ham

W4HO-ham commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto today's omamobile tip (1a9d1d4), now 6d0a35e, 26 commits. Two conflicts in zumapro-tegu.dts, both resolved by keeping both sides: the tip's pmic-2 (the AoC's sensor rails) and this PR's sub-PMIC are one pmic_sub: pmic-2 node with the GPIO child and ldo5s, ldo7s, ldo12s; and the tip's &usi4_hsi0 and this PR's &usi5 both stay. W=1 on the eight touched objects (gpio-s2mpg13, imx386, s5kgn1, gs201-csis, sec-acpm, sec-common, phy-gs201-mipi-dcphy-rx, gs101-pmu) and on zumapro-tegu.dtb: 0 warnings. checkpatch --strict has two notes from before the rebase, a 102-column line in the csis patch and the MAINTAINERS reminder for the new file; say if you want the line wrapped.

@derekross

Copy link
Copy Markdown
Owner

Thank you, @W4HO-ham. The rebase looks right: 26 commits with no merges, the first 18 identical to #63 and #103, and your own eight unchanged apart from context and the zumapro-tegu.dts resolution. Keeping the AoC's LDO5S and LDO7S in the same pmic_sub node is what I'd have done. The gate passes on today's omamobile and CI is green, including dtbs_check and the seven bindings.

What it waits for is on my side: the 7 Pro camera capture for #63 and #103, which I promised on 10-28 and haven't done yet. Those two change cheetah's camera receiver, DC-PHY and IMX386 objects, so they merge after that run, and then this one. Your gpio-s2mpg13 commit is the same patch I ran on my 7 Pro on 11-01, so it needs nothing more.

Before it comes out of draft, could you boot this head once? The cameras' GPIO child and LDO12S now share the sub-PMIC with the AoC's rails, which no boot has run yet. cam -l with one capture per camera and the AoC up as usual, with the release in the camera commit's message, would do. The 102-column line is in #63's commit, so leave it unless that one changes anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants