Repository navigation
arm64: dts: exynos: google: zumapro-tegu: Add the NFC controller - #105
Conversation
|
Thank you. I checked the new nodes against Google's tegu and zumapro DTs: gpa7's SPIs 36-43 are stock's One fix: On merging: this PR carries #100's and #104's commits as well as the board stack. My plan is to merge #100 and #104 on their own first, then the board stack, and then ask you to rebase this onto A note for tegu's NFC notes, not for this PR: the hog keeps the whole ST54L powered, eSE included, even with NFC switched off. That's fine for now, but worth writing down with the power numbers. |
|
Thanks, the two blank lines are gone ( This PR still carries #100's and #104's commits unchanged, so it lands after those two, which are waiting on their own threads (the exact-build NFC run, and the comment fixes in |
|
Nothing has changed here since my last look, and the stack still merges cleanly and passes the gate on today's |
|
Thanks for the rebase. One correction: the four #104 commits here are the same patches as #104's head from 10-28 ( |
|
Rebased onto #104's clock-out rework, on #96's current head, so only my two DT commits remain on top of #104 ("The PMU provides clocks" and the NFC controller). The PMU node keeps |
|
Thanks, @W4HO-ham. This is now just your two device-tree commits on top of #104's rework and #96, and the tree is exactly the one you booted. Your release's hash, What I checked:
Two small things in the messages before it lands:
On order: this lands after #96 and #104. Once both are in, a |
|
Thanks for the rebase, @W4HO-ham. All nine commits are the same patches as before, so the tree is still the one you booted, and the gate passes merged onto today's The rebase went up a few minutes after my last comment, so I think the two message points crossed it. Both are still open in the head:
The order is unchanged: this lands after #104, and whichever of this and #161 goes second takes the |
|
Thank you, @W4HO-ham. Both message points are done: "The PMU provides clocks" now says Tensor G4 (zumapro), and "Add the NFC controller" says the card read was on the earlier version of the series, with the other provider. The tree is the same as before. #104 has landed, so this needs one more I tried that rebase locally: the two commits, with the conflict resolved that way, pass the gate merged onto today's |
The Tensor G4 (zumapro) PMU provides the NFC controller's clock pad as clock 0; give its node #clock-cells. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Pixel 9a's ST54L sits at 0x08 on hsi2c9, its interrupt on gpa7-5 (level high), its RST_N on gph1-6, and its reference clock from the PMU's clock pad. Its chip enable (gpa0-1) powers the whole chip and is held high by a hog: stock's eSE driver raises it, and nothing here drives the eSE. Tested on the Pixel 9a: on this tree the controller probes on nxp-nci and neard polls with the clock enabled, with no I2C errors. The read of a contactless card (ISO-DEP over NFC-A) was on the earlier version of the series, which took the clock from a different provider. Link: https://android.googlesource.com/kernel/devices/google/tegu/+/6276884d9940694b25a6934671918ec8ac412ee8/dts/zuma-tegu-nfc.dtsi Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
|
Rebased onto |
|
Thank you, @W4HO-ham, for the quick rebase. The two commits are the same patches as before. The only change is the context next to On today's I'll rebase-merge it. Thank you for seeing this one through #104's rework. |
|
Merged. Thanks, @W4HO-ham. |
This is the Pixel 9a's NFC in the device tree. It is stacked on the DT series (#80, #81, #85, #87, #90, #96), on #100 (ST54L) and on #104 (the PMU clock pad), so only the last two commits are new:
#clock-cells = <1>on the PMU (clock 0 is the NFC pad, soc, nfc: the Pixel 9a's NFC clock pad as a PMU clock #104).st,st54lwith thenxp,nxp-nci-i2cfallback;clocks = <&pmu_system_controller 0>;The board DT builds with W=1 (no new warnings) and
dt-validatereports nothing for these nodes on today'somamobile. On the 9a, the same nodes in my integration tree probe on nxp-nci, poll, and read a contactless card through neard (#100).