Skip to content

mfd: sec: s2mpg14: Add the PMIC interrupt and the RTC alarm - #55

Merged
derekross merged 4 commits into
derekross:omamobilefrom
W4HO-ham:tegu-s2mpg14-irq
Nov 1, 2026
Merged

derekross merged 4 commits into
derekross:omamobilefrom
W4HO-ham:tegu-s2mpg14-irq

Conversation

@W4HO-ham

Copy link
Copy Markdown
Contributor

The S2MPG14's PMIC interrupt for the Pixel 9a: the S2MPG12 arrangement (five clear-on-read INT registers, in-band through IBIM1, latched by the SoC's VGPIO2AP block, GIC SPI 74), an irq chip in sec-irq.c after the S2MPG12's, the interrupt block and the IBIM registers in the ACPM regmaps, and the RTC cell's alarm resource, so rtc-s5m enables the alarm.

Stacked on #54: the first two commits are that PR's, the last two are this one's (binding first, driver second). CI tests the merge of all four; once #54 lands this rebases to the two.

Tested on the Pixel 9a: /proc/interrupts shows the s2mpg14-pmic chip behind GIC SPI 74, a 15 s wakealarm on rtc0 fires (count advances by one, alarm clears), the line stays at zero otherwise, and the LDOs and the clock behave as before. The device tree side (interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>, google,vgpio2ap-sysreg, wakeup-source, a syscon@15090000 node) is in my local tegu DT batch; the binding now requires the interrupt and the sysreg phandle, as the S2MPG12's does. checkpatch --strict is clean apart from the const warning the S2MPG12 chip copy gets too, W=1 clean, dt-doc-validate and yamllint pass.

@derekross

Copy link
Copy Markdown
Owner

Thanks for this. It's a clean follow-on to the RTC work, and it reuses the
S2MPG12 arrangement rather than inventing a new one, which makes it easy to
review. I checked the numbers against Google's tegu sources. SPI 74 matches
IRQ_INTCOMB_VGPIO2AP_ALIVE in zumapro.h, the sysreg is 0x15090000 + 0x290, the INT/INTM/IBIM offsets match s2mpg14-register.h, and the IBIM1
PMIC bit is bit 0. The ack-then-bulk-read order is the same as Google's
s2mpg14-irq.c. I also built sec-irq.o, sec-acpm.o and sec-common.o
before and after, with inlining off, and compared them function by
function. The S2MPG12 and S2MPG13 paths are unchanged, so nothing moves for
the Pixel 7 Pro or the Fold. The gate passes on the merge with the current
omamobile, and CI's binding check passes.

A few things before I merge:

  1. Three interrupt bits don't match Google's driver. In irq.h,
    S2MPG14_IRQ_WLWP_ACC_MASK is BIT(4), but s2mpg14-irq.c has
    1 << 7. SMPL_TIMEOUT and WTSR_TIMEOUT are BIT(1) and BIT(2), but
    Google has 1 << 5 and 1 << 6. (The S2MPG12 copy here has 7, 5 and 6
    too.) The register header's enum gives the order of the sources but not
    their bit positions. regmap-irq only masks bits it knows about, so as it
    stands the real masks for those three are left as the bootloader set
    them, while bits 4 of INT3M and 1-2 of INT5M get set instead. Could you
    fix the three masks and cite drivers/mfd/s2mpg14-irq.c with a Link:
    for the layout? If you want to match Google's init exactly, writing
    0xff to INT1M-INT5M before adding the chip would also cover the bits
    regmap-irq leaves alone, but that's optional.
  2. Please open only IBIM1 for writes. The driver writes IBIM1 and
    nothing touches IBIM2, so I'd keep it out of the write table (and the
    read table, unless you need to read it), as we did for the RTC registers
    on rtc: s5m: Add the S2MPG14 (Pixel 9a) RTC #54.
  3. One boot of the final head on the 9a, with uname -r, grep s2mpg14 /proc/interrupts before and after a wakealarm, dmesg | grep -iE 's2mpg14|rtc', and the tools/phone-smoke report. Since the 9a's
    DT isn't public yet, please paste the PMIC node and the
    syscon@15090000 node you booted with. If the 9a doesn't suspend yet,
    just say so; the wake from suspend can come later.

Smaller things, no need to block on them:

  • With no_irq gone, a DT without interrupts (or with a missing
    sysreg) now fails the whole PMIC probe, so the touch and eUSB2 LDOs go
    too. Nothing in the tree uses the S2MPG14 node yet, so this breaks no DT
    here. But please say it in the binding commit, since anyone on an older
    9a DT would lose those rails. If you'd rather keep the rails independent
    of the interrupt, carrying on without the IRQ chip when interrupts is
    absent would do it. Your call.
  • The syscon@15090000 node will need a google,zumapro-vgpio2ap-sysreg
    compatible in samsung,exynos-sysreg.yaml when the DT goes in.
  • The binding's description could mention the in-band interrupt and the
    VGPIO2AP latch, as S2MPG12's does.
  • When you narrow the RTC table on rtc: s5m: Add the S2MPG14 (Pixel 9a) RTC #54, this PR's sec-acpm.c hunk will
    need a small rebase, since it has that comment as context. I'll merge rtc: s5m: Add the S2MPG14 (Pixel 9a) RTC #54
    first and then this one, rebased to its two commits.

Thanks again. The alarm test with the interrupt count is exactly the kind
of evidence I like to see.

@W4HO-ham

Copy link
Copy Markdown
Contributor Author

Thanks for checking the bits against Google's driver. Reworked on top of the updated #54 (so the sec-acpm.c context matches), four commits again:

  1. The three masks now match s2mpg14-irq.c: WLWP_ACC is BIT(7) of INT3, SMPL_TIMEOUT and WTSR_TIMEOUT are BIT(5) and BIT(6) of INT5. The commit cites the file with a Link: at the commit I checked (204078758737 in google-modules/soc/gs). I also took the optional part: INT1M-INT5M get 0xff before the chip is added, as Google's init does.
  2. IBIM2 is gone from the read and write tables, and from s2mpg14.h. The common regmap now stops at IBIM1.
  3. Binding: the description now says how the in-band interrupt reaches the host through the VGPIO2AP latch, worded as in S2MPG12's. The commit message says that a DT without interrupts or the sysreg phandle now fails the whole PMIC probe and loses the touchscreen LDOs. I kept the interrupt required for now; if you'd rather the rails survive without it, I can make the IRQ chip optional.
  4. Noted on google,zumapro-vgpio2ap-sysreg for when the DT goes in.

checkpatch --strict shows two warnings on the driver commit: the Link: line's length, and "regmap_irq_chip should normally be const" for the per-device copy that gets handle_pre_irq. The S2MPG12 path does the same. The binding commit is clean, dt_binding_check passes for the schema, and the four mfd/rtc objects build with W=1.

The boot of this head on the 9a waits for the palmtop, which needs a power-key restart this morning. Then I'll post the /proc/interrupts counts around a wakealarm, dmesg, phone-smoke and the two DT nodes. The 9a suspends now, so I'll include a wake from suspend by the RTC alarm too.

@W4HO-ham

Copy link
Copy Markdown
Contributor Author

Booted this head's interrupt code on the palmtop, same kernel as in my #54 comment (7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty).

The wakealarm from Linux. GIC 106 is SPI 74:

before:
 55:  6 ...  GICv3          106 Level  s2mpg14-pmic
 56:  3 ...  s2mpg14-pmic    10 Edge   rtc-alarm0
echo +15 > /sys/class/rtc/rtc0/wakealarm; sleep 18
after:
 55:  8 ...  GICv3          106 Level  s2mpg14-pmic
 56:  4 ...  s2mpg14-pmic    10 Edge   rtc-alarm0

The 9a suspends now (s2idle), so I tested the wake too. systemctl suspend with a 25 s RTC alarm slept and woke on its own. Afterwards /sys/power/pm_wakeup_irq read 55, the s2mpg14-pmic interrupt, so the RTC alarm wakes the 9a through this chip. rtc-alarm0 went from 1 to 2, and suspend_stats showed 2 successes and 0 failures.

The two nodes I booted with, from our integration board file:

&soc {
	sysreg_vgpio2ap: syscon@15090000 {
		compatible = "google,zumapro-vgpio2ap-sysreg", "syscon";
		reg = <0x0 0x15090000 0x1000>;
	};
};

&pmic_main {	/* samsung,s2mpg14-pmic, under the ACPM firmware node */
	interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
	google,vgpio2ap-sysreg = <&sysreg_vgpio2ap>;
	wakeup-source;
};

phone-smoke passes every required check, as on #54.

@derekross

Copy link
Copy Markdown
Owner

Thanks, all three points are in. I checked the masks against Google's s2mpg14-irq.c at the commit you link: WLWP_ACC 1 << 7 in INT3, SMPL_TIMEOUT 1 << 5 and WTSR_TIMEOUT 1 << 6 in INT5, and the 0xff to INT1M-INT5M before the chip is added is the same first step Google's init takes. IBIM2 is gone from the header and both tables, the pmic write table covers the mask registers the new loop writes, and the binding now says how the interrupt reaches the host and what a device tree without it loses. Keeping the interrupt required is fine with me; no device tree in the tree has the node yet. The gate and CI pass on today's omamobile; the two checkpatch warnings are the Link: length and the per-device chip copy, which the S2MPG12 path gets too.

What's left is the 9a boot of this head, as for #54: uname -r, grep s2mpg14 /proc/interrupts before and after a wakealarm, dmesg | grep -iE 's2mpg14|rtc', hwclock -r and a hwclock -w with a read-back, the tools/phone-smoke report, and the PMIC and syscon@15090000 nodes. An RTC-alarm wake from suspend would be a nice bonus now that the 9a suspends. One boot covers both PRs, since this head carries #54's two commits as they are.

Once that's posted I'll land them. Either #54 first and this one rebased to its two commits, or all four commits from here in one go with #54 closed as landed through this PR; I'll pick whichever is less work for you at the time.

@W4HO-ham

Copy link
Copy Markdown
Contributor Author

The 9a results for this head, with one caveat about which kernel ran them.

What didn't work: I built this head on its own (omamobile + #54 + #55, the int tree's config) and booted it with the integration DTB. It stayed on the Google logo with no SSH and nothing in pstore, so I flashed slot B back. I think the cause is the base, not these commits: omamobile alone doesn't have the clocks and UFS work still in review (#73-#79, #57, #83), so a kernel of just this head can't reach root on the 9a.

What ran: the integration kernel the palmtop runs, 7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty, carries this PR's review head as is (its round rv1 took #54/#55 at the commits you checked). On it:

7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty
== interrupts before
 56: 0 0 0 0 0 0 0 0 GICv3 106 Level s2mpg14-pmic
 57: 0 0 0 0 0 0 0 0 s2mpg14-pmic 10 Edge rtc-alarm0
== interrupts after a 5 s wakealarm
 56: 2 0 0 0 0 0 0 0 GICv3 106 Level s2mpg14-pmic
 57: 1 0 0 0 0 0 0 0 s2mpg14-pmic 10 Edge rtc-alarm0
== kernel
[    0.226693] s5m-rtc s2mpg14-rtc: registered as rtc0
[    0.226961] s5m-rtc s2mpg14-rtc: setting system clock to 2026-10-28T16:00:39 UTC (1793203239)
== hwclock
2026-10-28 09:01:39.218902-07:00
2026-10-28 09:01:40.002540-07:00
== s2idle with an RTC wake (30 s)
success 0 -> 1, wake irq 56

The PMIC's interrupt (GIC SPI 74, 106 in /proc/interrupts) fires on the alarm, its rtc-alarm0 child counts it, hwclock reads and writes, and a 30 s s2idle wakes on IRQ 56, the PMIC's line. That's the RTC-alarm wake from suspend you mentioned.

The nodes it booted with (from the DTB the palmtop booted):

			pmic-1 {
				compatible = "samsung,s2mpg14-pmic";
				status = "okay";
				interrupts = <0x00 0x4a 0x04>;
				google,vgpio2ap-sysreg = <0x13>;
				wakeup-source;

				regulators {

					ldo4m {
						regulator-name = "touch-avdd";
						status = "okay";
					};

					ldo8m {
						regulator-name = "eusb-vdd";
						status = "okay";
					};

					ldo9m {
						regulator-name = "eusb-vdda12";
						status = "okay";
					};

					ldo19m {
						regulator-name = "eusb-repeater-vdd";
						status = "disabled";
					};

					ldo25m {
						regulator-name = "touch-vdd";
						status = "okay";
					};
				};

				gpio {
					compatible = "samsung,s2mpg14-gpio";
					gpio-controller;
					#gpio-cells = <0x02>;
				};
			};
		syscon@15090000 {
			compatible = "google,zumapro-vgpio2ap-sysreg", "syscon";
			reg = <0x00 0x15090000 0x1000>;
		};

If you'd rather have a boot of exactly this head, it needs a base with the clocks and UFS in it. I can build one on #87's stack (which has #80's tree) plus these four commits, if that counts for you.

@derekross

Copy link
Copy Markdown
Owner

Thank you for both reports. I'm sorry I asked twice: your 27 October boot crossed my comment. The results are what this PR should give. The PMIC's line (SPI 74) fires on the alarm, rtc-alarm0 counts it, hwclock reads and writes, and a 30 s s2idle wakes on IRQ 56. Thank you for the suspend wake as well.

You don't need to build a kernel of exactly this head. Your integration tree is fine, as long as I can see that it carries this PR's code. Its release is -dirty and its name says S2MPG15, so I expect #101's changes are in the same files. Could you post git diff 40e3397dedd3 HEAD -- Documentation/devicetree/bindings/mfd/samsung,s2mpg14-pmic.yaml drivers/mfd/sec-acpm.c drivers/mfd/sec-common.c drivers/mfd/sec-irq.c drivers/rtc/rtc-s5m.c include/linux/mfd/samsung/irq.h include/linux/mfd/samsung/s2mpg14.h from the tree you booted? If the only hunks are #101's, that settles it. (A side note: #57, #79 and #83 are already in omamobile, so whatever stopped the bare-base boot is something else. This PR doesn't need to chase it.)

One thing I found while checking the merge order, and it matters before this lands. The board stack (#80 up to #96, and #122 on top) describes pmic-1 without interrupts and without google,vgpio2ap-sysreg. With this PR, sec-acpm calls platform_get_irq() for the S2MPG14, and sec_irq_init_s2mpg14() needs the sysreg, so on that device tree the PMIC probe fails. Its regulators then never register, and the eUSB2 PHY (vdd-supply = <&eusb_vdd>, vdda12-supply = <&eusb_vdda12>) and the touchscreen wait for them forever. The 9a would come up without USB. The branches merge without a conflict. If this PR lands after the board stack, no check catches it either, because a bindings and driver change doesn't validate the boards' device trees. You didn't see it because your integration DTB has the nodes.

Two ways to fix it; either is fine with me:

  1. Give tegu's device tree the syscon@15090000 VGPIO2AP node (with google,zumapro-vgpio2ap-sysreg added to samsung,exynos-sysreg.yaml) and the three pmic-1 properties you booted with. That goes in the board stack, or in a device-tree commit in this PR once the stack is in, placed before the driver commit, so that no commit boots the 9a without them. I'd then land this right after it.
  2. Keep the interrupt optional in the driver. With no interrupts, the PMIC registers as it does today, without the RTC alarm, and the binding drops the two from required. You offered this earlier, and it lets the board stack and this PR land in either order.

When it's in, I'll rebase-merge this PR's four commits and close #54 as landed through it, so you don't need to rebase. The checks pass on today's omamobile (clean merge, sign-offs, checkpatch with the same two notes as before, W=1). On the Pixel 7 Pro's config, sec-acpm.o and sec-common.o change only in their tables. sec-irq.o gains the new S2MPG14 path in sec_irq_init. In rtc-s5m.o the only code change is the S2MPG14 bit added to the switch masks, so the S2MPG12 paths are unchanged.

The S2MPG14's RTC block sits at ACPM access type 0x02 and has the same
register layout as the S2MPG10's (CTRL at 0x00 through OSC_CTRL at 0x1b,
two nonces to 0x2b, five scratch registers to 0x30), per Google's GPL
rtc-s2mpg14.h. Describe it as an uncached "rtc" regmap over the ACPM bus,
let the PMIC regmap read STATUS2 (the alarm flag, bit 2 as on S2MPG12),
and add the s2mpg14-rtc cell. No interrupt line is described yet, so the
cell carries no alarm resource.

The regmap reads up to OSC_CTRL and writes only what rtc-s5m writes:
CTRL, UPDATE, the time and alarm 0. SMPL, WTSR, CAP_SEL and OSC_CTRL
(the power-loss and watchdog-reset protections and the oscillator
tuning) and the nonces stay read-only.

Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/refs/heads/android-gs-tegu-6.1-android16/include/linux/mfd/samsung/rtc-s2mpg14.h
Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The S2MPG14 (Pixel 9a main PMIC) keeps its RTC in the S2MPG10 layout,
reached through the "rtc" regmap the sec-acpm driver now provides, so it
takes the S2MPG10 register table. Its alarm flag is STATUS2 bit 2 in the
PMIC regmap, as on the S2MPG12. Without a PMIC interrupt line the device
comes up with the alarm feature cleared, as a time-only clock.

On the Pixel 9a the RTC registers as rtc0 and the system clock is set
from it at boot:

  s5m-rtc s2mpg14-rtc: registered as rtc0
  s5m-rtc s2mpg14-rtc: setting system clock to 2026-10-26T13:28:26 UTC

Tested on the Pixel 9a: rtc0 registers at boot, hwclock reads and sets
the time, systemd-timesyncd writes the synchronized time back, and the
time survives reboots and a power-key reset.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The S2MPG14 reports its PMIC events in-band, and the Tensor G4's VGPIO2AP
block raises them as one level interrupt that stays pending until written
back, the same arrangement the S2MPG12 binding describes. Add the
interrupt, the phandle to the VGPIO2AP system registers and
wakeup-source, and say how the interrupt reaches the host.

Unlike on the S2MPG12, the interrupt stays optional. The PMIC's rails
(the touchscreen and eUSB2 supplies) work without it, and the Pixel 9a
and Pixel 8 Pro device trees describe the PMIC without one; a board that
leaves it out only loses the PMIC's events, the RTC alarm among them.
The interrupt can't be acknowledged without the sysreg, so it depends on
the phandle, and wakeup-source, which means nothing without the
interrupt, depends on the interrupt.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The S2MPG14 (Pixel 9a main PMIC) has the S2MPG12's five PMIC interrupt
registers, INT1-INT5 at 0x00-0x04 clearing on read with their masks at
0x05-0x09, routed in-band through IBIM1 and latched by the SoC's VGPIO2AP
block, which the AP sees as GIC SPI 74. Google's GPL driver gives the
bit layout (s2mpg14-irq.c, with the order of the sources in
s2mpg14-register.h).

Add the interrupt chip after the S2MPG12's: mask every source first (all
eight bits of INT1M-INT5M, as Google's driver does, since regmap-irq only
masks the bits it knows), then request the line, acknowledge the
VGPIO2AP latch before each status read and unmask only the PMIC source
in IBIM1 (nothing handles the power meter, and its regmap is not
exposed). The ACPM regmaps grow the interrupt block, with INT1-INT5
precious, and IBIM1, the only common register the driver writes and so
the only writable one. The RTC cell gets its alarm resource, so the
rtc-s5m driver enables the alarm it was built with.

The interrupt stays optional, as the binding allows: the Pixel 9a and
Pixel 8 Pro device trees describe the PMIC without it, and the PMIC's
regulators supply the eUSB2 PHY and the touchscreen, so failing the
probe would take USB down with it. Without an interrupt the driver
writes none of the interrupt registers and registers the RTC without
the alarm resource (there is no IRQ domain to map it into), as before
this change. The other PMICs keep their paths.

Tested on the Pixel 9a: /proc/interrupts lists the s2mpg14-pmic chip
behind GIC SPI 74, a 15 s wakealarm on rtc0 fires (the interrupt count
advances by one and the alarm clears), the line stays at zero otherwise,
and the LDOs and the clock behave as before.

Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/mfd/s2mpg14-irq.c
Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
@W4HO-ham

W4HO-ham commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for catching the merge-order problem. I went with your second option (head 6907464, rebased onto today's omamobile, since the S2MPG15 commits conflicted in sec-acpm.c and sec-irq.c).

The S2MPG14 now takes its interrupt with platform_get_irq_optional(). Without interrupts, sec_irq_init_s2mpg14() returns before it looks up the syscon or writes any interrupt register, and the RTC is registered without its alarm resource. That last part matters: otherwise mfd_add_devices with a NULL domain would turn the alarm resource into Linux IRQ 10. So a board DT like today's tegu one probes the PMIC exactly as before. The binding drops interrupts and google,vgpio2ap-sysreg from required, and adds dependencies: interrupts needs the sysreg phandle, and wakeup-source needs interrupts. The S2MPG10 and S2MPG12 paths keep platform_get_irq(), and S2MPG13/15 keep no_irq. Comparing objects, s2mpg12_irq_ack_vgpio is identical and sec_pmic_acpm_probe differs only by the optional branch. W=1 is clean on the four touched objects at every commit, dt_binding_check is clean, and dtbs_check on the google DTBs gives byte-identical output at base and head.

The boot of this head on the palmtop, 7.3.0-rc6-omamobile-push1-gc04142279ef4 (no -dirty), with the tegu DTB built from this tree, whose pmic-1 has only compatible and regulators (no interrupt, no sysreg phandle, no VGPIO2AP node):

sec-pmic-acpm firmware:power-management:pmic-1: no interrupt, so no RTC alarm
s5m-rtc s2mpg14-rtc: registered as rtc0
s5m-rtc s2mpg14-rtc: setting system clock to 2026-11-01T21:21:49 UTC (1793568109)

hwclock -r read 14:24:22.94 at 14:24:23. hwclock -w returned 0, and the read-back gave 14:24:23.00. There's no rtc-alarm0 in /proc/interrupts, as expected. tools/phone-smoke passed every required row (boot, storage guard, kernel health with no oops, BUG or WARN, USB), and touch, display and the rest came up as on omamobile. The three failed units are the daily kernel's out-of-tree helper modules refusing this release. The alarm path with the interrupt nodes is the one you saw on 10-27 and 10-28. It needs the VGPIO2AP node in the board DT, which can follow as its own DT commit.

The two reworked commits (the binding and the driver) carry my sign-off again; the first two are unchanged.

@derekross

Copy link
Copy Markdown
Owner

Thank you, @W4HO-ham. Making the interrupt optional is a good way to do it, and thank you for the boot of this exact head with no -dirty.

What I checked on 6907464fb178:

  • The no-interrupt path. platform_get_irq_optional() maps only -ENXIO to "no interrupt" and passes -EPROBE_DEFER and other errors on. sec_irq_init_s2mpg14() returns before the syscon lookup and before any register write. The RTC cell then comes up without its alarm resource, which avoids the NULL-domain mapping you pointed out, and rtc-s5m already treats a missing alarm IRQ as "no alarm" (platform_get_irq_byname_optional(), -ENXIO → 0). The wake setup in sec-common.c skips a zero IRQ. So today's Pixel 9a and Pixel 8 Pro device trees probe the PMIC as before, and your log ("no interrupt, so no RTC alarm", rtc0 registered, hwclock read and write) shows that.
  • The binding. Dropping the two from required and adding dependencies (interrupts needs the sysreg phandle, wakeup-source needs interrupts) describes the hardware correctly. CI's dt_binding_check and dtbs_check pass.
  • The other PMICs. S2MPG10 and S2MPG12 keep platform_get_irq(), and S2MPG13/15 keep no_irq. On the Pixel 7 Pro (S2MPG12) the only code change in sec_pmic_acpm_probe() is the new branch, which its data doesn't select.
  • Gate on today's omamobile: a clean merge, all four commits signed off, W=1 builds of the four touched C files, and checkpatch --strict with one note, the CONST_STRUCT on the chip you copy with devm_kmemdup(). That's expected, since the copy is what lets you set irq_drv_data. It also merges cleanly with the other open 9a PRs.

I'll rebase-merge the four commits and close #54 as landed through this one, as I said.

For later, not for this PR: the 9a gets its RTC alarm and PMIC wake once its device tree has the VGPIO2AP syscon@15090000 node (with google,zumapro-vgpio2ap-sysreg added to samsung,exynos-sysreg.yaml) and the three pmic-1 properties you booted with on 10-28. A small DT PR whenever you like.

@derekross
derekross merged commit 4a100f6 into derekross:omamobile Nov 1, 2026
1 check passed
@derekross

Copy link
Copy Markdown
Owner

Merged. Thanks, @W4HO-ham.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants