Repository navigation
Conversation
b69bf0e to
3cccd46
Compare
|
Thanks for this. Thermal zones and CPU DVFS together make the 9a properly usable. I checked it against Google's
One change before merging:
And on the order: this needs #86 and #84 in first. Once #84 has its id header, please use the names for Smaller things:
|
3cccd46 to
c2ce1fd
Compare
|
Thanks. Pushed:
#86 is merged and #84 is under the stack, so this builds on its own now. With #89's and #95's bindings added, |
|
Thanks for working through all of these. I think the last push didn't reach this branch, though. #80, #81 and #85 were force-pushed at 20:19Z, but this PR's head is still The commits you describe do exist: they're
So it only needs For landing the stack, I'll merge #84 now. Once the 9a has booted this tree (see #80), please rebase onto |
c2ce1fd to
3a64a1c
Compare
|
A correction: the branch head I pushed for this at 13:18 was the stack from before the rebase onto the Tensor G4 clock ids (#84), with numeric ACPM clock ids. The version my earlier reply describes (named |
3a64a1c to
8c2caf5
Compare
|
Thanks, this branch has the right commits now: the little table stops at 1950 MHz, the clusters use Since #84 and #89 are merged, the stack can now land in one go from its top, #96. The plan is on #80; nothing more is needed on this PR itself. |
8c2caf5 to
463e1f8
Compare
|
The stack is rebased on today's |
|
Thanks. I checked it: the only change across the stack is the board commit's message, and every tree is the same as before. One correction, though: |
463e1f8 to
caf61d0
Compare
Turn on CMU_G3D and the Mali-G715 for the Pixel 9a, with its core clock on ACPM's paired "gpu" clock (index 17), which sets the shader (G3D) and L2 (G3DL2) domains together, and coregroup and stacks on CMU_G3D's gates. The operating points are the shader rates of the 9a's GPU DVFS table up to 649 MHz. The levels above it, to 940 MHz, wait for a GPU thermal zone, since nothing throttles the GPU yet. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Give the three CPU clusters their ACPM DVFS clocks (cpucl0-2, by the zumapro ACPM clock ids) and operating points for cpufreq-dt, with capacities and power coefficients for the energy model from Google's zumapro-cpu.dtsi, and add the ACPM TMU sensor and the big, mid, little and GPU thermal zones. The CPU levels are the APM firmware's own (its DVFS table, read on the Pixel 9a), up to the 9a's thermal headroom: 1950 MHz little (Google's max-freq for that cluster), 2367 MHz mid and 2687 MHz big. The little cluster's 324 and 610 MHz lie below stock's 820 MHz floor. Each CPU zone throttles its cluster from 80 C, forces the cluster's lowest levels from 95 C and shuts down at 105 C, all below stock's 112 C (CPU) and 115 C (GPU) hot trips. gpu-thermal throttles panthor's devfreq from 85 C. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
… MHz With gpu-thermal throttling the GPU, add the 9a's GPU levels above 649 MHz: 723, 807, 850 and 890 MHz. The table's top, 940 MHz, stays out until it has run on the 9a. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
caf61d0 to
3eed6ec
Compare
|
Rebased onto today's omamobile: the SoC, board, binding and touchscreen commits below this one are all in your branch now, so what remains is the GPU enable, the CPU DVFS and thermal zones, and the GPU's levels to 890 MHz. The board device tree compiles and checkpatch --strict is clean on all three. |
|
Thanks for the rebase. Same patches and trees as before, and the gate passes on today's |
…zone Add zuma's TMU sensor under acpm_ipc and a gpu-thermal zone on its G3D sensor (3). It throttles panthor's devfreq from 85 C and shuts down at 105 C, as derekross#87 proposes for zumapro, below the stock Pixel 8 Pro's own GPU trips (passive from 100 C, hot at 115 C). For that, the GPU node gets #cooling-cells. Assisted-by: LLM Signed-off-by: Brett-Michael Green <brett@bmgvisualtech.com>
Run the three CPU clusters on their ACPM DVFS clocks (cpucl0-2) through cpufreq-dt, and add thermal zones for them on the ACPM TMU's big, mid and little sensors (0-2): - the operating points are the ACPM firmware's own levels, read from the ECT the bootloader leaves at 0x90000000, up to each cluster's max-freq in stock's exynos-acme domains: 1704 MHz little, 2367 MHz mid and 2914 MHz big. The ECT's little levels up to 1704 MHz are the ones stock's cpufreq statistics list; - the dynamic power coefficients are stock's (70, 513 and 757), with #cooling-cells for cpufreq cooling; - the levels above stock's battery current limiter caps (1945 MHz mid, 2294 MHz big, from Google's zuma-shusky-bcl.dtsi) are turbo-mode, as on gs201: with no BCL driver nothing pulls the clusters down when the battery voltage droops, so they are only used with boost enabled; - a CPU zone throttles its cluster from 80 C, forces its lowest level from 95 C and is critical at 105 C, as derekross#87 proposes for zumapro. The ACPM clock ids header moves from the board to zuma.dtsi. Assisted-by: LLM Signed-off-by: Brett-Michael Green <brett@bmgvisualtech.com>
Run the three CPU clusters on their ACPM DVFS clocks (cpucl0-2) through
cpufreq-dt, and add thermal zones for them on the ACPM TMU's big, mid
and little sensors (0-2):
- the operating points are the ACPM firmware's own levels, read from
the ECT the bootloader leaves at 0x90000000, up to each cluster's
max-freq in stock's exynos-acme domains: 1704 MHz little, 2367 MHz
mid and 2914 MHz big. The ECT's little levels up to 1704 MHz are the
ones stock's cpufreq statistics list;
- the energy model is stock's: each level's opp-microwatt is its power
in the default pixel-em profile of Google's zuma-b0-ipop.dts, which
the Pixel 8 Pro's own device tree has too. A dynamic power
coefficient can't be used, since the firmware sets the voltages and
there is no opp-microvolt: with one, the energy model fails to
register ("EM: invalid perf. state: -22"). The CPUs get #cooling-cells
for cpufreq cooling;
- the levels above stock's battery current limiter caps (1945 MHz mid,
2294 MHz big, from Google's zuma-shusky-bcl.dtsi) are turbo-mode, as
on gs201: with no BCL driver nothing pulls the clusters down when the
battery voltage droops, so they are only used with boost enabled;
- a CPU zone throttles its cluster from 80 C, forces its lowest level
from 95 C and is critical at 105 C, as derekross#87 proposes for zumapro.
The ACPM clock ids header moves from the board to zuma.dtsi.
Assisted-by: LLM
Signed-off-by: Brett-Michael Green <brett@bmgvisualtech.com>
|
Its patches landed unchanged through #96, so I'm closing this one. Thanks! |
Run the three CPU clusters on their ACPM DVFS clocks (cpucl0-2) through
cpufreq-dt, and add thermal zones for them on the ACPM TMU's big, mid
and little sensors (0-2):
- the operating points are the ACPM firmware's own levels, read from
the ECT the bootloader leaves at 0x90000000, up to each cluster's
max-freq in stock's exynos-acme domains: 1704 MHz little, 2367 MHz
mid and 2914 MHz big. The ECT's little levels up to 1704 MHz are the
ones stock's cpufreq statistics list;
- the energy model is stock's: each level's opp-microwatt is its power
in the default pixel-em profile of Google's zuma-b0-ipop.dts, which
the Pixel 8 Pro's own device tree has too. A dynamic power
coefficient can't be used, since the firmware sets the voltages and
there is no opp-microvolt: with one, the energy model fails to
register ("EM: invalid perf. state: -22"). The CPUs get #cooling-cells
for cpufreq cooling;
- the levels above stock's battery current limiter caps (1945 MHz mid,
2294 MHz big, from Google's zuma-shusky-bcl.dtsi) are turbo-mode, as
on gs201: with no BCL driver nothing pulls the clusters down when the
battery voltage droops, so they are only used with boost enabled;
- a CPU zone throttles its cluster from 80 C, forces its lowest level
from 95 C and is critical at 105 C, as derekross#87 proposes for zumapro.
The ACPM clock ids header moves from the board to zuma.dtsi.
Assisted-by: LLM
Signed-off-by: Brett-Michael Green <brett@bmgvisualtech.com>
Stacked on #85, #81 and #80. It needs #84 (
clk-acpmzumapro) and #86 (merged). Only the last two commits are new.zumapro.dtsi:acpm_ipc(google,zumapro-acpm-tmu);zumapro-tegu.dts: with that throttle in place, the GPU levels 723-890 MHz.The CPU tables stop at each cluster's thermal headroom on the 9a: 1954 MHz little, 2367 MHz mid, 2687 MHz big. The higher ACPM levels are listed in a comment. Unthrottled, eight loaded cores took the X4 to 105 C in 4 s at 3105 MHz. The GPU's 940 MHz top level stays out until it has run on the 9a.
Against the palmtop: the CPU nodes, the three CPU tables, the sensor and all four zones match the DTB it boots now, property for property, with phandles resolved. That DTB already has the TMU node under ACPM, round th1 for #86. The GPU table is the one it runs, minus the bootloader's 159.744 MHz point. It runs all of this through #84's
clk-acpmand #86's TMU driver: cpufreq on three policies, four zones with their cooling maps, and the GPU moving through 150-890 MHz under load.CHECK_DTBS=y W=1forzumapro-tegu.dtbis clean (with #86's binding), and checkpatch --strict is clean on both commits.