Repository navigation
Conversation
This was referenced Sep 14, 2026
tang-vu
marked this pull request as ready for review
September 15, 2026 01:32
This was referenced Sep 16, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for independent review (2026-09-15). Candidate
20d5c22d3c12bbde1ab4ee354945a7067b1425afhas a successful GitHub check rollup and no base-branch conflict at this review snapshot. This supersedes earlier draft-status wording only. All validation gaps, migration requirements, live gates and independent human review requirements below remain in force; this is not a merge-ready approval.Summary
Provide an installed Aider launcher that selects the extension Compose file, ODS environment and
/venv/bin/aiderexecutable. Update every advertised launch hint in the extension, templates and dashboard.Why this matters
Aider's installation container intentionally uses
entrypoint: [echo]and exits successfully. ODS nevertheless tells users to rundocker compose run --rm aider, which invokes that echo stub again. It also omits the installed extension's Compose file. In the shipped image, the advertised--versioncommand reports GNU echo's version; the new launcher reportsaider 0.86.2.The invariant is that installation retains its one-shot receipt, while an explicit interactive launch reaches Aider with unchanged caller arguments and the correct
data/aiderproject mount.Overlap check
Searched open/closed Aider and
aider entrypointPRs, historical/current Compose paths, README, templates and dashboard hints. #896 introduces the intentional echo entrypoint. #1090 implements the one-shot installed status and explicitly records that its advertised command still hits echo. Neither provides the working launcher. This completes that documented handoff without replacing either lifecycle change.Validation
$HOME/backticks in user arguments, and reject a wrong working directory before invoking Docker: 2 passed.20d5c22d, Aider v0.86.2 digestsha256:0d54037f6c97c85a926ebc3c903e27446f5bca96823d9f68902f1e623289b556: real Compose runs reproduced the GNU echo output before and Aider version output after. The fixture used a private internal network and was removed. No model request or project edit was performed.make gatereproduces the known root-WSL no-sudo fixture failure.Compatibility and rollback
Run from the ODS install directory; Windows users use the ODS WSL terminal. Bash arguments and Docker Compose are shared across Linux/macOS/WSL. There is no stored-data or service lifecycle migration. Revert the launcher and its hints together. The final batch integration will combine the additive Makefile call and dashboard changes with the other candidates.
Final candidate
20d5c22d3c12bbde1ab4ee354945a7067b1425af: 32 successful CI checks, 4 conditionally skipped; no pending or failed checks.Batch integration receipt
This is one of 30 independently branched public-beta PRs. The published synthetic integration head is
61f4c6fccc81bea697f4941683fefb5089ba77f4, built from baselined49ad4bbc760be319de7f4c9b9a93b1f18fe3922in this reproducible order:#4946 → #4948 → #4951 → #4954 → #4972 → #4960 → #4961 → #4957 → #4964 → #4967 → #4968 → #4971 → #4975 → #4976 → #4984 → #4982 → #4990 → #4988 → #4989 → #4997 → #5003 → #5006 → #5007 → #5009 → #5012 → #5011 → #5013 → #5014 → #5020 → #5021
Reconciliation preserved all 146 files owned by a single PR byte-for-byte against their exact candidate heads. The eight shared paths preserve both CLI STT/TTS commands and help, every added Makefile test, both environment schema additions and all Extensions UI behavior. LanguageTool and Kroki both remain headless API entries. Canonical regeneration yields 76 catalog entries and 47 library manifests; all README rows are retained. Shared-file changes need these additive resolutions when merged independently.
Combined validation: 2,852 API tests passed / 1 skipped; 1,082 UI tests passed; 47 manifests passed; all 12 added Makefile commands passed; 12 catalog boundary tests passed / 12 opt-in runtime tests skipped in this combined run. Individual exact-image results remain documented above. UI lint/build, scoped secret hooks, diff checks, four platform smoke tests and installer simulation passed. Compose plans for NVIDIA/AMD/Apple each contain 20 services and no duplicate published bindings across the core plus 12 new recipes; this is static plan evidence, not simultaneous startup or GPU inference.
The first unrestricted UI run timed out in two tests under concurrent load; the complete rerun used
--maxWorkers=2with unchanged assertions and timeouts and passed. ESLint reports zero errors and 603 warnings, including the existing JSX usage-detection pattern. Full localmake gatestill fails the no-sudo Docker baseline covered by #3158. BATS records 416 passed / 5 failed on this root/WSL host (platform detection, root preflight and a 15 GiB versus 20 GiB free-space expectation). Neither full local gate nor BATS is described as green.This integration receipt supplements each PR's own regression and does not waive its independent review, live hardware/browser/upgrade gates or rollback requirements. The PRs remain drafts; none was merged upstream.