Repository navigation
Conversation
This was referenced Sep 14, 2026
tang-vu
marked this pull request as ready for review
September 15, 2026 01:31
# Conflicts: # ods/Makefile
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for independent review (2026-09-15). Candidate
d156f21a16152cb48056dd86680a799b8995b344has a successful GitHub check rollup and no base-branch conflict at this review snapshot. This supersedes earlier draft-status wording only. All validation gaps, migration requirements, live gates and independent human review requirements below remain in force; this is not a merge-ready approval.Why this matters
Scripts can list local Kokoro voices and turn text or standard input into a complete WAV using the installed
odsCLI, without an SDK or hand-written JSON. The shared Linux/WSL CLI gainsods tts voicesandods tts speak TEXT OUTPUT.wav [--voice VOICE], help, completion and concrete usage documentation.Contract and design
TTS_PORTthrough the existing safe environment loader. Send literal Unicode/text only to127.0.0.1; preserve output paths relative to the caller. No redirects, automatic service start or audio playback.stream=false. The real-image test caught this. Request documented 24 kHz mono signed 16-bit PCM and create a finalized WAV header locally with Python's standard library..env-> loopback Kokoro request -> complete PCM response -> finalized WAV -> private atomic file publication. Rollback removes the subcommands/helper; previously generated WAVs remain ordinary files.Overlap check
Searched open/closed PRs for TTS CLI, speech CLI, synthesis and voice discovery, plus the changed CLI/completion paths and new helper/test filenames. #2499 is an n8n voice workflow; #4976 adds the complementary STT transcription command. #2832 owns TTS server memory/temp-storage tuning and the existing README voice-route correction; those hunks are intentionally excluded here. #2183 owns broader completion parity, and integration must preserve both its existing commands and this new
ttscommand. No existing CLI speech-file client was found.Validation
d156f21a: real CPU synthesis 1 passed in 509.14 seconds (25-live-pcm) on Linux amd64 under WSL; generated WAV has complete 24 kHz mono 16-bit frames, a nonzero signal and mode 0600.ghcr.io/remsky/kokoro-fastapi-cpu:v0.2.4@sha256:c8812546d358cbfd6a5c4087a28795b2b001d8e32d7a322eedd246e6bc13cb55, retaining the production two workers, 1 CPU and 4 GiB recipe. It checks actual voice discovery, synthesis through the CLI, WAV framing/sample rate/nonzero signal, file mode and cleanup.git diff --checkpassed. Full localmake gatestill fails the pre-existing no-sudo Docker promotion/raw-sudo contract covered by fix(installer): honor unavailable sudo in Docker fallback #3158; no full local gate pass is claimed. A path-filtered workflow runs both boundary and real-image synthesis tests.Review and limits
Latest-head CI: 33 successful checks, 4 conditionally skipped, including real CPU synthesis. Awaiting independent review. No GPU, native macOS/Windows, every voice/language, audio listening assessment, concurrent load or non-hard-link filesystem was tested. Valid PCM samples prove a structurally complete file, not speech quality or the semantic completeness of the server's spoken text.
Final candidate
d156f21a16152cb48056dd86680a799b8995b344: 33 successful CI checks, 4 conditionally skipped; no pending or failed checks.Batch integration receipt
This is one of 30 independently branched public-beta PRs. The published synthetic integration head is
61f4c6fccc81bea697f4941683fefb5089ba77f4, built from baselined49ad4bbc760be319de7f4c9b9a93b1f18fe3922in this reproducible order:#4946 → #4948 → #4951 → #4954 → #4972 → #4960 → #4961 → #4957 → #4964 → #4967 → #4968 → #4971 → #4975 → #4976 → #4984 → #4982 → #4990 → #4988 → #4989 → #4997 → #5003 → #5006 → #5007 → #5009 → #5012 → #5011 → #5013 → #5014 → #5020 → #5021
Reconciliation preserved all 146 files owned by a single PR byte-for-byte against their exact candidate heads. The eight shared paths preserve both CLI STT/TTS commands and help, every added Makefile test, both environment schema additions and all Extensions UI behavior. LanguageTool and Kroki both remain headless API entries. Canonical regeneration yields 76 catalog entries and 47 library manifests; all README rows are retained. Shared-file changes need these additive resolutions when merged independently.
Combined validation: 2,852 API tests passed / 1 skipped; 1,082 UI tests passed; 47 manifests passed; all 12 added Makefile commands passed; 12 catalog boundary tests passed / 12 opt-in runtime tests skipped in this combined run. Individual exact-image results remain documented above. UI lint/build, scoped secret hooks, diff checks, four platform smoke tests and installer simulation passed. Compose plans for NVIDIA/AMD/Apple each contain 20 services and no duplicate published bindings across the core plus 12 new recipes; this is static plan evidence, not simultaneous startup or GPU inference.
The first unrestricted UI run timed out in two tests under concurrent load; the complete rerun used
--maxWorkers=2with unchanged assertions and timeouts and passed. ESLint reports zero errors and 603 warnings, including the existing JSX usage-detection pattern. Full localmake gatestill fails the no-sudo Docker baseline covered by #3158. BATS records 416 passed / 5 failed on this root/WSL host (platform detection, root preflight and a 15 GiB versus 20 GiB free-space expectation). Neither full local gate nor BATS is described as green.This integration receipt supplements each PR's own regression and does not waive its independent review, live hardware/browser/upgrade gates or rollback requirements. The PRs remain drafts; none was merged upstream.