Repository navigation
Conversation
This was referenced Sep 14, 2026
tang-vu
marked this pull request as ready for review
September 15, 2026 01:30
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for independent review (2026-09-15). Candidate
6c8a5566aaff7d653db87d20966211e1c931a0e7has a successful GitHub check rollup and no base-branch conflict at this review snapshot. This supersedes earlier draft-status wording only. All validation gaps, migration requirements, live gates and independent human review requirements below remain in force; this is not a merge-ready approval.Why this matters
Add an optional local audio library for audiobooks, recordings and generated speech. Operators can organize source audio, stream authenticated byte ranges and retain listening progress through container replacement using the existing Extensions lifecycle.
Contract
Overlap check
Searched open and closed PRs for Audiobookshelf and the new recipe/test production paths in the changed-file inventory; no implementation was found. #5012 generates speech through the CLI; this independently stores and serves an operator's audio library with listening progress. Trilium #5013 manages hierarchical notes, not playback. Port 7833 has no existing manifest/Compose collision. Shared catalog and library README changes are additive and will be checked on the batch integration head.
Validation
28-live, 199.21 seconds pytest; 214.71 seconds runner). Generate an eight-second MP3 with the shipped encoder, initialize the actual owner account, reject anonymous/wrong-password access, create and scan a Unicode library, start authenticated direct playback, verify HTTP 206 bytes and Content-Range against the source file, save progress, recreate the container, and retrieve the same library/playback/progress. Verify unchanged source bytes and clean up fixture containers/network.git diff --checkpassed.make gatereproduces the existing no-sudo Docker promotion/raw-sudo failure covered by fix(installer): honor unavailable sudo in Docker fallback #3158. No full local gate pass is claimed. The added path-filtered CI runs the exact-image HTTP/storage contract.Review and limits
Candidate
6c8a5566aaff7d653db87d20966211e1c931a0e7: 33 successful CI checks, 4 conditionally skipped, including the real audio contract. Awaiting independent review of first-run ownership and durable storage. Runtime evidence covers Linux amd64; image metadata advertises amd64/arm64. Browser/mobile playback, transcoding, podcast downloads, online metadata matching, large libraries and existing-database upgrades were not tested. Health and API checks do not establish browser usability. No merge is requested before the declared live/review gates are resolved.Final candidate
6c8a5566aaff7d653db87d20966211e1c931a0e7: 33 successful CI checks, 4 conditionally skipped; no pending or failed checks.Batch integration receipt
This is one of 30 independently branched public-beta PRs. The published synthetic integration head is
61f4c6fccc81bea697f4941683fefb5089ba77f4, built from baselined49ad4bbc760be319de7f4c9b9a93b1f18fe3922in this reproducible order:#4946 → #4948 → #4951 → #4954 → #4972 → #4960 → #4961 → #4957 → #4964 → #4967 → #4968 → #4971 → #4975 → #4976 → #4984 → #4982 → #4990 → #4988 → #4989 → #4997 → #5003 → #5006 → #5007 → #5009 → #5012 → #5011 → #5013 → #5014 → #5020 → #5021
Reconciliation preserved all 146 files owned by a single PR byte-for-byte against their exact candidate heads. The eight shared paths preserve both CLI STT/TTS commands and help, every added Makefile test, both environment schema additions and all Extensions UI behavior. LanguageTool and Kroki both remain headless API entries. Canonical regeneration yields 76 catalog entries and 47 library manifests; all README rows are retained. Shared-file changes need these additive resolutions when merged independently.
Combined validation: 2,852 API tests passed / 1 skipped; 1,082 UI tests passed; 47 manifests passed; all 12 added Makefile commands passed; 12 catalog boundary tests passed / 12 opt-in runtime tests skipped in this combined run. Individual exact-image results remain documented above. UI lint/build, scoped secret hooks, diff checks, four platform smoke tests and installer simulation passed. Compose plans for NVIDIA/AMD/Apple each contain 20 services and no duplicate published bindings across the core plus 12 new recipes; this is static plan evidence, not simultaneous startup or GPU inference.
The first unrestricted UI run timed out in two tests under concurrent load; the complete rerun used
--maxWorkers=2with unchanged assertions and timeouts and passed. ESLint reports zero errors and 603 warnings, including the existing JSX usage-detection pattern. Full localmake gatestill fails the no-sudo Docker baseline covered by #3158. BATS records 416 passed / 5 failed on this root/WSL host (platform detection, root preflight and a 15 GiB versus 20 GiB free-space expectation). Neither full local gate nor BATS is described as green.This integration receipt supplements each PR's own regression and does not waive its independent review, live hardware/browser/upgrade gates or rollback requirements. The PRs remain drafts; none was merged upstream.