Repository navigation
Conversation
This was referenced Sep 14, 2026
tang-vu
marked this pull request as ready for review
September 15, 2026 01:31
This was referenced Sep 16, 2026
added 2 commits
September 17, 2026 11:12
# Conflicts: # ods/extensions/services/dashboard/src/pages/Extensions.jsx
The languagetool manifest exposes LANGUAGETOOL_PORT as a user-settable port override, but the key was missing from .env.schema.json, so validate-env rejected the documented setting as unknown.
1 of 2 tasks
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for independent review (2026-09-15). Candidate
d69a89993269fde0d50883f96980114875d64601has a successful GitHub check rollup and no base-branch conflict at this review snapshot. This supersedes earlier draft-status wording only. All validation gaps, migration requirements, live gates and independent human review requirements below remain in force; this is not a merge-ready approval.Why this matters
ODS writing tools and automations currently have no optional local spelling/grammar endpoint. Add a complete LanguageTool recipe reachable through the existing extension catalog/install lifecycle, with documentation for
/v2/languagesand/v2/check. The dashboard labels it as an API service rather than advertising a nonexistent editor.Contract and implementation
meyay/languagetool:6.8-10@sha256:d9f15384ea3febbe9b24ed9cfc05e912c5154d031354397e5de5e699cb15cd6b(LanguageTool 6.8; upstream tag inspected). It is not an official hosted/premium LanguageTool service.pixel-inferencemanifest. It does not enable that service.Overlap check
Searched open and closed upstream PRs for
LanguageTool, grammar checking/proofreading, and the new production recipe paths; no matching service exists. Reviewed sharedExtensions.jsx, catalog generator and library README path history. #1613 covers a general headless metadata/link contract; this PR uses the existing headless-service mechanism for one new API service and does not replace that work. #4961 (Aider launch guidance), #4982 (credential instructions), and #4997 (Frigate HTTPS) touch shared catalog/UI surfaces but preserve independent behaviors. Combined validation will retain all four changes.Validation
21-live-network, 318.50 seconds of pytest). Validated healthy startup, loopback HTTP language discovery, real spelling/grammar matches and replacements, invalid-language rejection and the 20,000-character limit, then container replacement and repeated checks.Internal=truenetwork. Real HTTP requests via the image'swgetstill returned spelling and grammar replacements; no model/generation functions were stubbed. Both fixture containers and networks were cleaned up.git diff --checkpassed.make gateretains the recorded WSL/root no-sudo baseline failure, separately addressed by existing fix(installer): honor unavailable sudo in Docker fallback #3158; a local full-gate pass is not claimed. The new path-filtered CI job runs the real Docker/API test.Review and limits
Awaiting independent recipe review and CI. The image advertises amd64/arm64, but live evidence here is Linux amd64 under WSL only. Native Windows/macOS, ARM, real editor/browser integration and large-language workloads are unverified. Supplemental statistical models, hosted premium rules and automatic downloads are not included. API clients must be explicitly configured; remote exposure requires the operator's protected network/TLS setup. No authentication is supplied by this upstream API.
Final candidate
d69a89993269fde0d50883f96980114875d64601: 33 successful CI checks, 4 conditionally skipped; no pending or failed checks.Batch integration receipt
This is one of 30 independently branched public-beta PRs. The published synthetic integration head is
61f4c6fccc81bea697f4941683fefb5089ba77f4, built from baselined49ad4bbc760be319de7f4c9b9a93b1f18fe3922in this reproducible order:#4946 → #4948 → #4951 → #4954 → #4972 → #4960 → #4961 → #4957 → #4964 → #4967 → #4968 → #4971 → #4975 → #4976 → #4984 → #4982 → #4990 → #4988 → #4989 → #4997 → #5003 → #5006 → #5007 → #5009 → #5012 → #5011 → #5013 → #5014 → #5020 → #5021
Reconciliation preserved all 146 files owned by a single PR byte-for-byte against their exact candidate heads. The eight shared paths preserve both CLI STT/TTS commands and help, every added Makefile test, both environment schema additions and all Extensions UI behavior. LanguageTool and Kroki both remain headless API entries. Canonical regeneration yields 76 catalog entries and 47 library manifests; all README rows are retained. Shared-file changes need these additive resolutions when merged independently.
Combined validation: 2,852 API tests passed / 1 skipped; 1,082 UI tests passed; 47 manifests passed; all 12 added Makefile commands passed; 12 catalog boundary tests passed / 12 opt-in runtime tests skipped in this combined run. Individual exact-image results remain documented above. UI lint/build, scoped secret hooks, diff checks, four platform smoke tests and installer simulation passed. Compose plans for NVIDIA/AMD/Apple each contain 20 services and no duplicate published bindings across the core plus 12 new recipes; this is static plan evidence, not simultaneous startup or GPU inference.
The first unrestricted UI run timed out in two tests under concurrent load; the complete rerun used
--maxWorkers=2with unchanged assertions and timeouts and passed. ESLint reports zero errors and 603 warnings, including the existing JSX usage-detection pattern. Full localmake gatestill fails the no-sudo Docker baseline covered by #3158. BATS records 416 passed / 5 failed on this root/WSL host (platform detection, root preflight and a 15 GiB versus 20 GiB free-space expectation). Neither full local gate nor BATS is described as green.This integration receipt supplements each PR's own regression and does not waive its independent review, live hardware/browser/upgrade gates or rollback requirements. The PRs remain drafts; none was merged upstream.