Repository navigation
Conversation
This was referenced Sep 14, 2026
tang-vu
marked this pull request as ready for review
September 15, 2026 01:31
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for independent review (2026-09-15). Candidate
821a0df7624a8c7d4058a407390a7b223e5e210chas a successful GitHub check rollup and no base-branch conflict at this review snapshot. This supersedes earlier draft-status wording only. All validation gaps, migration requirements, live gates and independent human review requirements below remain in force; this is not a merge-ready approval.ChromaDB 1.5.3 starts with
/config.yamlspecifyingpersist_path: /data, but the ODS recipe mountsdata/chromadbat/chromadb. A successful collection/vector insert therefore disappears when its container is recreated.Why this matters
An extension update or recreation can erase a user's vector database even though
data/chromadbappears to be configured for persistence. Mount the existing host directory at the path the shipped server actually writes, and pin that same 1.5.3 image by its verified multi-architecture digest. Preserve the existing HTTP health probe, loopback binding and API port.The README explicitly requires stopping and copying the old container's complete
/datadirectory before recreation, retaining the backup, avoiding merges of populated databases, and checking known collection contents afterward. It does not silently replace or auto-migrate operator data. If the old container is already gone, this fix cannot recover its deleted writable layer. The documented collection example now uses the exact v2 tenant/database route needed to verify the stored data.Overlap check
Searched open and closed PRs for
chromadbandChroma persistence, plus changed production files underextensions/library/services/chromadb. Merged #4890 fixes the Rust image's missing healthcheck executable and explicitly leaves data paths unchanged; #1066/#635/#609 are older health/API probe changes. #554 changes manifest metadata. No existing PR corrects the persistent mount or verifies collection survival. This PR retains #4890's health behavior and adds a separate persistence boundary test.Validation
git diff --checkpass.make gateretains the baseline root/WSL no-sudo fixture failure; the complete local gate is not claimed green.docker cpcould not write there. Follow-up821a0df7creates the fixture destination as the calling user before Compose, matching the README's operator-created backup directory. Both local live cases passed again; the replacement GitHub head passed 33 checks with 4 intentional skips, including both live persistence cases.Still requires independent review of the operational data-recovery instructions. Live evidence is Linux amd64 with a fresh fixture and a stopped legacy fixture; no user database, hardware fleet or native ARM/macOS/Windows activation was used. Backups must retain the complete database directory and matching image. Reverting only the mount fix reintroduces data loss, so preserve the corrected mount when rolling back unrelated changes.
Final candidate
821a0df7624a8c7d4058a407390a7b223e5e210c: 33 successful CI checks, 4 conditionally skipped; no pending or failed checks.Batch integration receipt
This is one of 30 independently branched public-beta PRs. The published synthetic integration head is
61f4c6fccc81bea697f4941683fefb5089ba77f4, built from baselined49ad4bbc760be319de7f4c9b9a93b1f18fe3922in this reproducible order:#4946 → #4948 → #4951 → #4954 → #4972 → #4960 → #4961 → #4957 → #4964 → #4967 → #4968 → #4971 → #4975 → #4976 → #4984 → #4982 → #4990 → #4988 → #4989 → #4997 → #5003 → #5006 → #5007 → #5009 → #5012 → #5011 → #5013 → #5014 → #5020 → #5021
Reconciliation preserved all 146 files owned by a single PR byte-for-byte against their exact candidate heads. The eight shared paths preserve both CLI STT/TTS commands and help, every added Makefile test, both environment schema additions and all Extensions UI behavior. LanguageTool and Kroki both remain headless API entries. Canonical regeneration yields 76 catalog entries and 47 library manifests; all README rows are retained. Shared-file changes need these additive resolutions when merged independently.
Combined validation: 2,852 API tests passed / 1 skipped; 1,082 UI tests passed; 47 manifests passed; all 12 added Makefile commands passed; 12 catalog boundary tests passed / 12 opt-in runtime tests skipped in this combined run. Individual exact-image results remain documented above. UI lint/build, scoped secret hooks, diff checks, four platform smoke tests and installer simulation passed. Compose plans for NVIDIA/AMD/Apple each contain 20 services and no duplicate published bindings across the core plus 12 new recipes; this is static plan evidence, not simultaneous startup or GPU inference.
The first unrestricted UI run timed out in two tests under concurrent load; the complete rerun used
--maxWorkers=2with unchanged assertions and timeouts and passed. ESLint reports zero errors and 603 warnings, including the existing JSX usage-detection pattern. Full localmake gatestill fails the no-sudo Docker baseline covered by #3158. BATS records 416 passed / 5 failed on this root/WSL host (platform detection, root preflight and a 15 GiB versus 20 GiB free-space expectation). Neither full local gate nor BATS is described as green.This integration receipt supplements each PR's own regression and does not waive its independent review, live hardware/browser/upgrade gates or rollback requirements. The PRs remain drafts; none was merged upstream.