Repository navigation
Conversation
This was referenced Sep 14, 2026
tang-vu
marked this pull request as ready for review
September 15, 2026 01:31
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for independent review (2026-09-15). Candidate
1ecec1f0389be25253814eeb0148948d7feb23dehas a successful GitHub check rollup and no base-branch conflict at this review snapshot. This supersedes earlier draft-status wording only. All validation gaps, migration requirements, live gates and independent human review requirements below remain in force; this is not a merge-ready approval.Why this matters
Operators need to inspect local dataset snapshots without opening a writable connection to another ODS application's live database. Add a complete Datasette recipe for private table browsing, filtering, read-only SQL and CSV/JSON export, reachable through the existing extension install lifecycle.
Production contract
datasetteproject/datasette:0.65.4@sha256:04ad0a3eb3d253b8c066d9491b7205ede911074d819c1f56dd40952a611b857d. Its published image is Linux amd64 only: Compose declares that platform and the manifest/README exclude an Apple/ARM compatibility claim..db,.sqliteand.sqlite3snapshots as immutable databases, preserving names with spaces. It never enables directory-mode plugin/config discovery from user data..envrotation invalidates them.pixel-inferencemanifest without enabling it.Overlap check
Searched all open/closed upstream PRs for
Datasetteand changed production recipe paths in the PR file inventory: none exists. Reviewed shared library README/catalog history. Existing Jupyter/Label Studio/Baserow workflows do not provide this immutable SQLite snapshot browser. New recipe additions in #4984, #4990, #4988 and #5003 are independent services; integration regeneration must retain each entry once and update the total count.Validation
22-live-public-links, 72.71 seconds of pytest). Healthy empty installation, missing-secret refusal, anonymous denial, one-use root login and replay refusal, persistent session across recreation, real Unicode/space-named SQLite snapshot, table filter, SQL aggregate, CSV quoting, SQL-write rejection and disabled file download. Repeated container replacement leaves the snapshot SHA-256 unchanged and creates no WAL/journal; an adjacent failing Python plugin is never loaded.path). No early failure is presented as a passing runtime check.git diff --checkpassed. No dashboard implementation changes.make gatereproduces the existing root/WSL no-sudo Docker fallback failures already addressed by open fix(installer): honor unavailable sudo in Docker fallback #3158. It is not a full local gate pass. A new path-filtered GitHub job runs the exact-image boundary test.Review and limitations
Ready for independent review and CI. No user databases, browser automation, ARM emulation, native Windows/macOS, large datasets or remote TLS were tested. This is a single local operator session, not a multi-user identity system. Signed-in users can read all mounted rows; result limits do not redact data. The upstream image is preserved as published, including its base/dependency choices; further image maintenance should be reviewed separately.
Final candidate
1ecec1f0389be25253814eeb0148948d7feb23de: 33 successful CI checks, 4 conditionally skipped; no pending or failed checks.Batch integration receipt
This is one of 30 independently branched public-beta PRs. The published synthetic integration head is
61f4c6fccc81bea697f4941683fefb5089ba77f4, built from baselined49ad4bbc760be319de7f4c9b9a93b1f18fe3922in this reproducible order:#4946 → #4948 → #4951 → #4954 → #4972 → #4960 → #4961 → #4957 → #4964 → #4967 → #4968 → #4971 → #4975 → #4976 → #4984 → #4982 → #4990 → #4988 → #4989 → #4997 → #5003 → #5006 → #5007 → #5009 → #5012 → #5011 → #5013 → #5014 → #5020 → #5021
Reconciliation preserved all 146 files owned by a single PR byte-for-byte against their exact candidate heads. The eight shared paths preserve both CLI STT/TTS commands and help, every added Makefile test, both environment schema additions and all Extensions UI behavior. LanguageTool and Kroki both remain headless API entries. Canonical regeneration yields 76 catalog entries and 47 library manifests; all README rows are retained. Shared-file changes need these additive resolutions when merged independently.
Combined validation: 2,852 API tests passed / 1 skipped; 1,082 UI tests passed; 47 manifests passed; all 12 added Makefile commands passed; 12 catalog boundary tests passed / 12 opt-in runtime tests skipped in this combined run. Individual exact-image results remain documented above. UI lint/build, scoped secret hooks, diff checks, four platform smoke tests and installer simulation passed. Compose plans for NVIDIA/AMD/Apple each contain 20 services and no duplicate published bindings across the core plus 12 new recipes; this is static plan evidence, not simultaneous startup or GPU inference.
The first unrestricted UI run timed out in two tests under concurrent load; the complete rerun used
--maxWorkers=2with unchanged assertions and timeouts and passed. ESLint reports zero errors and 603 warnings, including the existing JSX usage-detection pattern. Full localmake gatestill fails the no-sudo Docker baseline covered by #3158. BATS records 416 passed / 5 failed on this root/WSL host (platform detection, root preflight and a 15 GiB versus 20 GiB free-space expectation). Neither full local gate nor BATS is described as green.This integration receipt supplements each PR's own regression and does not waive its independent review, live hardware/browser/upgrade gates or rollback requirements. The PRs remain drafts; none was merged upstream.