Repository navigation
Conversation
This was referenced Sep 4, 2026
Collaborator
|
Thanks for this contribution. We're closing outside-contributor pull requests that have had no activity for 14 days or more, so the queue reflects work that can still land. This isn't a judgment on the change itself. If it's still needed, please rebase onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.sh --tuiconfiguration menu for Linux, WSL2, and macOS--tuiis mixed with CLI flagsCloses #2309.
Why this matters
Operators currently have to discover profiles and flags before they can review installer defaults. The new menu makes those choices visible up front, supports custom absolute install paths, and provides an explicit final receipt before any system-changing installer phase runs.
The behavioral invariant is: the menu may collect and translate configuration, but only the existing installer owns installation effects. Cancellation must never dispatch the installer.
Overlap check
Searched open and closed upstream PR titles/bodies for
installer TUI configuration menu, reviewed the latest 1,000 open PRs and their changed production files, and inspected history forods/install.sh. No open or closed PR covers this scope, no currently open PR changes this entrypoint, and its upstream history only contains the repository rename. Issue #2309 is the direct product request.Test plan
bats installer-configuration-tui.bats- 4/4 passing against the publicinstall.shboundarybash -n ods/install.shshellcheck --rcfile=/dev/null -e SC1090,SC1091,SC3003 ods/install.shgit diff --checkDesign and operational notes
install.ps1, with an explicit error if a PowerShell target reaches this mode.--allcontract. Other profiles emit explicit positive/negative service flags so the review receipt is deterministic.Generated with Codex.
Batch compatibility
CI follow-up
CI integration-smoke exposed a SIGPIPE race in the first help implementation: the dispatcher wrote its TUI hint before install-core rendered the rest of help, so a short grep reader could close the pipe under pipefail. Follow-up commit 6650e11 buffers delegated help, preserves its status, and writes defensively. The added public-boundary regression reproduces the exact piped probe; 4/4 focused BATS tests, ShellCheck, and integration-test.sh (69 passed, 3 skipped) now pass, and the rerun of every required GitHub check is green.