Repository navigation
Conversation
This was referenced Sep 16, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
An eight-GPU host makes GPU Monitor 585 px wide in a 320 px viewport. Assignment badges escape the page and the two-column mobile card layout squeezes telemetry. Operators checking a host from a phone cannot read all assigned devices.
Use one card column on small screens, wrap assignment badges within their panel, and allow the topology panel to shrink around its scrollable matrix. The matrix is keyboard focusable with an accessible name. Desktop columns and all reported device data remain intact.
Overlap check
Searched live open/closed PR titles and changed files for GPUMonitor, AssignmentTable, TopologyView, GPUCard, assignment, and layout. #2318 changes assignment labels/styles; #3712 adds topology link focus; #2029 changes legend colors; #2306 guards null card fields; #3711 exports history. None addresses multi-device layout overflow. #3712 shares the GPU-chip markup and will need to retain the wrapping classes when combined; there is no functional dependency.
Validation
scripts/check-gpu-layout.mjs, a real-browser regression rendering the production GPU Monitor page and stylesheet with eight-device API fixtures. It checks overview/history at 320, 390, 768, and 1280 px, device-label bounds, page overflow, and keyboard scrolling of overflowing topology matrices.npm test -- --maxWorkers=2 src/components/GPUCard.test.jsx src/hooks/__tests__/useGPUDetailed.recovery.test.js: 6 passed.npm run lint: 0 errors, 597 existing warnings.npm run buildandgit diff --check: passed.npm install --no-save --package-lock=false playwright@1.63.0,npx playwright install chromium, thennode scripts/check-gpu-layout.mjs. This optional browser check is not claimed as an existing CI job.Risk and review
Medium, dashboard presentation only. No GPU probing, assignment, runtime configuration, or hardware activation changes. Validation uses API fixtures in Chromium on Linux; native Safari and physical multi-GPU hardware were not exercised. Reverting restores the prior layout without a migration. Independent human review remains pending.
AI assisted diagnosis, implementation, tests, and this description.
Current validation
At the 2026-09-14 audit, head
8afa90607d90ccb0e2f5057d2856e9191d3fdaa1has 32 successful and 4 skipped hosted checks, with no failed or pending checks. Independent human review and the declared deployed/platform checks remain merge gates.Local synthetic integration head
e8f982f09ba4c714ee2a65cb6867ea3e4328bfdecombines the 30 September 14 candidates. Its complete frontend suite passes 144 files / 1,125 tests, and its production build passes.