feat(reports): leftover-map origin on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share and leftover-map singular values (v2.92.0) - #877
Conversation
… leftover-map axis ticks (v2.92.0)
Caption leftover-map comparison graphic leftover-map axis origin ticks through leftoverMapComparePlotTickAxisBadge independently of leftover-map axis share and leftover-map singular values (ADR 0335). Origin 0.00 stays leftover map comparison graphic leftover-map axis {k} origin tick {value} so buyers can tell the rank-0 unused-axis location from leftover-map coordinate ticks. Share and σ omit independently. Do not invent leftover-map origin from share or σ. UI-only; no SQL; no leftover-map inner product, cosine, or length.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Leave this PR open for independent APPROVE. Do not squash-merge onto the unprotected leftover base. Do not self-approve. Devin/Copilot COMMENT is not APPROVE. Stacked onto leftover-axis tick leftover-map axis share ( Cycle 2026-08-31 16:22 KST: GitHub writes work as seonghobae. #96 already closed (duplicate of #91). #875 left open (Devin COMMENTED, not APPROVE). This increment is leftover-map origin on leftover-map comparison graphic leftover-map axis ticks (ADR 0335 / v2.92.0). oxlint + tsc -b + vitest leftover-map + App + i18n 737 passed. Never invent leftover/theta. Do not persist leftover-map inner product, cosine, or length. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| export function leftoverMapPlotTickIsOrigin(tickLabel: string): boolean { | ||
| const originLabel = formatSignedLeftoverValue(0); | ||
| return originLabel !== null && tickLabel === originLabel; | ||
| } |
There was a problem hiding this comment.
📝 Info: Rounded coordinates preserve origin identity
uniqueCoordinateTicks inserts zero before persisted coordinates and deduplicates their formatted labels. A tiny nonzero coordinate cannot replace the true origin.
Was this helpful? React with 👍 or 👎 to provide feedback.
…r-axis independently of leftover-map comparison graphic leftover-map origin (v2.114.0)
Caption leftover-map comparison leftover-axis leftover-map origin through leftoverMapCompareAxisOriginBadge (ADR 0357). Distinct accessible name leftover map comparison leftover axis leftover-map origin {origin}. Rank-0 unused axes still name leftover-map origin (0.00, 0.00). leftoverMapAxisOriginBadge stays unnamed. No SQL. Do not invent leftover-map origin from ζ, leftover-map axis share, or σ_k. Do not mix #877. Do not mix #890.
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
make seed, leftover-map comparison graphic leftover-map axis origin ticks name leftover-map origin0.00when leftoverMapComparePlotTickAxisBadge returns a usable leftover-map origin tick caption even when leftover-map axis share or leftover-map singular values are omitted; click a leftover pair opens that post.leftover map comparison graphic leftover-map axis {k} origin tick {value}when leftover-map axis share andσ_komit,leftover map comparison graphic leftover-map axis {k} origin tick {value} {share}%when leftover-map axis share is finite andσ_komits,leftover map comparison graphic leftover-map axis {k} origin tick {value} σ {singular}whenσ_kis finite and leftover-map axis share omits, andleftover map comparison graphic leftover-map axis {k} origin tick {value} σ {singular} {share}%when both are finite so they stay distinct from leftover-map comparison graphic leftover-map axis ticksleftover map comparison graphic leftover-map axis {k} tick {value} σ {singular} {share}%(ADR 0331), from leftover-map graphic leftover-map axis ticksleftover-map axis {k} tick {value} σ {singular} {share}%(ADR 0332), from leftover-map comparison leftover-axis ticksleftover map comparison leftover axis {k} tick {value} σ {singular} {share}%(ADR 0333), from leftover-axis ticksleftover axis {k} tick {value} σ {singular} {share}%(ADR 0334), and from leftover-map comparison graphic leftover-map axisleftover map comparison graphic leftover-map axis {k} σ {value} ({share}%)(ADR 0326).0.00and leftover-map axis share0%. Share and singular value omit independently. Do not invent leftover-map origin from leftover-map axis share orσ_k. Do not invent leftover-map axis share fromσ_k. Do not inventσ_kfrom leftover-map axis share.feat/leftover-map-axis-tick-share-badge-v2910/ feat(reports): leftover-map axis share on leftover-axis ticks independently of leftover-map singular values (v2.91.0) #875 @d19f1fd). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240/ feat(reports): persist leftover-map coordinates (v2.24.0) #782) rather than squash-merging here. Issues Milestone 2: port verified direct-PostgreSQL analysis into the protected product architecture #79 and Milestone 2.1: add normalized runtime-analysis schema bridge after v0.77 #87 stay open. Do not merge revert: undo #782 squash until independent APPROVE #808 without independent APPROVE.Test plan
leftoverMapPlotAxisSingular.test.tsleftoverMapComparePlotTickAxisBadge names leftover-map origin0.00with σ 1.84/0.86 and share 82%/18%, share-only when σ omits, σ-only when share omits, rank-0 origin share 0%, does not invent origin from share or σ, distinct from leftoverMapPlotTickAxisBadge / leftoverMapCompareAxisTickBadge / leftoverMapAxisTickBadge / leftoverMapComparePlotAxisBadgeLeftoverMapPlot.test.tsxcomparison graphic leftover-map axis origin tickleftover map comparison graphic leftover-map axis 1 origin tick 0.00 σ 1.84 82%; leftover-map graphic leftover-map axis ticks stayleftover-map axis {k} tick {value}i18n.test.tsko/zh/ja/vi leftover-map comparison graphic leftover-map axis origin tick keystsc -b+ vitest leftover-map + App + i18n (737 passed)