Skip to content

feat(reports): leftover-map item coordinates on leftover-map comparison graphic leftover-map criterion markers independently of leftover-map post ξ markers (v2.93.0) - #878

Draft
seonghobae wants to merge 1 commit into
feat/leftover-map-plot-criterion-coordinates-v2920from
feat/leftover-map-compare-plot-criterion-coordinates-v2930
Draft

feat(reports): leftover-map item coordinates on leftover-map comparison graphic leftover-map criterion markers independently of leftover-map post ξ markers (v2.93.0)#878
seonghobae wants to merge 1 commit into
feat/leftover-map-plot-criterion-coordinates-v2920from
feat/leftover-map-compare-plot-criterion-coordinates-v2930

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Caption leftover-map comparison graphic leftover-map criterion markers with persisted leftover-map item coordinates through leftoverMapComparePlotCriterionBadge independently of leftover-map post ξ markers (ADR 0336 / v2.93.0).
  • After make seed, leftover-map comparison graphic leftover-map criterion markers name persisted leftover-map item coordinates when leftoverMapComparePlotCriterionBadge returns a usable leftover-map comparison graphic leftover-map criterion leftover-map item coordinate caption; click a leftover pair or a leftover-map post marker opens that post.
  • Leftover-map comparison graphic leftover-map criterion markers stay leftover map comparison graphic leftover-map criterion {label} at ζ {item} when leftover-map item coordinates are finite so they stay distinct from leftover-map graphic leftover-map criterion markers leftover-map criterion {label} at ζ {item} and from leftover-map post markers Open leftover-map post {title} at ξ {person}.
  • A missing or non-finite leftover-map item coordinate pair omits that leftover-map comparison graphic leftover-map criterion leftover-map item coordinate caption and keeps Criterion ζ {label}. Rank-0 unused axes still name leftover-map item coordinates (0.00, 0.00). Do not invent leftover-map item coordinates from leftover-map post ξ. Do not invent leftover-map post ξ from leftover-map item coordinates.
  • UI-only; no SQL; no new columns. Never invent a leftover score. Never invent a theta. Do not persist leftover-map inner product, cosine, or length. This increment does not change leftover-map graphic leftover-map criterion markers, leftover-axis ticks, leftover-map graphic leftover-map axis ticks, leftover-map comparison leftover-axis ticks, or leftover-map comparison graphic leftover-map axis ticks.
  • Stacked onto leftover-map graphic leftover-map criterion leftover-map item coordinates as leftoverMapPlotCriterionBadge (feat/leftover-map-plot-criterion-coordinates-v2920 / feat(reports): leftover-map item coordinates on leftover-map graphic leftover-map criterion markers independently of leftover-map post ξ markers (v2.92.0) #876 @ 89ed56b). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget leftover-map stack onto leftover-coordinates (feat/leftover-map-coordinates-v2240 / feat(reports): persist leftover-map coordinates (v2.24.0) #782, already merged to main) rather than squash-merging here. Issues Milestone 2: port verified direct-PostgreSQL analysis into the protected product architecture #79 and Milestone 2.1: add normalized runtime-analysis schema bridge after v0.77 #87 stay open. Do not merge revert: undo #782 squash until independent APPROVE #808 without independent APPROVE.

Test plan

  • leftoverMapPlotLayout.test.ts leftoverMapComparePlotCriterionBadge names ζ (+0.50, −0.02) / ζ (−0.70, −0.40), rank-0 ζ (0.00, 0.00), omits null/NaN/∞ independently of leftover-map post ξ, distinct from leftoverMapPlotCriterionBadge / leftover-map post action
  • LeftoverMapPlot.test.tsx leftover-map comparison graphic leftover-map criterion leftover map comparison graphic leftover-map criterion sales-lead at ζ (+0.50, −0.02); leftover-map graphic leftover-map criterion stays leftover-map criterion sales-lead at ζ (+0.50, −0.02)
  • App.test.tsx grouping comparison leftover-map criterion leftover map comparison graphic leftover-map criterion sales-lead at ζ (+0.50, −0.02); leftover-map graphic leftover-map criterion stays leftover-map criterion sales-lead at ζ (+0.50, −0.02)
  • i18n.test.ts ko/zh/ja/vi leftover-map comparison graphic leftover-map criterion ζ keys
  • oxlint 0 + tsc -b + vitest leftover-map + App + i18n (814 passed)

Devin Review

…on graphic leftover-map criterion markers independently of leftover-map post ξ markers (v2.93.0)

Caption leftover-map comparison graphic leftover-map criterion markers with persisted leftover-map item coordinates through leftoverMapComparePlotCriterionBadge independently of leftover-map post ξ markers (ADR 0336). Rank-0 unused axes still name leftover-map item coordinates (0.00, 0.00). A missing or non-finite leftover-map item coordinate pair omits independently of leftover-map post ξ. Do not invent leftover-map item coordinates from leftover-map post ξ. UI-only; no SQL; never invent a leftover score or a theta.

Copy link
Copy Markdown
Contributor Author

Leave #878 open for independent APPROVE on exact head 617b971. Do not squash-merge. Do not self-approve. Copilot/Devin COMMENT is not independent APPROVE. Stacked onto leftover-map graphic leftover-map criterion leftover-map item coordinates (feat/leftover-map-plot-criterion-coordinates-v2920 / #876 @ 89ed56b). After independent review, retarget leftover-map stack onto leftover-coordinates (feat/leftover-map-coordinates-v2240 / #782, already merged to main) rather than squash-merging here. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. Leftover-map graphic leftover-map criterion markers stay leftover-map criterion {label} at ζ {item} this increment.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 69455832-5a6a-4721-b409-6e251fe6261f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Queue retry 2026-08-31T17:05 KST. Exact head 617b971. Frontend lint/test/build + Full test suite succeeded on this head. Devin COMMENT is not independent APPROVE. Leave open. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE.

Copy link
Copy Markdown
Contributor Author

Queue retry 2026-08-31T17:03 KST: stacked v2.94.0 leftover-map comparison graphic leftover-map post ξ (ADR 0337 leftoverMapComparePlotPostBadge) is in local clone on feat/leftover-map-compare-plot-post-coordinates-v2940 from this head 617b971. Graphic leftover-map post action is unchanged. Comparison leftover-map post markers name ξ independently of graphic leftover-map post copy and of leftover-map comparison leftover-map criterion ζ (ADR 0336). Rank-0 origin still names (0.00, 0.00). Fail-closed omit on missing/non-finite ξ. No SQL. No new columns. Do not persist leftover-map inner product/cosine/length. Do not mix #877 origin-tick stack. Leave this PR open for independent review. Devin COMMENT is not independent APPROVE. Do not self-approve. Do not squash-merge onto the unprotected leftover-map base. Issues #79 and #87 stay open. #96 close retried this cycle.

Copy link
Copy Markdown
Contributor Author

v2.94.0 stacked as #879 (feat/leftover-map-compare-plot-post-coordinates-v2940 @ d9972c2) onto this head. leftover-map comparison graphic leftover-map post markers now name persisted leftover-map person coordinates through leftoverMapComparePlotPostBadge independently of leftover-map comparison leftover-map criterion ζ (ADR 0337). Leave both PRs open for independent review. Do not self-approve. Do not squash-merge. Do not mix #877.

@seonghobae
seonghobae marked this pull request as draft September 4, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant