feat(reports): leftover-map origin on leftover-map comparison leftover-pair leftover-map post leftover-map person coordinates independently of leftover-map pair leftover-map post leftover-map origin leftover-map person coordinates (v2.110.0) - #917
Conversation
…r-pair leftover-map post leftover-map person coordinates independently of leftover-map pair leftover-map post leftover-map origin leftover-map person coordinates (v2.110.0)
Caption leftover-map comparison leftover-pair leftover-map post leftover-map origin leftover-map person coordinates through leftoverMapCompareListPostBadge independently of leftover-map pair leftover-map post leftover-map origin leftover-map person coordinates (ADR 0353). Distinct accessible name leftover map comparison leftover pair leftover-map post {title} at leftover-map origin ξ {person} when leftoverMapPlotCoordinatePairIsOrigin returns true. Rank-0 unused axes still name leftover-map origin (0.00, 0.00). leftoverMapListPostBadge stays leftover-map pair leftover-map post leftover-map origin leftover-map person coordinate keys. leftoverMapComparePlotPostBadge stays leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinate keys. leftoverMapCompareListCriterionBadge stays leftover-map comparison leftover-pair leftover-map criterion leftover-map item coordinate keys. Do not invent leftover-map origin from leftover-map item coordinates ζ. Do not mix #877.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact-head identity for independent review.
Leave open for independent APPROVE on this exact head. Do not self-approve. Do not squash-merge onto unprotected leftover bases. Issues #79 and #87 stay OPEN. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| if (person === null) { | ||
| return null; | ||
| } | ||
| return { key: LEFTOVER_MAP_COMPARE_LIST_POST_ACTION, values: { title, person } }; | ||
| const origin = leftoverMapPlotCoordinatePairIsOrigin(person); | ||
| return { | ||
| key: origin ? LEFTOVER_MAP_COMPARE_LIST_POST_ACTION_ORIGIN : LEFTOVER_MAP_COMPARE_LIST_POST_ACTION, |
There was a problem hiding this comment.
📝 Info: Origin detection remains coordinate-local
leftoverMapCompareListPostBadge selects the origin key from validated person coordinates alone. Item coordinates cannot create or suppress this caption.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
| const origin = leftoverMapPlotCoordinatePairIsOrigin(person); | ||
| return { | ||
| key: origin ? LEFTOVER_MAP_COMPARE_LIST_POST_ACTION_ORIGIN : LEFTOVER_MAP_COMPARE_LIST_POST_ACTION, |
There was a problem hiding this comment.
📝 Info: Displayed precision defines origin
Tiny finite coordinates that format as (0.00, 0.00) receive the origin label. Existing helpers and ADR 0353 use this displayed-coordinate contract.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle 2026-09-02T21:16 KST write retry. Exact head |
|
Stacked next buyer increment as #918 ( |
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Stacked on #916 @
7978e925(feat/leftover-map-list-criterion-origin-badge-v21090). leftoverMapCompareListPostBadge (ADR 0353 / v2.110.0) names leftover-map origin on leftover-map comparison leftover-pair leftover-map post leftover-map person coordinates independently of leftover-map pair leftover-map post leftover-map origin leftover-map person coordinates.leftover map comparison leftover pair leftover-map post {title} at leftover-map origin ξ {person}when leftoverMapPlotCoordinatePairIsOrigin returns true (formatLeftoverMapCoordinatePair(0, 0)===(0.00, 0.00)).(0.00, 0.00).leftover map comparison leftover pair leftover-map post {title} at ξ {person}.ζ.Exact head:
8192b48560a919c800ec47927adc966179a2b572Test plan
pnpm exec oxlinton leftover-map comparison leftover-pair post origin files: 0 warnings, 0 errorspnpm exec tsc -bcleanLeave open for independent review. Do not self-approve. Do not squash-merge.