Skip to content

feat(reports): leftover-map graphic leftover-map axis origin ticks independently of leftover-map axis share and leftover-map singular values (v2.100.0) - #885

Draft
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-list-criterion-coordinates-v2990from
feat/leftover-map-plot-tick-origin-badge-v21000
Draft

feat(reports): leftover-map graphic leftover-map axis origin ticks independently of leftover-map axis share and leftover-map singular values (v2.100.0)#885
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-list-criterion-coordinates-v2990from
feat/leftover-map-plot-tick-origin-badge-v21000

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked on #884 @ bcbb7ce (feat/leftover-map-compare-list-criterion-coordinates-v2990). leftoverMapPlotTickAxisBadge (ADR 0343 / v2.100.0) names leftover-map graphic leftover-map axis origin ticks independently of leftover-map axis share and leftover-map singular values.

  • Distinct accessible name leftover-map axis {axis} origin tick {value} when leftoverMapPlotTickIsOrigin returns true (formatSignedLeftoverValue(0) === 0.00).
  • Rank-0 unused axes still name leftover-map origin 0.00.
  • Share and singular omit independently as leftover-map axis {axis} origin tick {value} σ {singular}, leftover-map axis {axis} origin tick {value} {share}%, and leftover-map axis {axis} origin tick {value} σ {singular} {share}%.
  • Non-origin leftover-map graphic leftover-map axis ticks stay leftover-map axis {axis} tick {value}.
  • leftoverMapComparePlotTickAxisBadge stays leftover map comparison graphic leftover-map axis {axis} tick {value} this increment. Do not mix feat(reports): leftover-map origin on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share and leftover-map singular values (v2.92.0) #877.
  • Do not invent leftover-map origin from leftover-map axis share or leftover-map singular values σ_k.
  • UI-only. No SQL. No new columns. Never invent a leftover score. Never invent a theta.

Test plan

Leave open for independent review. Do not self-approve. Do not squash-merge.


Devin Review

…dependently of leftover-map axis share and leftover-map singular values (v2.100.0)

Caption leftover-map graphic leftover-map axis origin ticks through leftoverMapPlotTickAxisBadge independently of leftover-map axis share and leftover-map singular values (ADR 0343). Distinct accessible name leftover-map axis {axis} origin tick {value}. Rank-0 unused axes still name leftover-map origin 0.00. Share and singular omit independently. leftoverMapComparePlotTickAxisBadge stays leftover-map comparison graphic leftover-map axis tick keys. Do not invent leftover-map origin from leftover-map axis share or σ_k. Do not mix #877. UI-only. No SQL. Never invent a leftover score or a theta.

Copy link
Copy Markdown
Contributor Author

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a629178-197f-4892-b80d-2f132157722b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Stacked #886 @ 4a31a41 (feat/leftover-map-compare-plot-tick-origin-badge-v21010) names leftover-map comparison graphic leftover-map axis origin ticks as leftoverMapComparePlotTickAxisBadge (ADR 0344 / v2.101.0) independently of leftover-map axis share and leftover-map singular values. Distinct accessible name leftover map comparison graphic leftover-map axis {axis} origin tick {value}. Rank-0 unused axes still name leftover-map origin 0.00. leftoverMapPlotTickAxisBadge stays leftover-map graphic leftover-map axis origin tick keys. leftoverMapCompareAxisTickBadge and leftoverMapAxisTickBadge stay leftover-map tick keys. Do not mix #877. Leave both open for independent review. Do not self-approve. Do not squash-merge. Issues #79 and #87 stay OPEN. Do not merge #808 without independent APPROVE.

Copy link
Copy Markdown
Contributor Author

Exact head 7a6c038 still needs independent APPROVE (Devin COMMENT is not APPROVE). Only collaborator is seonghobae; this token cannot request an independent reviewer. Leave stacked leftover-map PRs open. Do not squash-merge onto unprotected leftover bases. Do not mix #877. Issues #79 and #87 stay OPEN. Do not merge #808 without independent APPROVE. Do not self-approve.

Copy link
Copy Markdown
Contributor Author

Cycle write probe 2026-08-31T11:00Z: independent APPROVE still required on exact head 7a6c038 (Devin COMMENT is not APPROVE). Stacked origin-tick PRs #886/#887/#889 remain open. Do not self-approve. Do not squash-merge. Do not mix #877. Issues #79 and #87 stay OPEN. Do not merge #808 without independent APPROVE.

This was referenced Aug 31, 2026
@seonghobae
seonghobae marked this pull request as draft September 3, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant